[ES|QL] Discover to dashboard with controls, saving the histogram#237070
Merged
stratoula merged 26 commits intoelastic:mainfrom Oct 10, 2025
Merged
[ES|QL] Discover to dashboard with controls, saving the histogram#237070stratoula merged 26 commits intoelastic:mainfrom
stratoula merged 26 commits intoelastic:mainfrom
Conversation
…ub.com/stratoula/kibana into discover-dashboard-chart-with-controls
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#9440[✅] src/platform/test/functional/apps/discover/tabs/config.ts: 50/50 tests passed. |
stratoula
added
v9.3.0
Feature:ES|QL
PhilippeOberti
approved these changes
Oct 9, 2025
Contributor
PhilippeOberti
left a comment
PhilippeOberti
left a comment
There was a problem hiding this comment.
Code review only, LGTM for the @elastic/security-threat-hunting-investigations team
walterra
approved these changes
Oct 10, 2025
Contributor
walterra
left a comment
walterra
left a comment
There was a problem hiding this comment.
LGTM for datavis team. Manually tested the new behaviour, also tested with multiple charts bringing the same control to a dashboard. Verified functional tests.
nreese
approved these changes
Oct 10, 2025
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
kibana-presentation changes LGTM - approving with understanding that follow on PR will remove navigateToWithMultipleEmbeddablePackage and update navigateToWithEmbeddablePackage to only support an array of embeddables.
code review and tested in chrome
Contributor
⏳ Build in-progress, with failures
Failed CI Steps
Test Failures
History
|
1 task
stratoula
added a commit
that referenced
this pull request
Oct 16, 2025
## Summary Follow up of #237070 This is a cleanup after the above got merged. We are: - Removing the `navigateToWithEmbeddablePackage ` in favor of `navigateToWithMultipleEmbeddablePackage `. So now we navigate with an array of states - Removes the `getIncomingState ` in favor of `getIncomingPackagesState ` - Small changes to the consumers to respect the above ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
mgadewoll
pushed a commit
to tkajtoch/kibana
that referenced
this pull request
Oct 17, 2025
## Summary Follow up of elastic#237070 This is a cleanup after the above got merged. We are: - Removing the `navigateToWithEmbeddablePackage ` in favor of `navigateToWithMultipleEmbeddablePackage `. So now we navigate with an array of states - Removes the `getIncomingState ` in favor of `getIncomingPackagesState ` - Small changes to the consumers to respect the above ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
…astic#237070) ## Summary Closes elastic#235477 Allows to navigate to a dashboard and carry also the controls with the embeddable state. This enables to carry the controls when the user tries to save the Lens chart from Discover which is controlled by an ES|QL control.  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Oct 23, 2025
…astic#237070) ## Summary Closes elastic#235477 Allows to navigate to a dashboard and carry also the controls with the embeddable state. This enables to carry the controls when the user tries to save the Lens chart from Discover which is controlled by an ES|QL control.  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Oct 23, 2025
## Summary Follow up of elastic#237070 This is a cleanup after the above got merged. We are: - Removing the `navigateToWithEmbeddablePackage ` in favor of `navigateToWithMultipleEmbeddablePackage `. So now we navigate with an array of states - Removes the `getIncomingState ` in favor of `getIncomingPackagesState ` - Small changes to the consumers to respect the above ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Oct 27, 2025
…astic#237070) ## Summary Closes elastic#235477 Allows to navigate to a dashboard and carry also the controls with the embeddable state. This enables to carry the controls when the user tries to save the Lens chart from Discover which is controlled by an ES|QL control.  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Oct 27, 2025
## Summary Follow up of elastic#237070 This is a cleanup after the above got merged. We are: - Removing the `navigateToWithEmbeddablePackage ` in favor of `navigateToWithMultipleEmbeddablePackage `. So now we navigate with an array of states - Removes the `getIncomingState ` in favor of `getIncomingPackagesState ` - Small changes to the consumers to respect the above ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This was referenced Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #235477
Allows to navigate to a dashboard and carry also the controls with the embeddable state.
This enables to carry the controls when the user tries to save the Lens chart from Discover which is controlled by an ES|QL control.
Checklist