[ResponseOps][Connectors] Fix headers for openai connector#237234
Merged
adcoelho merged 4 commits intoelastic:mainfrom Oct 2, 2025
Merged
[ResponseOps][Connectors] Fix headers for openai connector#237234adcoelho merged 4 commits intoelastic:mainfrom
adcoelho merged 4 commits intoelastic:mainfrom
Conversation
adcoelho
added
release_note:skip
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
georgianaonoleata1904
approved these changes
Oct 2, 2025
| let configHeaders: Record<string, string>; | ||
| let secretHeaders: Record<string, string>; | ||
|
|
||
| if (formData.actionTypeId === '.gen-ai') { |
Contributor
There was a problem hiding this comment.
Are we sure that only gen-ai connector needs config headers this way?
Contributor
Author
There was a problem hiding this comment.
Only 3 types have header logic(check line 118).
if (
formData.actionTypeId !== '.webhook' &&
formData.actionTypeId !== '.cases-webhook' &&
formData.actionTypeId !== '.gen-ai'
) {
return formData;
}
If it is not one of these, the data is returned as is.
The problem was that when the changes were introduced for the webhook connectors in #233695, they were applied to all these 3 types when gen-ai should have kept the old logic 😬
This is also the motivation for #236733. The whole serializer logic needs to be cleaned up.
Contributor
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
cc @adcoelho |
kibanamachine
added
backport:skip
adcoelho
added a commit
to adcoelho/kibana
that referenced
this pull request
Oct 2, 2025
…37234) Fixes elastic#237196 ## Summary Reverts some of the changes from elastic#233695 to keep the OpenAI-specific serializer logic. (cherry picked from commit c7f43df)
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
adcoelho
added a commit
that referenced
this pull request
Oct 3, 2025
…7234) (#237312) # Backport This will backport the following commits from `main` to `9.2`: - [[ResponseOps][Connectors] Fix headers for openai connector (#237234)](#237234) <!--- Backport version: 10.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Antonio","email":"antonio.coelho@elastic.co"},"sourceCommit":{"committedDate":"2025-10-02T13:44:34Z","message":"[ResponseOps][Connectors] Fix headers for openai connector (#237234)\n\nFixes #237196\n\n## Summary\n\nReverts some of the changes from #233695 to keep the OpenAI-specific\nserializer logic.","sha":"c7f43dfd248cac21d35f772aa4186f0530637f40","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team:ResponseOps","v9.2.0"],"title":"[ResponseOps][Connectors] Fix headers for openai connector","number":237234,"url":"https://github.com/elastic/kibana/pull/237234","mergeCommit":{"message":"[ResponseOps][Connectors] Fix headers for openai connector (#237234)\n\nFixes #237196\n\n## Summary\n\nReverts some of the changes from #233695 to keep the OpenAI-specific\nserializer logic.","sha":"c7f43dfd248cac21d35f772aa4186f0530637f40"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/237234","number":237234,"mergeCommit":{"message":"[ResponseOps][Connectors] Fix headers for openai connector (#237234)\n\nFixes #237196\n\n## Summary\n\nReverts some of the changes from #233695 to keep the OpenAI-specific\nserializer logic.","sha":"c7f43dfd248cac21d35f772aa4186f0530637f40"}}]}] BACKPORT--> Co-authored-by: Janki Salvi <117571355+js-jankisalvi@users.noreply.github.com>
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
…37234) Fixes elastic#237196 ## Summary Reverts some of the changes from elastic#233695 to keep the OpenAI-specific serializer logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #237196
Summary
Reverts some of the changes from #233695 to keep the OpenAI-specific serializer logic.