[Dashboards] Soften validation on filter schema#237477
Merged
nickpeihl merged 1 commit intoelastic:mainfrom Oct 3, 2025
Merged
[Dashboards] Soften validation on filter schema#237477nickpeihl merged 1 commit intoelastic:mainfrom
nickpeihl merged 1 commit intoelastic:mainfrom
Conversation
nickpeihl
added
release_note:fix
Team:Presentation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
nickpeihl
commented
Oct 3, 2025
| params: schema.maybe(schema.any()), | ||
| value: schema.maybe(schema.string()), | ||
| }, | ||
| { unknowns: 'allow' } |
Contributor
Author
There was a problem hiding this comment.
This is the key change. These rest of the diff is formatting.
Contributor
💚 Build Succeeded
Metrics [docs]
|
davismcphee
approved these changes
Oct 3, 2025
Contributor
davismcphee
left a comment
davismcphee
left a comment
There was a problem hiding this comment.
Code-only review, Data Discovery changes LGTM 👍
Contributor
|
Starting backport for target branches: 9.2 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 3, 2025
Fixes elastic#237472 Fixes a bug where dashboards can not be saved when a filter pill has a combined filter using OR or AND operations. The filters schema from the package that dashboard uses in it's validation does not account for combined filters in the filter pills. I recommend we fall back to softening the validation while we work on these schemas for the public API. (cherry picked from commit 393580e)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 3, 2025
) # Backport This will backport the following commits from `main` to `9.2`: - [[Dashboards] Soften validation on filter schema (#237477)](#237477) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nick Peihl","email":"nick.peihl@elastic.co"},"sourceCommit":{"committedDate":"2025-10-03T20:13:51Z","message":"[Dashboards] Soften validation on filter schema (#237477)\n\nFixes https://github.com/elastic/kibana/issues/237472\n\nFixes a bug where dashboards can not be saved when a filter pill has a\ncombined filter using OR or AND operations.\n\nThe filters schema from the package that dashboard uses in it's\nvalidation does not account for combined filters in the filter pills. I\nrecommend we fall back to softening the validation while we work on\nthese schemas for the public API.","sha":"393580e7777d3e7fdaef58eb64ae3bff21513069","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","Team:DataDiscovery","backport:version","v9.2.0","v9.3.0"],"title":"[Dashboards] Soften validation on filter schema","number":237477,"url":"https://github.com/elastic/kibana/pull/237477","mergeCommit":{"message":"[Dashboards] Soften validation on filter schema (#237477)\n\nFixes https://github.com/elastic/kibana/issues/237472\n\nFixes a bug where dashboards can not be saved when a filter pill has a\ncombined filter using OR or AND operations.\n\nThe filters schema from the package that dashboard uses in it's\nvalidation does not account for combined filters in the filter pills. I\nrecommend we fall back to softening the validation while we work on\nthese schemas for the public API.","sha":"393580e7777d3e7fdaef58eb64ae3bff21513069"}},"sourceBranch":"main","suggestedTargetBranches":["9.2"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/237477","number":237477,"mergeCommit":{"message":"[Dashboards] Soften validation on filter schema (#237477)\n\nFixes https://github.com/elastic/kibana/issues/237472\n\nFixes a bug where dashboards can not be saved when a filter pill has a\ncombined filter using OR or AND operations.\n\nThe filters schema from the package that dashboard uses in it's\nvalidation does not account for combined filters in the filter pills. I\nrecommend we fall back to softening the validation while we work on\nthese schemas for the public API.","sha":"393580e7777d3e7fdaef58eb64ae3bff21513069"}}]}] BACKPORT--> Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
Fixes elastic#237472 Fixes a bug where dashboards can not be saved when a filter pill has a combined filter using OR or AND operations. The filters schema from the package that dashboard uses in it's validation does not account for combined filters in the filter pills. I recommend we fall back to softening the validation while we work on these schemas for the public API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #237472
Fixes a bug where dashboards can not be saved when a filter pill has a combined filter using OR or AND operations.
The filters schema from the package that dashboard uses in it's validation does not account for combined filters in the filter pills. I recommend we fall back to softening the validation while we work on these schemas for the public API.