Fix files management flyout crashing#237588
Merged
kowalczyk-krzysztof merged 4 commits intoelastic:mainfrom Oct 7, 2025
Merged
Fix files management flyout crashing#237588kowalczyk-krzysztof merged 4 commits intoelastic:mainfrom
kowalczyk-krzysztof merged 4 commits intoelastic:mainfrom
Conversation
kowalczyk-krzysztof
added
release_note:fix
Team:SharedUX
Contributor
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
Dosant
approved these changes
Oct 6, 2025
Contributor
Dosant
left a comment
Dosant
left a comment
There was a problem hiding this comment.
Ideally, I would include a small ftr test to check that the flyout loads and that a chart is displayed. we already should have files management suite, so shouldn't be a big lift to add this test
kowalczyk-krzysztof
force-pushed
the
fix/fix-diagnostic-flyout-crashing
branch
from
aaeec16 to
9ee3213
Compare
kapral18
approved these changes
Oct 6, 2025
Contributor
|
Starting backport for target branches: 8.18, 8.19, 9.0, 9.1, 9.2 |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 7, 2025
## Summary This PR fixes flyout on files management page (click `Statistics` on `/app/management/kibana/filesManagement`) crashing. It has been crashing since 9.1. I'm not exactly sure what the actual reason for crashing is. This fix changes the `xScaleType` from `Time` to `Ordinal`. The value displayed on x axis is `key`, which in this context is file extension, so it doesn't make a sense to use `Time` here. Closes: elastic#235534 (cherry picked from commit 72c5997)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 7, 2025
## Summary This PR fixes flyout on files management page (click `Statistics` on `/app/management/kibana/filesManagement`) crashing. It has been crashing since 9.1. I'm not exactly sure what the actual reason for crashing is. This fix changes the `xScaleType` from `Time` to `Ordinal`. The value displayed on x axis is `key`, which in this context is file extension, so it doesn't make a sense to use `Time` here. Closes: elastic#235534 (cherry picked from commit 72c5997)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 7, 2025
## Summary This PR fixes flyout on files management page (click `Statistics` on `/app/management/kibana/filesManagement`) crashing. It has been crashing since 9.1. I'm not exactly sure what the actual reason for crashing is. This fix changes the `xScaleType` from `Time` to `Ordinal`. The value displayed on x axis is `key`, which in this context is file extension, so it doesn't make a sense to use `Time` here. Closes: elastic#235534 (cherry picked from commit 72c5997)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 7, 2025
## Summary This PR fixes flyout on files management page (click `Statistics` on `/app/management/kibana/filesManagement`) crashing. It has been crashing since 9.1. I'm not exactly sure what the actual reason for crashing is. This fix changes the `xScaleType` from `Time` to `Ordinal`. The value displayed on x axis is `key`, which in this context is file extension, so it doesn't make a sense to use `Time` here. Closes: elastic#235534 (cherry picked from commit 72c5997)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 7, 2025
## Summary This PR fixes flyout on files management page (click `Statistics` on `/app/management/kibana/filesManagement`) crashing. It has been crashing since 9.1. I'm not exactly sure what the actual reason for crashing is. This fix changes the `xScaleType` from `Time` to `Ordinal`. The value displayed on x axis is `key`, which in this context is file extension, so it doesn't make a sense to use `Time` here. Closes: elastic#235534 (cherry picked from commit 72c5997)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 7, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [Fix files management flyout crashing (#237588)](#237588) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Krzysztof Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2025-10-07T09:58:21Z","message":"Fix files management flyout crashing (#237588)\n\n## Summary\n\nThis PR fixes flyout on files management page (click `Statistics` on\n`/app/management/kibana/filesManagement`) crashing. It has been crashing\nsince 9.1. I'm not exactly sure what the actual reason for crashing is.\nThis fix changes the `xScaleType` from `Time` to `Ordinal`. The value\ndisplayed on x axis is `key`, which in this context is file extension,\nso it doesn't make a sense to use `Time` here.\n\nCloses: https://github.com/elastic/kibana/issues/235534","sha":"72c59976bb5fe8236e6070c68d1aa279d2de839a","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:SharedUX","backport:all-open","v9.3.0"],"title":"Fix files management flyout crashing","number":237588,"url":"https://github.com/elastic/kibana/pull/237588","mergeCommit":{"message":"Fix files management flyout crashing (#237588)\n\n## Summary\n\nThis PR fixes flyout on files management page (click `Statistics` on\n`/app/management/kibana/filesManagement`) crashing. It has been crashing\nsince 9.1. I'm not exactly sure what the actual reason for crashing is.\nThis fix changes the `xScaleType` from `Time` to `Ordinal`. The value\ndisplayed on x axis is `key`, which in this context is file extension,\nso it doesn't make a sense to use `Time` here.\n\nCloses: https://github.com/elastic/kibana/issues/235534","sha":"72c59976bb5fe8236e6070c68d1aa279d2de839a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/237588","number":237588,"mergeCommit":{"message":"Fix files management flyout crashing (#237588)\n\n## Summary\n\nThis PR fixes flyout on files management page (click `Statistics` on\n`/app/management/kibana/filesManagement`) crashing. It has been crashing\nsince 9.1. I'm not exactly sure what the actual reason for crashing is.\nThis fix changes the `xScaleType` from `Time` to `Ordinal`. The value\ndisplayed on x axis is `key`, which in this context is file extension,\nso it doesn't make a sense to use `Time` here.\n\nCloses: https://github.com/elastic/kibana/issues/235534","sha":"72c59976bb5fe8236e6070c68d1aa279d2de839a"}}]}] BACKPORT--> Co-authored-by: Krzysztof Kowalczyk <krzysztof.kowalczyk@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 7, 2025
# Backport This will backport the following commits from `main` to `9.1`: - [Fix files management flyout crashing (#237588)](#237588) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Krzysztof Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2025-10-07T09:58:21Z","message":"Fix files management flyout crashing (#237588)\n\n## Summary\n\nThis PR fixes flyout on files management page (click `Statistics` on\n`/app/management/kibana/filesManagement`) crashing. It has been crashing\nsince 9.1. I'm not exactly sure what the actual reason for crashing is.\nThis fix changes the `xScaleType` from `Time` to `Ordinal`. The value\ndisplayed on x axis is `key`, which in this context is file extension,\nso it doesn't make a sense to use `Time` here.\n\nCloses: https://github.com/elastic/kibana/issues/235534","sha":"72c59976bb5fe8236e6070c68d1aa279d2de839a","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:SharedUX","backport:all-open","v9.3.0"],"title":"Fix files management flyout crashing","number":237588,"url":"https://github.com/elastic/kibana/pull/237588","mergeCommit":{"message":"Fix files management flyout crashing (#237588)\n\n## Summary\n\nThis PR fixes flyout on files management page (click `Statistics` on\n`/app/management/kibana/filesManagement`) crashing. It has been crashing\nsince 9.1. I'm not exactly sure what the actual reason for crashing is.\nThis fix changes the `xScaleType` from `Time` to `Ordinal`. The value\ndisplayed on x axis is `key`, which in this context is file extension,\nso it doesn't make a sense to use `Time` here.\n\nCloses: https://github.com/elastic/kibana/issues/235534","sha":"72c59976bb5fe8236e6070c68d1aa279d2de839a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/237588","number":237588,"mergeCommit":{"message":"Fix files management flyout crashing (#237588)\n\n## Summary\n\nThis PR fixes flyout on files management page (click `Statistics` on\n`/app/management/kibana/filesManagement`) crashing. It has been crashing\nsince 9.1. I'm not exactly sure what the actual reason for crashing is.\nThis fix changes the `xScaleType` from `Time` to `Ordinal`. The value\ndisplayed on x axis is `key`, which in this context is file extension,\nso it doesn't make a sense to use `Time` here.\n\nCloses: https://github.com/elastic/kibana/issues/235534","sha":"72c59976bb5fe8236e6070c68d1aa279d2de839a"}}]}] BACKPORT--> Co-authored-by: Krzysztof Kowalczyk <krzysztof.kowalczyk@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 7, 2025
# Backport This will backport the following commits from `main` to `9.2`: - [Fix files management flyout crashing (#237588)](#237588) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Krzysztof Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2025-10-07T09:58:21Z","message":"Fix files management flyout crashing (#237588)\n\n## Summary\n\nThis PR fixes flyout on files management page (click `Statistics` on\n`/app/management/kibana/filesManagement`) crashing. It has been crashing\nsince 9.1. I'm not exactly sure what the actual reason for crashing is.\nThis fix changes the `xScaleType` from `Time` to `Ordinal`. The value\ndisplayed on x axis is `key`, which in this context is file extension,\nso it doesn't make a sense to use `Time` here.\n\nCloses: https://github.com/elastic/kibana/issues/235534","sha":"72c59976bb5fe8236e6070c68d1aa279d2de839a","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:SharedUX","backport:all-open","v9.3.0"],"title":"Fix files management flyout crashing","number":237588,"url":"https://github.com/elastic/kibana/pull/237588","mergeCommit":{"message":"Fix files management flyout crashing (#237588)\n\n## Summary\n\nThis PR fixes flyout on files management page (click `Statistics` on\n`/app/management/kibana/filesManagement`) crashing. It has been crashing\nsince 9.1. I'm not exactly sure what the actual reason for crashing is.\nThis fix changes the `xScaleType` from `Time` to `Ordinal`. The value\ndisplayed on x axis is `key`, which in this context is file extension,\nso it doesn't make a sense to use `Time` here.\n\nCloses: https://github.com/elastic/kibana/issues/235534","sha":"72c59976bb5fe8236e6070c68d1aa279d2de839a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/237588","number":237588,"mergeCommit":{"message":"Fix files management flyout crashing (#237588)\n\n## Summary\n\nThis PR fixes flyout on files management page (click `Statistics` on\n`/app/management/kibana/filesManagement`) crashing. It has been crashing\nsince 9.1. I'm not exactly sure what the actual reason for crashing is.\nThis fix changes the `xScaleType` from `Time` to `Ordinal`. The value\ndisplayed on x axis is `key`, which in this context is file extension,\nso it doesn't make a sense to use `Time` here.\n\nCloses: https://github.com/elastic/kibana/issues/235534","sha":"72c59976bb5fe8236e6070c68d1aa279d2de839a"}}]}] BACKPORT--> Co-authored-by: Krzysztof Kowalczyk <krzysztof.kowalczyk@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 7, 2025
# Backport This will backport the following commits from `main` to `8.18`: - [Fix files management flyout crashing (#237588)](#237588) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Krzysztof Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2025-10-07T09:58:21Z","message":"Fix files management flyout crashing (#237588)\n\n## Summary\n\nThis PR fixes flyout on files management page (click `Statistics` on\n`/app/management/kibana/filesManagement`) crashing. It has been crashing\nsince 9.1. I'm not exactly sure what the actual reason for crashing is.\nThis fix changes the `xScaleType` from `Time` to `Ordinal`. The value\ndisplayed on x axis is `key`, which in this context is file extension,\nso it doesn't make a sense to use `Time` here.\n\nCloses: https://github.com/elastic/kibana/issues/235534","sha":"72c59976bb5fe8236e6070c68d1aa279d2de839a","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:SharedUX","backport:all-open","v9.3.0"],"title":"Fix files management flyout crashing","number":237588,"url":"https://github.com/elastic/kibana/pull/237588","mergeCommit":{"message":"Fix files management flyout crashing (#237588)\n\n## Summary\n\nThis PR fixes flyout on files management page (click `Statistics` on\n`/app/management/kibana/filesManagement`) crashing. It has been crashing\nsince 9.1. I'm not exactly sure what the actual reason for crashing is.\nThis fix changes the `xScaleType` from `Time` to `Ordinal`. The value\ndisplayed on x axis is `key`, which in this context is file extension,\nso it doesn't make a sense to use `Time` here.\n\nCloses: https://github.com/elastic/kibana/issues/235534","sha":"72c59976bb5fe8236e6070c68d1aa279d2de839a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/237588","number":237588,"mergeCommit":{"message":"Fix files management flyout crashing (#237588)\n\n## Summary\n\nThis PR fixes flyout on files management page (click `Statistics` on\n`/app/management/kibana/filesManagement`) crashing. It has been crashing\nsince 9.1. I'm not exactly sure what the actual reason for crashing is.\nThis fix changes the `xScaleType` from `Time` to `Ordinal`. The value\ndisplayed on x axis is `key`, which in this context is file extension,\nso it doesn't make a sense to use `Time` here.\n\nCloses: https://github.com/elastic/kibana/issues/235534","sha":"72c59976bb5fe8236e6070c68d1aa279d2de839a"}}]}] BACKPORT--> Co-authored-by: Krzysztof Kowalczyk <krzysztof.kowalczyk@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 7, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [Fix files management flyout crashing (#237588)](#237588) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Krzysztof Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2025-10-07T09:58:21Z","message":"Fix files management flyout crashing (#237588)\n\n## Summary\n\nThis PR fixes flyout on files management page (click `Statistics` on\n`/app/management/kibana/filesManagement`) crashing. It has been crashing\nsince 9.1. I'm not exactly sure what the actual reason for crashing is.\nThis fix changes the `xScaleType` from `Time` to `Ordinal`. The value\ndisplayed on x axis is `key`, which in this context is file extension,\nso it doesn't make a sense to use `Time` here.\n\nCloses: https://github.com/elastic/kibana/issues/235534","sha":"72c59976bb5fe8236e6070c68d1aa279d2de839a","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:SharedUX","backport:all-open","v9.3.0"],"title":"Fix files management flyout crashing","number":237588,"url":"https://github.com/elastic/kibana/pull/237588","mergeCommit":{"message":"Fix files management flyout crashing (#237588)\n\n## Summary\n\nThis PR fixes flyout on files management page (click `Statistics` on\n`/app/management/kibana/filesManagement`) crashing. It has been crashing\nsince 9.1. I'm not exactly sure what the actual reason for crashing is.\nThis fix changes the `xScaleType` from `Time` to `Ordinal`. The value\ndisplayed on x axis is `key`, which in this context is file extension,\nso it doesn't make a sense to use `Time` here.\n\nCloses: https://github.com/elastic/kibana/issues/235534","sha":"72c59976bb5fe8236e6070c68d1aa279d2de839a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/237588","number":237588,"mergeCommit":{"message":"Fix files management flyout crashing (#237588)\n\n## Summary\n\nThis PR fixes flyout on files management page (click `Statistics` on\n`/app/management/kibana/filesManagement`) crashing. It has been crashing\nsince 9.1. I'm not exactly sure what the actual reason for crashing is.\nThis fix changes the `xScaleType` from `Time` to `Ordinal`. The value\ndisplayed on x axis is `key`, which in this context is file extension,\nso it doesn't make a sense to use `Time` here.\n\nCloses: https://github.com/elastic/kibana/issues/235534","sha":"72c59976bb5fe8236e6070c68d1aa279d2de839a"}}]}] BACKPORT--> Co-authored-by: Krzysztof Kowalczyk <krzysztof.kowalczyk@elastic.co>
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
## Summary This PR fixes flyout on files management page (click `Statistics` on `/app/management/kibana/filesManagement`) crashing. It has been crashing since 9.1. I'm not exactly sure what the actual reason for crashing is. This fix changes the `xScaleType` from `Time` to `Ordinal`. The value displayed on x axis is `key`, which in this context is file extension, so it doesn't make a sense to use `Time` here. Closes: elastic#235534
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes flyout on files management page crashing when there are any uploaded files (to open the flyout, click
Statisticson/app/management/kibana/filesManagement).It has been crashing since 9.1 release. I'm not exactly sure what the actual reason for the crashing is. This fix changes the
xScaleTypefromTimetoOrdinal. The value displayed on x axis iskey, which in this context is the file extension, so it doesn't make a sense to useTimehere.Closes: #235534