Add deployment name to breadcrumbs in ECH by kowalczyk-krzysztof · Pull Request #238078 · elastic/kibana

kowalczyk-krzysztof · 2025-10-08T15:14:23Z

Summary

This PR adds deployment name to breadcrumbs for solution views on ECH.

Testing locally

Add the following mocked cloud config to your kibana.dev.yml

xpack.cloud.id: "ftr_fake_cloud_id:aGVsbG8uY29tOjQ0MyRFUzEyM2FiYyRrYm4xMjNhYmM="
xpack.cloud.deployment_url: "https://cloud.elastic.co/deployments/your-deployment-id"
xpack.cloud.deployments_url: "https://cloud.elastic.co/deployments"
xpack.cloud.base_url: "https://cloud.elastic.co"

Launch Kibana and edit the default space to anything but classic or create a new solution space and switch to it
Go to onboarding URL: http://localhost:5601/app/cloud/onboarding?onboarding_token=test&resource_data={"deployment":{"name":"My Test Deployment","id":"test-123"}}&next=/
If prompted to login, do so

To set different deployment name replace My Test Deployment in the onboarding URL with the name you want.

kowalczyk-krzysztof · 2025-10-08T15:48:58Z

/ci

kowalczyk-krzysztof · 2025-10-08T16:06:58Z

/ci

kowalczyk-krzysztof · 2025-10-08T17:58:52Z

/ci

kibanamachine · 2025-10-21T21:08:34Z

Cloud deployment initiated, see credentials at: https://buildkite.com/elastic/kibana-deploy-cloud-from-pr/builds/497

elasticmachine · 2025-10-22T07:39:39Z

Pinging @elastic/appex-sharedux (Team:SharedUX)

Dosant

nice work, I'd like to consider some suggestions to attempt to unify serverless and deployment

src/core/packages/chrome/browser-internal/src/project_navigation/project_navigation_service.ts

src/core/packages/chrome/browser-internal/src/project_navigation/breadcrumbs.tsx

src/core/packages/chrome/browser-internal/src/project_navigation/project_navigation_service.ts

Dosant

looks good, imo, this version is cleaner!

I still think it would be nice to have a service that caches and dedupes /internal/cloud/solution requests.

if not in this PR, let's create an issue and follow up if you feel like it? Otherwise, that's fine

x-pack/platform/plugins/shared/cloud/public/plugin.tsx

kowalczyk-krzysztof · 2025-10-22T15:00:11Z

looks good, imo, this version is cleaner!

I still think it would be nice to have a service that caches and dedupes /internal/cloud/solution requests.

if not in this PR, let's create an issue and follow up if you feel like it? Otherwise, that's fine

I'll create a follow up issue.

kowalczyk-krzysztof · 2025-10-22T15:04:23Z

Added follow-up issue: #240117

…no-cache --fix'

gsoldevila · 2025-10-23T11:00:44Z

x-pack/platform/plugins/shared/cloud/public/plugin.tsx

+        .then((response) => {
+          const deploymentName = response?.resourceData?.deployment?.name;
+          if (deploymentName) {
+            (coreStart.chrome as InternalChromeStart)?.project?.setKibanaName(deploymentName);


This seems a bit hacky to me.

We need to access an internal property to set a name.

That setter is under a "project" property, but here we're specifically talking about ECH and !Serverless, thus deployments. I'm guessing this was used on Serverless only and your PR sets it on ECH too.

If the chrome plugin does not know how to set a name yet it owns the logic to set it... the setter should be available in its public API IMO. And if project property holds functionality for both ECH and Serverless perhaps we should generalise it into something that covers both. I wonder if any of these setters make sense for self-managed customers.

the idea for InternalChromeStart was that we had to expose apis for plugins like serverless, but we didn't want anyone else to know about them :D I am also fine to move this to public type, but we really don't want other plugins to call this ever

That setter is under a "project" property, but here we're specifically talking about ECH and !Serverless, thus deployments. I'm guessing this was used on Serverless only and your PR sets it on ECH too.

This part got messed up when we added solution view to ech/hosted.
What is "project" navigation in chrome initially was build for "serverless" but now it is "serverless" + "solution view of hosted/ech" .

In theory, we could refactor this from Project to SolutionView or something like that.

In this PR we need to set breadcrumb for "solution view of ech" . We do it from cloud plugin, but cloud plugin is also run in serveless, so we don't want to override what serverless plugin has set :(
Ideally, we would have a ech plugin that runs only for ECH and another that runs only in serverless. But we don't.

Thanks for the clarifications!
I'm fine with renaming project to solutionView in a follow-up PR.

Created follow-up issue: #240747

gsoldevila · 2025-10-23T11:03:35Z

src/core/packages/chrome/browser-internal/src/chrome_service.tsx

    };

-    const setProjectName = (projectName: string) => {
-      validateChromeStyle();


Seems related to my other comment.
Does this mean that everybody can now set the text of the first breadcrumb?
Not saying it's necessarily a bad thing, goes in the lines of exposing the setter publicly in Chrome's API.

gsoldevila

Core changes LGTM (code review only)

elasticmachine · 2025-10-27T08:09:04Z

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`cloud`	8.7KB	9.1KB	+335.0B
`core`	511.4KB	511.6KB	+207.0B
`serverless`	7.0KB	7.0KB	-1.0B
total			+541.0B

History

💚 Build #353988 succeeded d4ca914
💚 Build #353830 succeeded 3d88034
💔 Build #353777 failed 4489d47
💔 Build #353708 failed 15b0636
💔 Build #353686 failed ee84cb8

cc @kowalczyk-krzysztof

Add deployment name to breadcrumbs in ECH

98b52c9

kowalczyk-krzysztof self-assigned this Oct 8, 2025

kowalczyk-krzysztof added release_note:enhancement backport:skip This PR does not require backporting Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// labels Oct 8, 2025

[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'

2b866b4

Remove import type to avoid circular dependency error

14ecdf5

Fix TypeError

fddca5d

kowalczyk-krzysztof added 3 commits October 19, 2025 16:57

Merge branch 'main' into feat/add-deployment-name-to-breadcrumbs

355cc81

Simplify and add tests

5b78863

Cleanup

01cffa7

kowalczyk-krzysztof added the ci:cloud-deploy Create or update a Cloud deployment label Oct 21, 2025

Merge branch 'main' into feat/add-deployment-name-to-breadcrumbs

0ef47f2

kowalczyk-krzysztof added 2 commits October 21, 2025 23:15

Fix test

d0a6c44

Merge branch 'main' into feat/add-deployment-name-to-breadcrumbs

ad379b5

kowalczyk-krzysztof marked this pull request as ready for review October 22, 2025 07:39

kowalczyk-krzysztof requested a review from a team as a code owner October 22, 2025 07:39

Dosant self-requested a review October 22, 2025 08:55

Dosant reviewed Oct 22, 2025

View reviewed changes

Set deployment name from cloud plugin

71c16eb

kowalczyk-krzysztof requested a review from a team as a code owner October 22, 2025 14:45

Dosant reviewed Oct 22, 2025

View reviewed changes

x-pack/platform/plugins/shared/cloud/public/plugin.tsx Outdated Show resolved Hide resolved

x-pack/platform/plugins/shared/cloud/public/plugin.tsx Outdated Show resolved Hide resolved

kibanamachine and others added 2 commits October 22, 2025 14:54

[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'

56a5e8e

Add serverless check

c12c12f

kowalczyk-krzysztof mentioned this pull request Oct 22, 2025

[Cloud Plugin] Create a service to handle /internal/cloud/solution requests #240117

Open

kowalczyk-krzysztof and others added 3 commits October 22, 2025 17:10

Remove unused tests

ee84cb8

[CI] Auto-commit changed files from 'node scripts/eslint_all_files --…

e5a23f6

…no-cache --fix'

Increase cloud plugin limit

15b0636

kowalczyk-krzysztof requested a review from a team as a code owner October 22, 2025 15:38

Dosant approved these changes Oct 22, 2025

View reviewed changes

jbudz approved these changes Oct 22, 2025

View reviewed changes

kowalczyk-krzysztof added 4 commits October 22, 2025 20:02

Fix tests

6ecf3cc

Merge branch 'main' into feat/add-deployment-name-to-breadcrumbs

4489d47

Merge branch 'main' into feat/add-deployment-name-to-breadcrumbs

3d88034

Merge branch 'main' into feat/add-deployment-name-to-breadcrumbs

d4ca914

gsoldevila reviewed Oct 23, 2025

View reviewed changes

Dosant requested a review from gsoldevila October 23, 2025 11:32

gsoldevila approved these changes Oct 24, 2025

View reviewed changes

kowalczyk-krzysztof enabled auto-merge (squash) October 27, 2025 07:04

Merge branch 'main' into feat/add-deployment-name-to-breadcrumbs

c41b353

kowalczyk-krzysztof mentioned this pull request Oct 27, 2025

Rename chrome.project to chrome.solutionView #240747

Closed

kowalczyk-krzysztof merged commit 2cff90f into elastic:main Oct 27, 2025
14 checks passed

kibanamachine added the v9.3.0 label Oct 27, 2025

kowalczyk-krzysztof deleted the feat/add-deployment-name-to-breadcrumbs branch October 27, 2025 20:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add deployment name to breadcrumbs in ECH#238078

Add deployment name to breadcrumbs in ECH#238078
kowalczyk-krzysztof merged 21 commits intoelastic:mainfrom
kowalczyk-krzysztof:feat/add-deployment-name-to-breadcrumbs

kowalczyk-krzysztof commented Oct 8, 2025 •

edited

Loading

kowalczyk-krzysztof commented Oct 8, 2025

kowalczyk-krzysztof commented Oct 8, 2025

kowalczyk-krzysztof commented Oct 8, 2025

kibanamachine commented Oct 21, 2025

elasticmachine commented Oct 22, 2025

Dosant left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dosant left a comment

Uh oh!

Uh oh!

kowalczyk-krzysztof commented Oct 22, 2025

kowalczyk-krzysztof commented Oct 22, 2025

gsoldevila Oct 23, 2025

Dosant Oct 23, 2025 •

edited

Loading

gsoldevila Oct 24, 2025

kowalczyk-krzysztof Oct 27, 2025 •

edited

Loading

gsoldevila Oct 23, 2025 •

edited

Loading

gsoldevila left a comment

elasticmachine commented Oct 27, 2025 •

edited

Loading

Uh oh!

Labels

7 participants

Conversation

kowalczyk-krzysztof commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing locally

kowalczyk-krzysztof commented Oct 8, 2025

kowalczyk-krzysztof commented Oct 8, 2025

kowalczyk-krzysztof commented Oct 8, 2025

kibanamachine commented Oct 21, 2025

elasticmachine commented Oct 22, 2025

Dosant left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dosant left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kowalczyk-krzysztof commented Oct 22, 2025

kowalczyk-krzysztof commented Oct 22, 2025

gsoldevila Oct 23, 2025

Choose a reason for hiding this comment

Dosant Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

gsoldevila Oct 24, 2025

Choose a reason for hiding this comment

kowalczyk-krzysztof Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

gsoldevila Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

gsoldevila left a comment

Choose a reason for hiding this comment

elasticmachine commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Metrics [docs]

Page load bundle

History

Uh oh!

Labels

7 participants

kowalczyk-krzysztof commented Oct 8, 2025 •

edited

Loading

Dosant Oct 23, 2025 •

edited

Loading

kowalczyk-krzysztof Oct 27, 2025 •

edited

Loading

gsoldevila Oct 23, 2025 •

edited

Loading

elasticmachine commented Oct 27, 2025 •

edited

Loading