[Visualize] Improve list error handling#238355
Merged
markov00 merged 2 commits intoelastic:mainfrom Oct 13, 2025
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
|
markov00
approved these changes
Oct 13, 2025
Contributor
markov00
left a comment
There was a problem hiding this comment.
Tested this by disabling vis_type_vega.enabled: false in the kibana.dev.yml and worked perfectly
Contributor
|
Starting backport for target branches: 8.18, 8.19, 9.0, 9.1, 9.2 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 13, 2025
Fixes an error in the **Visualize Listing** page in which an error in the vis could cause the entire page to error. This improves the error handling to make it easier to identity which visualization is causing the problem in order to address it. (cherry picked from commit 8a591b5)
This comment was marked as outdated.
This comment was marked as outdated.
baileycash-elastic
pushed a commit
to baileycash-elastic/kibana
that referenced
this pull request
Oct 14, 2025
Fixes an error in the **Visualize Listing** page in which an error in the vis could cause the entire page to error. This improves the error handling to make it easier to identity which visualization is causing the problem in order to address it.
kibanamachine
added a commit
that referenced
this pull request
Oct 15, 2025
# Backport This will backport the following commits from `main` to `9.2`: - [[Visualize] Improve list error handling (#238355)](#238355) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nick Partridge","email":"nicholas.partridge@elastic.co"},"sourceCommit":{"committedDate":"2025-10-13T16:55:35Z","message":"[Visualize] Improve list error handling (#238355)\n\nFixes an error in the **Visualize Listing** page in which an error in\nthe vis could cause the entire page to error. This improves the error\nhandling to make it easier to identity which visualization is causing\nthe problem in order to address it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Visualizations","release_note:fix","Team:Visualizations","backport:all-open","v9.3.0"],"title":"[Visualize] Improve list error handling","number":238355,"url":"https://github.com/elastic/kibana/pull/238355","mergeCommit":{"message":"[Visualize] Improve list error handling (#238355)\n\nFixes an error in the **Visualize Listing** page in which an error in\nthe vis could cause the entire page to error. This improves the error\nhandling to make it easier to identity which visualization is causing\nthe problem in order to address it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238355","number":238355,"mergeCommit":{"message":"[Visualize] Improve list error handling (#238355)\n\nFixes an error in the **Visualize Listing** page in which an error in\nthe vis could cause the entire page to error. This improves the error\nhandling to make it easier to identity which visualization is causing\nthe problem in order to address it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4"}}]}] BACKPORT--> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co> Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
nickofthyme
added a commit
to nickofthyme/kibana
that referenced
this pull request
Oct 15, 2025
Fixes an error in the **Visualize Listing** page in which an error in the vis could cause the entire page to error. This improves the error handling to make it easier to identity which visualization is causing the problem in order to address it.
This was referenced Oct 15, 2025
nickofthyme
added a commit
to nickofthyme/kibana
that referenced
this pull request
Oct 15, 2025
Fixes an error in the **Visualize Listing** page in which an error in the vis could cause the entire page to error. This improves the error handling to make it easier to identity which visualization is causing the problem in order to address it. (cherry picked from commit 8a591b5) # Conflicts: # src/platform/plugins/shared/visualizations/public/visualize_app/components/visualize_listing.tsx # src/platform/plugins/shared/visualizations/public/visualize_app/utils/get_visualize_list_item_link.test.ts
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
nickofthyme
added a commit
to nickofthyme/kibana
that referenced
this pull request
Oct 15, 2025
Fixes an error in the **Visualize Listing** page in which an error in the vis could cause the entire page to error. This improves the error handling to make it easier to identity which visualization is causing the problem in order to address it. (cherry picked from commit 8a591b5) # Conflicts: # src/platform/plugins/shared/visualizations/public/visualize_app/components/visualize_listing.tsx # src/platform/plugins/shared/visualizations/public/visualize_app/utils/get_visualize_list_item_link.test.ts
nickofthyme
added a commit
that referenced
this pull request
Oct 15, 2025
# Backport This will backport the following commits from `main` to `9.1`: - [[Visualize] Improve list error handling (#238355)](#238355) <!--- Backport version: 10.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nick Partridge","email":"nicholas.partridge@elastic.co"},"sourceCommit":{"committedDate":"2025-10-13T16:55:35Z","message":"[Visualize] Improve list error handling (#238355)\n\nFixes an error in the **Visualize Listing** page in which an error in\nthe vis could cause the entire page to error. This improves the error\nhandling to make it easier to identity which visualization is causing\nthe problem in order to address it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Visualizations","release_note:fix","Team:Visualizations","backport missing","backport:all-open","v9.3.0"],"title":"[Visualize] Improve list error handling","number":238355,"url":"https://github.com/elastic/kibana/pull/238355","mergeCommit":{"message":"[Visualize] Improve list error handling (#238355)\n\nFixes an error in the **Visualize Listing** page in which an error in\nthe vis could cause the entire page to error. This improves the error\nhandling to make it easier to identity which visualization is causing\nthe problem in order to address it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238355","number":238355,"mergeCommit":{"message":"[Visualize] Improve list error handling (#238355)\n\nFixes an error in the **Visualize Listing** page in which an error in\nthe vis could cause the entire page to error. This improves the error\nhandling to make it easier to identity which visualization is causing\nthe problem in order to address it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4"}},{"url":"https://github.com/elastic/kibana/pull/238708","number":238708,"branch":"9.2","state":"OPEN"}]}] BACKPORT-->
nickofthyme
added a commit
that referenced
this pull request
Oct 15, 2025
# Backport This will backport the following commits from `main` to `8.18`: - [[Visualize] Improve list error handling (#238355)](#238355) <!--- Backport version: 10.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nick Partridge","email":"nicholas.partridge@elastic.co"},"sourceCommit":{"committedDate":"2025-10-13T16:55:35Z","message":"[Visualize] Improve list error handling (#238355)\n\nFixes an error in the **Visualize Listing** page in which an error in\nthe vis could cause the entire page to error. This improves the error\nhandling to make it easier to identity which visualization is causing\nthe problem in order to address it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Visualizations","release_note:fix","Team:Visualizations","backport:all-open","v9.2.0","v9.3.0"],"title":"[Visualize] Improve list error handling","number":238355,"url":"https://github.com/elastic/kibana/pull/238355","mergeCommit":{"message":"[Visualize] Improve list error handling (#238355)\n\nFixes an error in the **Visualize Listing** page in which an error in\nthe vis could cause the entire page to error. This improves the error\nhandling to make it easier to identity which visualization is causing\nthe problem in order to address it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/238708","number":238708,"state":"MERGED","mergeCommit":{"sha":"d4232881d7081254e998e5dfdc7307e5d4129060","message":"[9.2] [Visualize] Improve list error handling (#238355) (#238708)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.2`:\n- [[Visualize] Improve list error handling\n(#238355)](https://github.com/elastic/kibana/pull/238355)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Nick Partridge <nicholas.partridge@elastic.co>\nCo-authored-by: Marco Vettorello <marco.vettorello@elastic.co>"}},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238355","number":238355,"mergeCommit":{"message":"[Visualize] Improve list error handling (#238355)\n\nFixes an error in the **Visualize Listing** page in which an error in\nthe vis could cause the entire page to error. This improves the error\nhandling to make it easier to identity which visualization is causing\nthe problem in order to address it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4"}},{"url":"https://github.com/elastic/kibana/pull/239192","number":239192,"branch":"9.1","state":"OPEN"}]}] BACKPORT-->
nickofthyme
added a commit
that referenced
this pull request
Oct 15, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [[Visualize] Improve list error handling (#238355)](#238355) <!--- Backport version: 10.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nick Partridge","email":"nicholas.partridge@elastic.co"},"sourceCommit":{"committedDate":"2025-10-13T16:55:35Z","message":"[Visualize] Improve list error handling (#238355)\n\nFixes an error in the **Visualize Listing** page in which an error in\nthe vis could cause the entire page to error. This improves the error\nhandling to make it easier to identity which visualization is causing\nthe problem in order to address it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Visualizations","release_note:fix","Team:Visualizations","backport:all-open","v9.2.0","v9.3.0"],"title":"[Visualize] Improve list error handling","number":238355,"url":"https://github.com/elastic/kibana/pull/238355","mergeCommit":{"message":"[Visualize] Improve list error handling (#238355)\n\nFixes an error in the **Visualize Listing** page in which an error in\nthe vis could cause the entire page to error. This improves the error\nhandling to make it easier to identity which visualization is causing\nthe problem in order to address it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/238708","number":238708,"state":"MERGED","mergeCommit":{"sha":"d4232881d7081254e998e5dfdc7307e5d4129060","message":"[9.2] [Visualize] Improve list error handling (#238355) (#238708)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.2`:\n- [[Visualize] Improve list error handling\n(#238355)](https://github.com/elastic/kibana/pull/238355)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Nick Partridge <nicholas.partridge@elastic.co>\nCo-authored-by: Marco Vettorello <marco.vettorello@elastic.co>"}},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238355","number":238355,"mergeCommit":{"message":"[Visualize] Improve list error handling (#238355)\n\nFixes an error in the **Visualize Listing** page in which an error in\nthe vis could cause the entire page to error. This improves the error\nhandling to make it easier to identity which visualization is causing\nthe problem in order to address it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4"}},{"url":"https://github.com/elastic/kibana/pull/239192","number":239192,"branch":"9.1","state":"OPEN"}]}] BACKPORT--> Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
Fixes an error in the **Visualize Listing** page in which an error in the vis could cause the entire page to error. This improves the error handling to make it easier to identity which visualization is causing the problem in order to address it.
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Oct 23, 2025
Fixes an error in the **Visualize Listing** page in which an error in the vis could cause the entire page to error. This improves the error handling to make it easier to identity which visualization is causing the problem in order to address it.
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Oct 27, 2025
Fixes an error in the **Visualize Listing** page in which an error in the vis could cause the entire page to error. This improves the error handling to make it easier to identity which visualization is causing the problem in order to address it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the error handling of the Visualize Library page.
Before, if there was any error coming from the
mSearchitem.error, the entire page could error even it's only due to one visualization.Now if there is no vis
typeTitlesuch that the vis type is unknown, we showUnknownin the UI along with any errors if available.If there is a known vis type, but some
error, we displayErrorwith any errors.Additionally, if there are any errors we disable the clickable title which calls the
editItemfunction. This is consistent with the disabling of the edit Action icon.Fixes #238351
Checklist
release_note:*label is applied per the guidelinesbackport:*labels.Release Notes
Fixes an error in the Visualize Listing page in which an error in the vis could cause the entire page to error. This improves the error handling to make it easier to identity which visualization is causing the problem in order to address it.