Skip to content

[Visualize] Improve list error handling#238355

Merged
markov00 merged 2 commits intoelastic:mainfrom
nickofthyme:fix-vis-list-errors
Oct 13, 2025
Merged

[Visualize] Improve list error handling#238355
markov00 merged 2 commits intoelastic:mainfrom
nickofthyme:fix-vis-list-errors

Conversation

@nickofthyme
Copy link
Contributor

@nickofthyme nickofthyme commented Oct 9, 2025

Summary

Improves the error handling of the Visualize Library page.

Before, if there was any error coming from the mSearch item.error, the entire page could error even it's only due to one visualization.

Now if there is no vis typeTitle such that the vis type is unknown, we show Unknown in the UI along with any errors if available.

Zight 2025-10-09 at 4 35 41 PM

If there is a known vis type, but some error, we display Error with any errors.

Additionally, if there are any errors we disable the clickable title which calls the editItem function. This is consistent with the disabling of the edit Action icon.

Fixes #238351

Checklist

Release Notes

Fixes an error in the Visualize Listing page in which an error in the vis could cause the entire page to error. This improves the error handling to make it easier to identity which visualization is causing the problem in order to address it.

@nickofthyme nickofthyme requested a review from a team as a code owner October 9, 2025 21:59
@nickofthyme nickofthyme added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels Oct 9, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@nickofthyme nickofthyme added release_note:fix backport:all-open Backport to all branches that could still receive a release labels Oct 9, 2025
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visualizations 351.1KB 351.7KB +616.0B
Copy link
Contributor

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this by disabling vis_type_vega.enabled: false in the kibana.dev.yml and worked perfectly

@markov00 markov00 enabled auto-merge (squash) October 13, 2025 16:25
@markov00 markov00 merged commit 8a591b5 into elastic:main Oct 13, 2025
12 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.18, 8.19, 9.0, 9.1, 9.2

https://github.com/elastic/kibana/actions/runs/18472847587

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 13, 2025
Fixes an error in the **Visualize Listing** page in which an error in
the vis could cause the entire page to error. This improves the error
handling to make it easier to identity which visualization is causing
the problem in order to address it.

(cherry picked from commit 8a591b5)
@kibanamachine

This comment was marked as outdated.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 14, 2025
baileycash-elastic pushed a commit to baileycash-elastic/kibana that referenced this pull request Oct 14, 2025
Fixes an error in the **Visualize Listing** page in which an error in
the vis could cause the entire page to error. This improves the error
handling to make it easier to identity which visualization is causing
the problem in order to address it.
@nickofthyme nickofthyme deleted the fix-vis-list-errors branch October 15, 2025 13:53
kibanamachine added a commit that referenced this pull request Oct 15, 2025
# Backport

This will backport the following commits from `main` to `9.2`:
- [[Visualize] Improve list error handling
(#238355)](#238355)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Nick
Partridge","email":"nicholas.partridge@elastic.co"},"sourceCommit":{"committedDate":"2025-10-13T16:55:35Z","message":"[Visualize]
Improve list error handling (#238355)\n\nFixes an error in the
**Visualize Listing** page in which an error in\nthe vis could cause the
entire page to error. This improves the error\nhandling to make it
easier to identity which visualization is causing\nthe problem in order
to address
it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Visualizations","release_note:fix","Team:Visualizations","backport:all-open","v9.3.0"],"title":"[Visualize]
Improve list error
handling","number":238355,"url":"https://github.com/elastic/kibana/pull/238355","mergeCommit":{"message":"[Visualize]
Improve list error handling (#238355)\n\nFixes an error in the
**Visualize Listing** page in which an error in\nthe vis could cause the
entire page to error. This improves the error\nhandling to make it
easier to identity which visualization is causing\nthe problem in order
to address
it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238355","number":238355,"mergeCommit":{"message":"[Visualize]
Improve list error handling (#238355)\n\nFixes an error in the
**Visualize Listing** page in which an error in\nthe vis could cause the
entire page to error. This improves the error\nhandling to make it
easier to identity which visualization is causing\nthe problem in order
to address it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4"}}]}]
BACKPORT-->

Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
@kibanamachine kibanamachine added v9.2.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Oct 15, 2025
nickofthyme added a commit to nickofthyme/kibana that referenced this pull request Oct 15, 2025
Fixes an error in the **Visualize Listing** page in which an error in
the vis could cause the entire page to error. This improves the error
handling to make it easier to identity which visualization is causing
the problem in order to address it.
nickofthyme added a commit to nickofthyme/kibana that referenced this pull request Oct 15, 2025
Fixes an error in the **Visualize Listing** page in which an error in
the vis could cause the entire page to error. This improves the error
handling to make it easier to identity which visualization is causing
the problem in order to address it.

(cherry picked from commit 8a591b5)

# Conflicts:
#	src/platform/plugins/shared/visualizations/public/visualize_app/components/visualize_listing.tsx
#	src/platform/plugins/shared/visualizations/public/visualize_app/utils/get_visualize_list_item_link.test.ts
@nickofthyme
Copy link
Contributor Author

nickofthyme commented Oct 15, 2025

💚 All backports created successfully

Status Branch Result
9.2
9.1
9.0
8.19
8.18

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@elastic elastic deleted a comment from kibanamachine Oct 15, 2025
nickofthyme added a commit to nickofthyme/kibana that referenced this pull request Oct 15, 2025
Fixes an error in the **Visualize Listing** page in which an error in
the vis could cause the entire page to error. This improves the error
handling to make it easier to identity which visualization is causing
the problem in order to address it.

(cherry picked from commit 8a591b5)

# Conflicts:
#	src/platform/plugins/shared/visualizations/public/visualize_app/components/visualize_listing.tsx
#	src/platform/plugins/shared/visualizations/public/visualize_app/utils/get_visualize_list_item_link.test.ts
nickofthyme added a commit that referenced this pull request Oct 15, 2025
# Backport

This will backport the following commits from `main` to `9.1`:
- [[Visualize] Improve list error handling
(#238355)](#238355)

<!--- Backport version: 10.0.2 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Nick
Partridge","email":"nicholas.partridge@elastic.co"},"sourceCommit":{"committedDate":"2025-10-13T16:55:35Z","message":"[Visualize]
Improve list error handling (#238355)\n\nFixes an error in the
**Visualize Listing** page in which an error in\nthe vis could cause the
entire page to error. This improves the error\nhandling to make it
easier to identity which visualization is causing\nthe problem in order
to address
it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Visualizations","release_note:fix","Team:Visualizations","backport
missing","backport:all-open","v9.3.0"],"title":"[Visualize] Improve list
error
handling","number":238355,"url":"https://github.com/elastic/kibana/pull/238355","mergeCommit":{"message":"[Visualize]
Improve list error handling (#238355)\n\nFixes an error in the
**Visualize Listing** page in which an error in\nthe vis could cause the
entire page to error. This improves the error\nhandling to make it
easier to identity which visualization is causing\nthe problem in order
to address
it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238355","number":238355,"mergeCommit":{"message":"[Visualize]
Improve list error handling (#238355)\n\nFixes an error in the
**Visualize Listing** page in which an error in\nthe vis could cause the
entire page to error. This improves the error\nhandling to make it
easier to identity which visualization is causing\nthe problem in order
to address
it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4"}},{"url":"https://github.com/elastic/kibana/pull/238708","number":238708,"branch":"9.2","state":"OPEN"}]}]
BACKPORT-->
nickofthyme added a commit that referenced this pull request Oct 15, 2025
# Backport

This will backport the following commits from `main` to `8.18`:
- [[Visualize] Improve list error handling
(#238355)](#238355)

<!--- Backport version: 10.0.2 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Nick
Partridge","email":"nicholas.partridge@elastic.co"},"sourceCommit":{"committedDate":"2025-10-13T16:55:35Z","message":"[Visualize]
Improve list error handling (#238355)\n\nFixes an error in the
**Visualize Listing** page in which an error in\nthe vis could cause the
entire page to error. This improves the error\nhandling to make it
easier to identity which visualization is causing\nthe problem in order
to address
it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Visualizations","release_note:fix","Team:Visualizations","backport:all-open","v9.2.0","v9.3.0"],"title":"[Visualize]
Improve list error
handling","number":238355,"url":"https://github.com/elastic/kibana/pull/238355","mergeCommit":{"message":"[Visualize]
Improve list error handling (#238355)\n\nFixes an error in the
**Visualize Listing** page in which an error in\nthe vis could cause the
entire page to error. This improves the error\nhandling to make it
easier to identity which visualization is causing\nthe problem in order
to address
it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/238708","number":238708,"state":"MERGED","mergeCommit":{"sha":"d4232881d7081254e998e5dfdc7307e5d4129060","message":"[9.2]
[Visualize] Improve list error handling (#238355) (#238708)\n\n#
Backport\n\nThis will backport the following commits from `main` to
`9.2`:\n- [[Visualize] Improve list error
handling\n(#238355)](https://github.com/elastic/kibana/pull/238355)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Nick Partridge <nicholas.partridge@elastic.co>\nCo-authored-by: Marco
Vettorello
<marco.vettorello@elastic.co>"}},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238355","number":238355,"mergeCommit":{"message":"[Visualize]
Improve list error handling (#238355)\n\nFixes an error in the
**Visualize Listing** page in which an error in\nthe vis could cause the
entire page to error. This improves the error\nhandling to make it
easier to identity which visualization is causing\nthe problem in order
to address
it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4"}},{"url":"https://github.com/elastic/kibana/pull/239192","number":239192,"branch":"9.1","state":"OPEN"}]}]
BACKPORT-->
nickofthyme added a commit that referenced this pull request Oct 15, 2025
# Backport

This will backport the following commits from `main` to `8.19`:
- [[Visualize] Improve list error handling
(#238355)](#238355)

<!--- Backport version: 10.0.2 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Nick
Partridge","email":"nicholas.partridge@elastic.co"},"sourceCommit":{"committedDate":"2025-10-13T16:55:35Z","message":"[Visualize]
Improve list error handling (#238355)\n\nFixes an error in the
**Visualize Listing** page in which an error in\nthe vis could cause the
entire page to error. This improves the error\nhandling to make it
easier to identity which visualization is causing\nthe problem in order
to address
it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Visualizations","release_note:fix","Team:Visualizations","backport:all-open","v9.2.0","v9.3.0"],"title":"[Visualize]
Improve list error
handling","number":238355,"url":"https://github.com/elastic/kibana/pull/238355","mergeCommit":{"message":"[Visualize]
Improve list error handling (#238355)\n\nFixes an error in the
**Visualize Listing** page in which an error in\nthe vis could cause the
entire page to error. This improves the error\nhandling to make it
easier to identity which visualization is causing\nthe problem in order
to address
it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/238708","number":238708,"state":"MERGED","mergeCommit":{"sha":"d4232881d7081254e998e5dfdc7307e5d4129060","message":"[9.2]
[Visualize] Improve list error handling (#238355) (#238708)\n\n#
Backport\n\nThis will backport the following commits from `main` to
`9.2`:\n- [[Visualize] Improve list error
handling\n(#238355)](https://github.com/elastic/kibana/pull/238355)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Nick Partridge <nicholas.partridge@elastic.co>\nCo-authored-by: Marco
Vettorello
<marco.vettorello@elastic.co>"}},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238355","number":238355,"mergeCommit":{"message":"[Visualize]
Improve list error handling (#238355)\n\nFixes an error in the
**Visualize Listing** page in which an error in\nthe vis could cause the
entire page to error. This improves the error\nhandling to make it
easier to identity which visualization is causing\nthe problem in order
to address
it.","sha":"8a591b5d4e769c6f1449117777040c47669691e4"}},{"url":"https://github.com/elastic/kibana/pull/239192","number":239192,"branch":"9.1","state":"OPEN"}]}]
BACKPORT-->

Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
rylnd pushed a commit to rylnd/kibana that referenced this pull request Oct 17, 2025
Fixes an error in the **Visualize Listing** page in which an error in
the vis could cause the entire page to error. This improves the error
handling to make it easier to identity which visualization is causing
the problem in order to address it.
nickpeihl pushed a commit to nickpeihl/kibana that referenced this pull request Oct 23, 2025
Fixes an error in the **Visualize Listing** page in which an error in
the vis could cause the entire page to error. This improves the error
handling to make it easier to identity which visualization is causing
the problem in order to address it.
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Oct 27, 2025
Fixes an error in the **Visualize Listing** page in which an error in
the vis could cause the entire page to error. This improves the error
handling to make it easier to identity which visualization is causing
the problem in order to address it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:all-open Backport to all branches that could still receive a release Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.18.9 v8.19.6 v9.1.6 v9.2.0 v9.3.0

4 participants