[Cases] IBM Resilient form improvements by janmonschke · Pull Request #238869 · elastic/kibana

janmonschke · 2025-10-14T12:23:20Z

Summary

This PR provides an improved experience of editing IBM resilient fields.

Instead of editing IBM resilient fields with a JSON editor, this PR adds dynamic form elements for the IBM resilient fields.

Demo

Screen.Recording.2025-11-18.at.13.36.36.mov

Other changes

Removed useGetIncidentTypes and useGetSeverity since they can both be obtained via useGetFields. This also removes the API calls from 3 to just a single one.
The connector preview is now a proper table and all connector previews have been changed.

Testing

Add an IBM Resilient connector (hmu in Slack for credentials)
Create case, add additional fields to the connector, hit save
Observe that the fields and their values are shown in the case page
Edit the additional fields to your liking (adding, removing, editing) and make sure the changes are saved when pushing to IBM Resilient

PhilippeOberti

Code review only (only Cypress files modified). LGTM for the @elastic/security-threat-hunting-investigations team!

christineweng

Desk tested and LGTM, left some nit comments.

The json editor is also used in Edit connector -> Test, I wonder if it should be replaced by the new fields as well

...atform/plugins/shared/cases/public/components/connectors/resilient/additional_form_field.tsx

...tform/plugins/shared/cases/public/components/connectors/resilient/additional_form_fields.tsx

x-pack/platform/plugins/shared/cases/public/components/connectors/constants.ts

christineweng · 2025-11-19T20:37:09Z

x-pack/platform/plugins/shared/cases/public/components/connectors/resilient/api.ts

  signal?: AbortSignal;
 }

-export async function getIncidentTypes({ http, connectorId, signal }: Props) {


I did a lookup on getIncidentTypes and found that under stack_connectors there is another api for this (and severity as well), do you know why there were 2?

x-pack/platform/plugins/shared/stack_connectors/public/connector_types/resilient/api.ts

Yeah, they're separate forms in separate plugins, see: #238869

janmonschke · 2025-11-20T08:30:14Z

The json editor is also used in Edit connector -> Test, I wonder if it should be replaced by the new fields as well

@christineweng That form is not owned by us and there's no easy way to share the form since these are different plugins. From what I understand, the Response Ops team is working on improving the connector forms as well so I did not want to interfere.

banderror

Approving changes to x-pack/solutions/security/test/security_solution_cypress/cypress/objects/case.ts

…onschke/kibana into cases/ibm-form-improvements

elasticmachine · 2025-12-03T11:56:38Z

💛 Build succeeded, but was flaky

Failed CI Steps

FTR Configs #113

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`cases`	1196	1198	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	1.4MB	1.4MB	+15.4KB

Count of Enzyme imports

Enzyme is no longer supported, and we should switch to @testing-library/react instead.

id	before	after	diff
`cases`	36	35	-1

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`cases`	70	74	+4

References to deprecated APIs

id	before	after	diff
`cases`	81	79	-2

Total ESLint disabled count

id	before	after	diff
`cases`	87	91	+4

History

💔 Build #367200 failed bba59b6
💚 Build #365942 succeeded 91cc1c1
💛 Build #364727 was flaky e2fcc59
💛 Build #364713 was flaky 4d9765d
💚 Build #364365 succeeded e3549d3

cc @janmonschke

## Summary Fixes: elastic#240446 This PR provides an improved experience of editing IBM resilient fields. Instead of editing IBM resilient fields with a JSON editor, this PR adds dynamic form elements for the IBM resilient fields. ### Demo https://github.com/user-attachments/assets/aedd61e4-9566-4196-b24e-52d4cd85e925 ### Other changes - Removed `useGetIncidentTypes` and `useGetSeverity` since they can both be obtained via `useGetFields`. This also removes the API calls from 3 to just a single one. - The connector preview is now a proper table and all connector previews have been changed. ### Testing - Add an IBM Resilient connector (hmu in Slack for credentials) - Create case, add additional fields to the connector, hit save - Observe that the fields and their values are shown in the case page - Edit the additional fields to your liking (adding, removing, editing) and make sure the changes are saved when pushing to IBM Resilient --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

janmonschke added 18 commits October 14, 2025 14:02

first iteration of dynamic form

46c697d

use inner form for state handling

b0250cf

validations

51a2df8

make sure, dates are properly encoded

83be9e5

faster lookup

261c47e

spacing

27e4def

form serialization

526619b

fox combobox initial values

37ad68e

make types correct

fd34f64

memoize parsed additionalFieldsFormField

6294690

rename var

721c2da

fix tests

3c21297

fix missing key warning

2c1768c

add first iteration of additional fields preview

c0e5407

fix tests

bcb0841

render correct field previews

366d4b7

fix cypress test

f902631

Merge branch 'main' into cases/ibm-form-improvements

9186e44

elastic deleted a comment from elasticmachine Oct 22, 2025

janmonschke added 9 commits October 22, 2025 14:47

remove showAdditionalFields

0857467

remove unused comment

0096057

memoization

1ea82c6

fix key warning

42e3f62

allow to delete fields

8e25b6b

add remove field button

4a5cc05

add space

3377e6c

add tests

6b9936e

remove timeout

83e4c8f

janmonschke self-assigned this Oct 24, 2025

janmonschke added the release_note:enhancement label Oct 24, 2025

PhilippeOberti approved these changes Nov 18, 2025

View reviewed changes

janmonschke added the ci:cloud-deploy Create or update a Cloud deployment label Nov 19, 2025

christineweng approved these changes Nov 19, 2025

View reviewed changes

janmonschke and others added 4 commits November 20, 2025 09:32

isInValid -> false

b62e2d1

remove unused query keys

686520a

extract mapper

7e8e350

Merge branch 'main' into cases/ibm-form-improvements

e2efa1c

banderror approved these changes Nov 20, 2025

View reviewed changes

janmonschke and others added 4 commits November 21, 2025 15:58

fix empty select value bug

8f4bbab

filter out read-only fields

fb69af1

Merge branch 'main' into cases/ibm-form-improvements

c7f069e

add more tests

e3549d3

janmonschke added the ci:cloud-persist-deployment Persist cloud deployment indefinitely label Nov 25, 2025

elasticmachine and others added 2 commits November 25, 2025 07:35

Merge branch 'main' into cases/ibm-form-improvements

0453db2

Changes from node scripts/regenerate_moon_projects.js --update

cfcfd3b

elastic-vault-github-plugin-prod bot requested a review from a team as a code owner November 25, 2025 06:54

janmonschke added 3 commits November 25, 2025 07:58

handle unset boolean fields as false

99f8d45

Merge branch 'cases/ibm-form-improvements' of https://github.com/janm…

4d9765d

…onschke/kibana into cases/ibm-form-improvements

improve type mapping

e2fcc59

jbudz removed the request for review from a team November 25, 2025 20:53

janmonschke added 4 commits November 26, 2025 16:56

Merge branch 'main' into cases/ibm-form-improvements

91cc1c1

Merge branch 'main' into cases/ibm-form-improvements

bba59b6

Merge branch 'main' into cases/ibm-form-improvements

b175b97

fix types

0446742

janmonschke enabled auto-merge (squash) December 3, 2025 11:30

janmonschke merged commit 9785c55 into elastic:main Dec 3, 2025
12 checks passed

michaelolo24 mentioned this pull request Dec 16, 2025

[Cases][Connectors] - Servicenow additional fields form editor #246576

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cases] IBM Resilient form improvements#238869

[Cases] IBM Resilient form improvements#238869
janmonschke merged 73 commits intoelastic:mainfrom
janmonschke:cases/ibm-form-improvements

janmonschke commented Oct 14, 2025 •

edited

Loading

PhilippeOberti left a comment

christineweng left a comment

Uh oh!

Uh oh!

Uh oh!

christineweng Nov 19, 2025

janmonschke Nov 20, 2025

janmonschke commented Nov 20, 2025

banderror left a comment

elasticmachine commented Dec 3, 2025 •

edited

Loading

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

Uh oh!

Labels

6 participants

Conversation

janmonschke commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Demo

Other changes

Testing

PhilippeOberti left a comment

Choose a reason for hiding this comment

christineweng left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

christineweng Nov 19, 2025

Choose a reason for hiding this comment

janmonschke Nov 20, 2025

Choose a reason for hiding this comment

janmonschke commented Nov 20, 2025

banderror left a comment

Choose a reason for hiding this comment

elasticmachine commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Async chunks

Count of Enzyme imports

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

History

Uh oh!

Labels

6 participants

janmonschke commented Oct 14, 2025 •

edited

Loading

elasticmachine commented Dec 3, 2025 •

edited

Loading