[Lens] Fix metric color assignment when breakdown and a max dimension are defined#238901
Merged
dej611 merged 4 commits intoelastic:mainfrom Oct 16, 2025
Merged
[Lens] Fix metric color assignment when breakdown and a max dimension are defined#238901dej611 merged 4 commits intoelastic:mainfrom
dej611 merged 4 commits intoelastic:mainfrom
Conversation
dej611
added
release_note:fix
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
dej611
commented
Oct 15, 2025
...chart_expressions/expression_metric/public/components/__snapshots__/metric_vis.test.tsx.snap
Show resolved
Hide resolved
Contributor
💚 Build Succeeded
Metrics [docs]Page load bundle
History
|
...tform/plugins/shared/chart_expressions/expression_metric/public/utils/palette_data_bounds.ts
Show resolved
Hide resolved
nickofthyme
approved these changes
Oct 15, 2025
Contributor
|
Starting backport for target branches: 8.19, 9.1, 9.2 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 16, 2025
… are defined (elastic#238901) ## Summary Fixes elastic#238885 This PR revisits the `getDataBoundsForPalette` function implementation to boost its performance and fix a falsy check based on `rowNumber`. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit b05f445)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 16, 2025
… are defined (elastic#238901) ## Summary Fixes elastic#238885 This PR revisits the `getDataBoundsForPalette` function implementation to boost its performance and fix a falsy check based on `rowNumber`. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit b05f445)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 16, 2025
… are defined (elastic#238901) ## Summary Fixes elastic#238885 This PR revisits the `getDataBoundsForPalette` function implementation to boost its performance and fix a falsy check based on `rowNumber`. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit b05f445)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 16, 2025
…ension are defined (#238901) (#239295) # Backport This will backport the following commits from `main` to `9.1`: - [[Lens] Fix metric color assignment when breakdown and a max dimension are defined (#238901)](#238901) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-10-16T09:56:43Z","message":"[Lens] Fix metric color assignment when breakdown and a max dimension are defined (#238901)\n\n## Summary\n\nFixes #238885 \n\nThis PR revisits the `getDataBoundsForPalette` function implementation\nto boost its performance and fix a falsy check based on `rowNumber`.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"b05f445ce7e4bb6deead5cbac4aa57931b884223","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","backport:version","v9.2.0","v9.3.0","v9.1.6","v8.19.6"],"title":"[Lens] Fix metric color assignment when breakdown and a max dimension are defined","number":238901,"url":"https://github.com/elastic/kibana/pull/238901","mergeCommit":{"message":"[Lens] Fix metric color assignment when breakdown and a max dimension are defined (#238901)\n\n## Summary\n\nFixes #238885 \n\nThis PR revisits the `getDataBoundsForPalette` function implementation\nto boost its performance and fix a falsy check based on `rowNumber`.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"b05f445ce7e4bb6deead5cbac4aa57931b884223"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.1","8.19"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238901","number":238901,"mergeCommit":{"message":"[Lens] Fix metric color assignment when breakdown and a max dimension are defined (#238901)\n\n## Summary\n\nFixes #238885 \n\nThis PR revisits the `getDataBoundsForPalette` function implementation\nto boost its performance and fix a falsy check based on `rowNumber`.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"b05f445ce7e4bb6deead5cbac4aa57931b884223"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Oct 16, 2025
…mension are defined (#238901) (#239294) # Backport This will backport the following commits from `main` to `8.19`: - [[Lens] Fix metric color assignment when breakdown and a max dimension are defined (#238901)](#238901) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-10-16T09:56:43Z","message":"[Lens] Fix metric color assignment when breakdown and a max dimension are defined (#238901)\n\n## Summary\n\nFixes #238885 \n\nThis PR revisits the `getDataBoundsForPalette` function implementation\nto boost its performance and fix a falsy check based on `rowNumber`.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"b05f445ce7e4bb6deead5cbac4aa57931b884223","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","backport:version","v9.2.0","v9.3.0","v9.1.6","v8.19.6"],"title":"[Lens] Fix metric color assignment when breakdown and a max dimension are defined","number":238901,"url":"https://github.com/elastic/kibana/pull/238901","mergeCommit":{"message":"[Lens] Fix metric color assignment when breakdown and a max dimension are defined (#238901)\n\n## Summary\n\nFixes #238885 \n\nThis PR revisits the `getDataBoundsForPalette` function implementation\nto boost its performance and fix a falsy check based on `rowNumber`.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"b05f445ce7e4bb6deead5cbac4aa57931b884223"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.1","8.19"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238901","number":238901,"mergeCommit":{"message":"[Lens] Fix metric color assignment when breakdown and a max dimension are defined (#238901)\n\n## Summary\n\nFixes #238885 \n\nThis PR revisits the `getDataBoundsForPalette` function implementation\nto boost its performance and fix a falsy check based on `rowNumber`.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"b05f445ce7e4bb6deead5cbac4aa57931b884223"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Oct 16, 2025
…ension are defined (#238901) (#239296) # Backport This will backport the following commits from `main` to `9.2`: - [[Lens] Fix metric color assignment when breakdown and a max dimension are defined (#238901)](#238901) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-10-16T09:56:43Z","message":"[Lens] Fix metric color assignment when breakdown and a max dimension are defined (#238901)\n\n## Summary\n\nFixes #238885 \n\nThis PR revisits the `getDataBoundsForPalette` function implementation\nto boost its performance and fix a falsy check based on `rowNumber`.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"b05f445ce7e4bb6deead5cbac4aa57931b884223","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","backport:version","v9.2.0","v9.3.0","v9.1.6","v8.19.6"],"title":"[Lens] Fix metric color assignment when breakdown and a max dimension are defined","number":238901,"url":"https://github.com/elastic/kibana/pull/238901","mergeCommit":{"message":"[Lens] Fix metric color assignment when breakdown and a max dimension are defined (#238901)\n\n## Summary\n\nFixes #238885 \n\nThis PR revisits the `getDataBoundsForPalette` function implementation\nto boost its performance and fix a falsy check based on `rowNumber`.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"b05f445ce7e4bb6deead5cbac4aa57931b884223"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.1","8.19"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238901","number":238901,"mergeCommit":{"message":"[Lens] Fix metric color assignment when breakdown and a max dimension are defined (#238901)\n\n## Summary\n\nFixes #238885 \n\nThis PR revisits the `getDataBoundsForPalette` function implementation\nto boost its performance and fix a falsy check based on `rowNumber`.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"b05f445ce7e4bb6deead5cbac4aa57931b884223"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Oct 23, 2025
… are defined (elastic#238901) ## Summary Fixes elastic#238885 This PR revisits the `getDataBoundsForPalette` function implementation to boost its performance and fix a falsy check based on `rowNumber`. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Oct 27, 2025
… are defined (elastic#238901) ## Summary Fixes elastic#238885 This PR revisits the `getDataBoundsForPalette` function implementation to boost its performance and fix a falsy check based on `rowNumber`. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #238885
This PR revisits the
getDataBoundsForPalettefunction implementation to boost its performance and fix a falsy check based onrowNumber.