[ES|QL] Displays the available options when editing an existing variable control#239315
Merged
stratoula merged 1 commit intoelastic:mainfrom Oct 16, 2025
Merged
Conversation
stratoula
added
Feature:ES|QL
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
bartoval
approved these changes
Oct 16, 2025
sddonne
approved these changes
Oct 16, 2025
| } else if (valuesRetrieval) { | ||
| const queryForValues = `FROM ${getIndexPatternFromESQLQuery( | ||
| queryString | ||
| )} | STATS BY ${valuesRetrieval}`; |
Contributor
There was a problem hiding this comment.
Could be handy to use appendStatsByToQuery? it has some safe wards in case the query already ends with STATS BY.
Contributor
There was a problem hiding this comment.
ah it's using getIndexPatternFromESQLQuery, so it will never end with STATS BY
Contributor
Author
There was a problem hiding this comment.
yes different use case
Contributor
|
Starting backport for target branches: 9.2 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 16, 2025
…ble control (elastic#239315) ## Summary Regression caused from this PR elastic#231690 When you have an existing control and edit it, the query doesnt run to get the available options. As a result the UX is kinda broken. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 84ad1f3)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 17, 2025
… variable control (#239315) (#239350) # Backport This will backport the following commits from `main` to `9.2`: - [[ES|QL] Displays the available options when editing an existing variable control (#239315)](#239315) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Stratou","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-10-16T13:19:40Z","message":"[ES|QL] Displays the available options when editing an existing variable control (#239315)\n\n## Summary\n\nRegression caused from this PR\nhttps://github.com//pull/231690\n\nWhen you have an existing control and edit it, the query doesnt run to\nget the available options. As a result the UX is kinda broken.\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"84ad1f31553c96fd09f9baa8bc74ba6a6a17eea6","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["regression","release_note:fix","Feature:ES|QL","Team:ESQL","backport:version","v9.2.0","v9.3.0"],"title":"[ES|QL] Displays the available options when editing an existing variable control","number":239315,"url":"https://github.com/elastic/kibana/pull/239315","mergeCommit":{"message":"[ES|QL] Displays the available options when editing an existing variable control (#239315)\n\n## Summary\n\nRegression caused from this PR\nhttps://github.com//pull/231690\n\nWhen you have an existing control and edit it, the query doesnt run to\nget the available options. As a result the UX is kinda broken.\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"84ad1f31553c96fd09f9baa8bc74ba6a6a17eea6"}},"sourceBranch":"main","suggestedTargetBranches":["9.2"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/239315","number":239315,"mergeCommit":{"message":"[ES|QL] Displays the available options when editing an existing variable control (#239315)\n\n## Summary\n\nRegression caused from this PR\nhttps://github.com//pull/231690\n\nWhen you have an existing control and edit it, the query doesnt run to\nget the available options. As a result the UX is kinda broken.\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"84ad1f31553c96fd09f9baa8bc74ba6a6a17eea6"}}]}] BACKPORT--> Co-authored-by: Stratou <efstratia.kalafateli@elastic.co>
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Oct 23, 2025
…ble control (elastic#239315) ## Summary Regression caused from this PR elastic#231690 When you have an existing control and edit it, the query doesnt run to get the available options. As a result the UX is kinda broken. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Oct 27, 2025
…ble control (elastic#239315) ## Summary Regression caused from this PR elastic#231690 When you have an existing control and edit it, the query doesnt run to get the available options. As a result the UX is kinda broken. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regression caused from this PR #231690
When you have an existing control and edit it, the query doesnt run to get the available options. As a result the UX is kinda broken.
Checklist