[Cases][a11y] Remove autoFocus to preserve proper focus when modal closed#239366
Merged
janmonschke merged 3 commits intoelastic:mainfrom Oct 17, 2025
Merged
Conversation
janmonschke
added
release_note:fix
backport:version
Contributor
|
Pinging @elastic/kibana-cases (Team:Cases) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
cc @janmonschke |
janmonschke
changed the title
autoFocus to preserve proper focus when modal closed
lgestc
approved these changes
Oct 17, 2025
Contributor
|
Starting backport for target branches: 9.2 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 17, 2025
…closed (elastic#239366) ## Summary Fixes elastic#205689 The `autoFocus` prop prevented the correct focus handling of the closed EUI flyout. Just removing `autoFocus` was not enough, it has to be set to `false`. https://github.com/user-attachments/assets/1cbb5ea9-3284-4fe0-84e1-4370babae977 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co> (cherry picked from commit ec7ca51)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 17, 2025
…modal closed (#239366) (#239518) # Backport This will backport the following commits from `main` to `9.2`: - [[Cases][a11y] Remove `autoFocus` to preserve proper focus when modal closed (#239366)](#239366) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jan Monschke","email":"jan.monschke@elastic.co"},"sourceCommit":{"committedDate":"2025-10-17T09:46:15Z","message":"[Cases][a11y] Remove `autoFocus` to preserve proper focus when modal closed (#239366)\n\n## Summary\n\nFixes https://github.com/elastic/kibana/issues/205689\n\nThe `autoFocus` prop prevented the correct focus handling of the closed\nEUI flyout. Just removing `autoFocus` was not enough, it has to be set\nto `false`.\n\n\nhttps://github.com/user-attachments/assets/1cbb5ea9-3284-4fe0-84e1-4370babae977\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>","sha":"ec7ca510f78d2988ca2d2e5666223fed50d9db76","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:version","Team:Cases","v9.2.0","v9.3.0"],"title":"[Cases][a11y] Remove `autoFocus` to preserve proper focus when modal closed","number":239366,"url":"https://github.com/elastic/kibana/pull/239366","mergeCommit":{"message":"[Cases][a11y] Remove `autoFocus` to preserve proper focus when modal closed (#239366)\n\n## Summary\n\nFixes https://github.com/elastic/kibana/issues/205689\n\nThe `autoFocus` prop prevented the correct focus handling of the closed\nEUI flyout. Just removing `autoFocus` was not enough, it has to be set\nto `false`.\n\n\nhttps://github.com/user-attachments/assets/1cbb5ea9-3284-4fe0-84e1-4370babae977\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>","sha":"ec7ca510f78d2988ca2d2e5666223fed50d9db76"}},"sourceBranch":"main","suggestedTargetBranches":["9.2"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/239366","number":239366,"mergeCommit":{"message":"[Cases][a11y] Remove `autoFocus` to preserve proper focus when modal closed (#239366)\n\n## Summary\n\nFixes https://github.com/elastic/kibana/issues/205689\n\nThe `autoFocus` prop prevented the correct focus handling of the closed\nEUI flyout. Just removing `autoFocus` was not enough, it has to be set\nto `false`.\n\n\nhttps://github.com/user-attachments/assets/1cbb5ea9-3284-4fe0-84e1-4370babae977\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>","sha":"ec7ca510f78d2988ca2d2e5666223fed50d9db76"}}]}] BACKPORT--> Co-authored-by: Jan Monschke <jan.monschke@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Oct 23, 2025
…closed (elastic#239366) ## Summary Fixes elastic#205689 The `autoFocus` prop prevented the correct focus handling of the closed EUI flyout. Just removing `autoFocus` was not enough, it has to be set to `false`. https://github.com/user-attachments/assets/1cbb5ea9-3284-4fe0-84e1-4370babae977 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Oct 27, 2025
…closed (elastic#239366) ## Summary Fixes elastic#205689 The `autoFocus` prop prevented the correct focus handling of the closed EUI flyout. Just removing `autoFocus` was not enough, it has to be set to `false`. https://github.com/user-attachments/assets/1cbb5ea9-3284-4fe0-84e1-4370babae977 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #205689
The
autoFocusprop prevented the correct focus handling of the closed EUI flyout. Just removingautoFocuswas not enough, it has to be set tofalse.Screen.Recording.2025-10-16.at.16.25.46.mov