[Cases][a11y] Add manual focus to action buttons' actions#239504
Merged
janmonschke merged 3 commits intoelastic:mainfrom Oct 17, 2025
Merged
[Cases][a11y] Add manual focus to action buttons' actions#239504janmonschke merged 3 commits intoelastic:mainfrom
janmonschke merged 3 commits intoelastic:mainfrom
Conversation
janmonschke
added
release_note:fix
backport:version
Contributor
|
Pinging @elastic/kibana-cases (Team:Cases) |
lgestc
approved these changes
Oct 17, 2025
Contributor
lgestc
left a comment
lgestc
left a comment
There was a problem hiding this comment.
looking good, just one improvement suggestion added 🚀
Comment on lines
64
to
71
| returnFocus() { | ||
| if (focusButtonRef && 'current' in focusButtonRef && focusButtonRef.current) { | ||
| focusButtonRef.current.focus(); | ||
| return false; | ||
| } | ||
| return true; | ||
| }, | ||
| }), |
Contributor
There was a problem hiding this comment.
maybe we could abstract into some kind of a shared function?
Contributor
Author
There was a problem hiding this comment.
Good call, I moved it into a hook: e79d245
Contributor
|
Starting backport for target branches: 9.2 |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
cc @janmonschke |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 17, 2025
…9504) ## Summary <img width="953" height="558" alt="Screenshot 2025-10-17 at 11 25 59" src="https://github.com/user-attachments/assets/86915980-5ce1-434c-8484-b9d5fe26ec86" /> Many of the action button's actions open new flyouts or modals. In those cases, the focus trap isn't working correctly and we need to manually assign focus to the original action button after the performed action is done. Fixes elastic#195073 Fixes elastic#195021 Fixes elastic#195024 (cherry picked from commit 293a1c0)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 17, 2025
) (#239548) # Backport This will backport the following commits from `main` to `9.2`: - [[Cases][a11y] Add manual focus to action buttons' actions (#239504)](#239504) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jan Monschke","email":"jan.monschke@elastic.co"},"sourceCommit":{"committedDate":"2025-10-17T12:02:44Z","message":"[Cases][a11y] Add manual focus to action buttons' actions (#239504)\n\n## Summary\n\n<img width=\"953\" height=\"558\" alt=\"Screenshot 2025-10-17 at 11 25 59\"\nsrc=\"https://github.com/user-attachments/assets/86915980-5ce1-434c-8484-b9d5fe26ec86\"\n/>\n\nMany of the action button's actions open new flyouts or modals. In those\ncases, the focus trap isn't working correctly and we need to manually\nassign focus to the original action button after the performed action is\ndone.\n\nFixes https://github.com/elastic/kibana/issues/195073\nFixes https://github.com/elastic/kibana/issues/195021\nFixes https://github.com/elastic/kibana/issues/195024","sha":"293a1c0fe69667089bf1f7eac32f2f411b093968","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:version","Team:Cases","v9.2.0","v9.3.0"],"title":"[Cases][a11y] Add manual focus to action buttons' actions","number":239504,"url":"https://github.com/elastic/kibana/pull/239504","mergeCommit":{"message":"[Cases][a11y] Add manual focus to action buttons' actions (#239504)\n\n## Summary\n\n<img width=\"953\" height=\"558\" alt=\"Screenshot 2025-10-17 at 11 25 59\"\nsrc=\"https://github.com/user-attachments/assets/86915980-5ce1-434c-8484-b9d5fe26ec86\"\n/>\n\nMany of the action button's actions open new flyouts or modals. In those\ncases, the focus trap isn't working correctly and we need to manually\nassign focus to the original action button after the performed action is\ndone.\n\nFixes https://github.com/elastic/kibana/issues/195073\nFixes https://github.com/elastic/kibana/issues/195021\nFixes https://github.com/elastic/kibana/issues/195024","sha":"293a1c0fe69667089bf1f7eac32f2f411b093968"}},"sourceBranch":"main","suggestedTargetBranches":["9.2"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/239504","number":239504,"mergeCommit":{"message":"[Cases][a11y] Add manual focus to action buttons' actions (#239504)\n\n## Summary\n\n<img width=\"953\" height=\"558\" alt=\"Screenshot 2025-10-17 at 11 25 59\"\nsrc=\"https://github.com/user-attachments/assets/86915980-5ce1-434c-8484-b9d5fe26ec86\"\n/>\n\nMany of the action button's actions open new flyouts or modals. In those\ncases, the focus trap isn't working correctly and we need to manually\nassign focus to the original action button after the performed action is\ndone.\n\nFixes https://github.com/elastic/kibana/issues/195073\nFixes https://github.com/elastic/kibana/issues/195021\nFixes https://github.com/elastic/kibana/issues/195024","sha":"293a1c0fe69667089bf1f7eac32f2f411b093968"}}]}] BACKPORT--> Co-authored-by: Jan Monschke <jan.monschke@elastic.co>
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Oct 23, 2025
…9504) ## Summary <img width="953" height="558" alt="Screenshot 2025-10-17 at 11 25 59" src="https://github.com/user-attachments/assets/86915980-5ce1-434c-8484-b9d5fe26ec86" /> Many of the action button's actions open new flyouts or modals. In those cases, the focus trap isn't working correctly and we need to manually assign focus to the original action button after the performed action is done. Fixes elastic#195073 Fixes elastic#195021 Fixes elastic#195024
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Oct 27, 2025
…9504) ## Summary <img width="953" height="558" alt="Screenshot 2025-10-17 at 11 25 59" src="https://github.com/user-attachments/assets/86915980-5ce1-434c-8484-b9d5fe26ec86" /> Many of the action button's actions open new flyouts or modals. In those cases, the focus trap isn't working correctly and we need to manually assign focus to the original action button after the performed action is done. Fixes elastic#195073 Fixes elastic#195021 Fixes elastic#195024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Many of the action button's actions open new flyouts or modals. In those cases, the focus trap isn't working correctly and we need to manually assign focus to the original action button after the performed action is done.
Fixes #195073
Fixes #195021
Fixes #195024