[Controls] Fix error when selecting "(blank)" value in options list#239791
Merged
nickpeihl merged 1 commit intoelastic:mainfrom Oct 20, 2025
Merged
[Controls] Fix error when selecting "(blank)" value in options list#239791nickpeihl merged 1 commit intoelastic:mainfrom
nickpeihl merged 1 commit intoelastic:mainfrom
Conversation
nickpeihl
added
release_note:fix
Feature:Input Control
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
approved these changes
Oct 20, 2025
Contributor
ThomThomson
left a comment
ThomThomson
left a comment
There was a problem hiding this comment.
Nice work and thanks for the quick turnaround on this issue. It's awesome to see this kind of SDH -> PR flow. LGTM!
| }); | ||
| }); | ||
|
|
||
| test('renders a "(blank)" option', async () => { |
Contributor
⏳ Build in-progress, with failures
Failed CI Steps |
Contributor
|
Starting backport for target branches: 8.19, 9.1, 9.2 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 20, 2025
…lastic#239791) Fixes elastic#239735 ## Summary Fixes an error in the Options list control when selecting a "(blank)" value. Makes the boolean check for key more explicit using [loose equality to check if the key is null or undefined](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Equality_comparisons_and_sameness#loose_equality_using). Without this, selecting a `""` value causes the control to error. (cherry picked from commit 3675825)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 20, 2025
…lastic#239791) Fixes elastic#239735 ## Summary Fixes an error in the Options list control when selecting a "(blank)" value. Makes the boolean check for key more explicit using [loose equality to check if the key is null or undefined](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Equality_comparisons_and_sameness#loose_equality_using). Without this, selecting a `""` value causes the control to error. (cherry picked from commit 3675825)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 20, 2025
…lastic#239791) Fixes elastic#239735 ## Summary Fixes an error in the Options list control when selecting a "(blank)" value. Makes the boolean check for key more explicit using [loose equality to check if the key is null or undefined](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Equality_comparisons_and_sameness#loose_equality_using). Without this, selecting a `""` value causes the control to error. (cherry picked from commit 3675825)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 20, 2025
…list (#239791) (#239813) # Backport This will backport the following commits from `main` to `9.1`: - [[Controls] Fix error when selecting "(blank)" value in options list (#239791)](#239791) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nick Peihl","email":"nick.peihl@elastic.co"},"sourceCommit":{"committedDate":"2025-10-20T19:52:09Z","message":"[Controls] Fix error when selecting \"(blank)\" value in options list (#239791)\n\nFixes #239735\n\n## Summary\n\nFixes an error in the Options list control when selecting a \"(blank)\"\nvalue.\n\nMakes the boolean check for key more explicit using [loose equality to\ncheck if the key is null or\nundefined](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Equality_comparisons_and_sameness#loose_equality_using).\nWithout this, selecting a `\"\"` value causes the control to error.","sha":"36758259f660d3d512b5f90ee3f5dadd7c3114b9","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Input Control","Team:Presentation","backport:version","v9.2.0","v9.3.0","v9.1.6","v8.19.6"],"title":"[Controls] Fix error when selecting \"(blank)\" value in options list","number":239791,"url":"https://github.com/elastic/kibana/pull/239791","mergeCommit":{"message":"[Controls] Fix error when selecting \"(blank)\" value in options list (#239791)\n\nFixes #239735\n\n## Summary\n\nFixes an error in the Options list control when selecting a \"(blank)\"\nvalue.\n\nMakes the boolean check for key more explicit using [loose equality to\ncheck if the key is null or\nundefined](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Equality_comparisons_and_sameness#loose_equality_using).\nWithout this, selecting a `\"\"` value causes the control to error.","sha":"36758259f660d3d512b5f90ee3f5dadd7c3114b9"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.1","8.19"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/239791","number":239791,"mergeCommit":{"message":"[Controls] Fix error when selecting \"(blank)\" value in options list (#239791)\n\nFixes #239735\n\n## Summary\n\nFixes an error in the Options list control when selecting a \"(blank)\"\nvalue.\n\nMakes the boolean check for key more explicit using [loose equality to\ncheck if the key is null or\nundefined](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Equality_comparisons_and_sameness#loose_equality_using).\nWithout this, selecting a `\"\"` value causes the control to error.","sha":"36758259f660d3d512b5f90ee3f5dadd7c3114b9"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 20, 2025
… list (#239791) (#239812) # Backport This will backport the following commits from `main` to `8.19`: - [[Controls] Fix error when selecting "(blank)" value in options list (#239791)](#239791) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nick Peihl","email":"nick.peihl@elastic.co"},"sourceCommit":{"committedDate":"2025-10-20T19:52:09Z","message":"[Controls] Fix error when selecting \"(blank)\" value in options list (#239791)\n\nFixes #239735\n\n## Summary\n\nFixes an error in the Options list control when selecting a \"(blank)\"\nvalue.\n\nMakes the boolean check for key more explicit using [loose equality to\ncheck if the key is null or\nundefined](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Equality_comparisons_and_sameness#loose_equality_using).\nWithout this, selecting a `\"\"` value causes the control to error.","sha":"36758259f660d3d512b5f90ee3f5dadd7c3114b9","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Input Control","Team:Presentation","backport:version","v9.2.0","v9.3.0","v9.1.6","v8.19.6"],"title":"[Controls] Fix error when selecting \"(blank)\" value in options list","number":239791,"url":"https://github.com/elastic/kibana/pull/239791","mergeCommit":{"message":"[Controls] Fix error when selecting \"(blank)\" value in options list (#239791)\n\nFixes #239735\n\n## Summary\n\nFixes an error in the Options list control when selecting a \"(blank)\"\nvalue.\n\nMakes the boolean check for key more explicit using [loose equality to\ncheck if the key is null or\nundefined](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Equality_comparisons_and_sameness#loose_equality_using).\nWithout this, selecting a `\"\"` value causes the control to error.","sha":"36758259f660d3d512b5f90ee3f5dadd7c3114b9"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.1","8.19"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/239791","number":239791,"mergeCommit":{"message":"[Controls] Fix error when selecting \"(blank)\" value in options list (#239791)\n\nFixes #239735\n\n## Summary\n\nFixes an error in the Options list control when selecting a \"(blank)\"\nvalue.\n\nMakes the boolean check for key more explicit using [loose equality to\ncheck if the key is null or\nundefined](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Equality_comparisons_and_sameness#loose_equality_using).\nWithout this, selecting a `\"\"` value causes the control to error.","sha":"36758259f660d3d512b5f90ee3f5dadd7c3114b9"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 20, 2025
…list (#239791) (#239814) # Backport This will backport the following commits from `main` to `9.2`: - [[Controls] Fix error when selecting "(blank)" value in options list (#239791)](#239791) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nick Peihl","email":"nick.peihl@elastic.co"},"sourceCommit":{"committedDate":"2025-10-20T19:52:09Z","message":"[Controls] Fix error when selecting \"(blank)\" value in options list (#239791)\n\nFixes #239735\n\n## Summary\n\nFixes an error in the Options list control when selecting a \"(blank)\"\nvalue.\n\nMakes the boolean check for key more explicit using [loose equality to\ncheck if the key is null or\nundefined](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Equality_comparisons_and_sameness#loose_equality_using).\nWithout this, selecting a `\"\"` value causes the control to error.","sha":"36758259f660d3d512b5f90ee3f5dadd7c3114b9","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Input Control","Team:Presentation","backport:version","v9.2.0","v9.3.0","v9.1.6","v8.19.6"],"title":"[Controls] Fix error when selecting \"(blank)\" value in options list","number":239791,"url":"https://github.com/elastic/kibana/pull/239791","mergeCommit":{"message":"[Controls] Fix error when selecting \"(blank)\" value in options list (#239791)\n\nFixes #239735\n\n## Summary\n\nFixes an error in the Options list control when selecting a \"(blank)\"\nvalue.\n\nMakes the boolean check for key more explicit using [loose equality to\ncheck if the key is null or\nundefined](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Equality_comparisons_and_sameness#loose_equality_using).\nWithout this, selecting a `\"\"` value causes the control to error.","sha":"36758259f660d3d512b5f90ee3f5dadd7c3114b9"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.1","8.19"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/239791","number":239791,"mergeCommit":{"message":"[Controls] Fix error when selecting \"(blank)\" value in options list (#239791)\n\nFixes #239735\n\n## Summary\n\nFixes an error in the Options list control when selecting a \"(blank)\"\nvalue.\n\nMakes the boolean check for key more explicit using [loose equality to\ncheck if the key is null or\nundefined](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Equality_comparisons_and_sameness#loose_equality_using).\nWithout this, selecting a `\"\"` value causes the control to error.","sha":"36758259f660d3d512b5f90ee3f5dadd7c3114b9"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
nickpeihl
added a commit
to nickpeihl/kibana
that referenced
this pull request
Oct 23, 2025
…lastic#239791) Fixes elastic#239735 ## Summary Fixes an error in the Options list control when selecting a "(blank)" value. Makes the boolean check for key more explicit using [loose equality to check if the key is null or undefined](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Equality_comparisons_and_sameness#loose_equality_using). Without this, selecting a `""` value causes the control to error.
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Oct 27, 2025
…lastic#239791) Fixes elastic#239735 ## Summary Fixes an error in the Options list control when selecting a "(blank)" value. Makes the boolean check for key more explicit using [loose equality to check if the key is null or undefined](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Equality_comparisons_and_sameness#loose_equality_using). Without this, selecting a `""` value causes the control to error.
1 task
Zacqary
added a commit
that referenced
this pull request
Nov 10, 2025
## Summary Closes #241750 Fixes an error with deselecting a `(blank)` option from an options list. The same error when *selecting* the option was fixed in #239791, but we missed fixing it for deselection. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 10, 2025
…242036) ## Summary Closes elastic#241750 Fixes an error with deselecting a `(blank)` option from an options list. The same error when *selecting* the option was fixed in elastic#239791, but we missed fixing it for deselection. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 783f287)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 10, 2025
…242036) ## Summary Closes elastic#241750 Fixes an error with deselecting a `(blank)` option from an options list. The same error when *selecting* the option was fixed in elastic#239791, but we missed fixing it for deselection. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 783f287)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 10, 2025
…242036) ## Summary Closes elastic#241750 Fixes an error with deselecting a `(blank)` option from an options list. The same error when *selecting* the option was fixed in elastic#239791, but we missed fixing it for deselection. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 783f287)
kibanamachine
added a commit
that referenced
this pull request
Nov 10, 2025
…42036) (#242473) # Backport This will backport the following commits from `main` to `9.2`: - [[Controls] Fix deselecting (blank) option from options list (#242036)](#242036) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Zac Xeper","email":"Zacqary@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-11-10T19:31:00Z","message":"[Controls] Fix deselecting (blank) option from options list (#242036)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/241750\n\nFixes an error with deselecting a `(blank)` option from an options list.\n\nThe same error when *selecting* the option was fixed in\nhttps://github.com//pull/239791, but we missed fixing it\nfor deselection.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"783f287fb0ec41359eacc335f0258aaebeb377d1","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Input Control","Team:Presentation","Project:Controls","backport:version","v9.2.0","v9.3.0","v8.19.7","v9.1.7"],"title":"[Controls] Fix deselecting (blank) option from options list","number":242036,"url":"https://github.com/elastic/kibana/pull/242036","mergeCommit":{"message":"[Controls] Fix deselecting (blank) option from options list (#242036)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/241750\n\nFixes an error with deselecting a `(blank)` option from an options list.\n\nThe same error when *selecting* the option was fixed in\nhttps://github.com//pull/239791, but we missed fixing it\nfor deselection.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"783f287fb0ec41359eacc335f0258aaebeb377d1"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","8.19","9.1"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/242036","number":242036,"mergeCommit":{"message":"[Controls] Fix deselecting (blank) option from options list (#242036)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/241750\n\nFixes an error with deselecting a `(blank)` option from an options list.\n\nThe same error when *selecting* the option was fixed in\nhttps://github.com//pull/239791, but we missed fixing it\nfor deselection.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"783f287fb0ec41359eacc335f0258aaebeb377d1"}},{"branch":"8.19","label":"v8.19.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Zac Xeper <Zacqary@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Nov 10, 2025
…242036) (#242471) # Backport This will backport the following commits from `main` to `8.19`: - [[Controls] Fix deselecting (blank) option from options list (#242036)](#242036) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Zac Xeper","email":"Zacqary@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-11-10T19:31:00Z","message":"[Controls] Fix deselecting (blank) option from options list (#242036)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/241750\n\nFixes an error with deselecting a `(blank)` option from an options list.\n\nThe same error when *selecting* the option was fixed in\nhttps://github.com//pull/239791, but we missed fixing it\nfor deselection.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"783f287fb0ec41359eacc335f0258aaebeb377d1","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Input Control","Team:Presentation","Project:Controls","backport:version","v9.2.0","v9.3.0","v8.19.7","v9.1.7"],"title":"[Controls] Fix deselecting (blank) option from options list","number":242036,"url":"https://github.com/elastic/kibana/pull/242036","mergeCommit":{"message":"[Controls] Fix deselecting (blank) option from options list (#242036)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/241750\n\nFixes an error with deselecting a `(blank)` option from an options list.\n\nThe same error when *selecting* the option was fixed in\nhttps://github.com//pull/239791, but we missed fixing it\nfor deselection.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"783f287fb0ec41359eacc335f0258aaebeb377d1"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","8.19","9.1"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/242036","number":242036,"mergeCommit":{"message":"[Controls] Fix deselecting (blank) option from options list (#242036)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/241750\n\nFixes an error with deselecting a `(blank)` option from an options list.\n\nThe same error when *selecting* the option was fixed in\nhttps://github.com//pull/239791, but we missed fixing it\nfor deselection.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"783f287fb0ec41359eacc335f0258aaebeb377d1"}},{"branch":"8.19","label":"v8.19.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Zac Xeper <Zacqary@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Nov 10, 2025
…42036) (#242472) # Backport This will backport the following commits from `main` to `9.1`: - [[Controls] Fix deselecting (blank) option from options list (#242036)](#242036) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Zac Xeper","email":"Zacqary@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-11-10T19:31:00Z","message":"[Controls] Fix deselecting (blank) option from options list (#242036)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/241750\n\nFixes an error with deselecting a `(blank)` option from an options list.\n\nThe same error when *selecting* the option was fixed in\nhttps://github.com//pull/239791, but we missed fixing it\nfor deselection.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"783f287fb0ec41359eacc335f0258aaebeb377d1","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Input Control","Team:Presentation","Project:Controls","backport:version","v9.2.0","v9.3.0","v8.19.7","v9.1.7"],"title":"[Controls] Fix deselecting (blank) option from options list","number":242036,"url":"https://github.com/elastic/kibana/pull/242036","mergeCommit":{"message":"[Controls] Fix deselecting (blank) option from options list (#242036)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/241750\n\nFixes an error with deselecting a `(blank)` option from an options list.\n\nThe same error when *selecting* the option was fixed in\nhttps://github.com//pull/239791, but we missed fixing it\nfor deselection.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"783f287fb0ec41359eacc335f0258aaebeb377d1"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","8.19","9.1"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/242036","number":242036,"mergeCommit":{"message":"[Controls] Fix deselecting (blank) option from options list (#242036)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/241750\n\nFixes an error with deselecting a `(blank)` option from an options list.\n\nThe same error when *selecting* the option was fixed in\nhttps://github.com//pull/239791, but we missed fixing it\nfor deselection.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"783f287fb0ec41359eacc335f0258aaebeb377d1"}},{"branch":"8.19","label":"v8.19.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Zac Xeper <Zacqary@users.noreply.github.com>
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Dec 2, 2025
…242036) ## Summary Closes elastic#241750 Fixes an error with deselecting a `(blank)` option from an options list. The same error when *selecting* the option was fixed in elastic#239791, but we missed fixing it for deselection. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #239735
Summary
Fixes an error in the Options list control when selecting a "(blank)" value.
Makes the boolean check for key more explicit using loose equality to check if the key is null or undefined. Without this, selecting a
""value causes the control to error.