[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range#239992
Merged
nreese merged 1 commit intoelastic:mainfrom Oct 22, 2025
Merged
[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range#239992nreese merged 1 commit intoelastic:mainfrom
nreese merged 1 commit intoelastic:mainfrom
Conversation
…ore and setting time range
Contributor
Author
|
/ci |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
nreese
added
release_note:fix
Team:Presentation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
approved these changes
Oct 22, 2025
Contributor
ThomThomson
left a comment
ThomThomson
left a comment
There was a problem hiding this comment.
Very nice work! Changes LGTM, and it's great to see another aspect of the Dashboard client API getting unit test coverage.
|
|
||
| await new Promise((resolve) => setTimeout(resolve, COMPARE_DEBOUNCE + 1)); | ||
|
|
||
| expect(unsavedChanges).toMatchInlineSnapshot(`Object {}`); |
Contributor
|
Starting backport for target branches: 8.19, 9.1, 9.2 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 22, 2025
…ore and setting time range (elastic#239992) Closes elastic#239962 The issue was caused because `timeRestore$` is used in comparators but was not part of `startComparing$` subscription. The unsaved changes badge would remain because `startComparing$` from unifiedSearchManager would not emit after `timeRestore$` was reset. Issue resolved by adding `timeRestore$` to `startComparing$` subscription. Now `timeRestore$` emit will cause `startComparing$` to emit with freshly calculated values. (cherry picked from commit 6a78829)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 22, 2025
…ore and setting time range (elastic#239992) Closes elastic#239962 The issue was caused because `timeRestore$` is used in comparators but was not part of `startComparing$` subscription. The unsaved changes badge would remain because `startComparing$` from unifiedSearchManager would not emit after `timeRestore$` was reset. Issue resolved by adding `timeRestore$` to `startComparing$` subscription. Now `timeRestore$` emit will cause `startComparing$` to emit with freshly calculated values. (cherry picked from commit 6a78829)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 22, 2025
…ore and setting time range (elastic#239992) Closes elastic#239962 The issue was caused because `timeRestore$` is used in comparators but was not part of `startComparing$` subscription. The unsaved changes badge would remain because `startComparing$` from unifiedSearchManager would not emit after `timeRestore$` was reset. Issue resolved by adding `timeRestore$` to `startComparing$` subscription. Now `timeRestore$` emit will cause `startComparing$` to emit with freshly calculated values. (cherry picked from commit 6a78829)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This was referenced Oct 22, 2025
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Oct 22, 2025
…ore and setting time range (elastic#239992) Closes elastic#239962 The issue was caused because `timeRestore$` is used in comparators but was not part of `startComparing$` subscription. The unsaved changes badge would remain because `startComparing$` from unifiedSearchManager would not emit after `timeRestore$` was reset. Issue resolved by adding `timeRestore$` to `startComparing$` subscription. Now `timeRestore$` emit will cause `startComparing$` to emit with freshly calculated values. (cherry picked from commit 6a78829)
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Oct 22, 2025
…ore and setting time range (elastic#239992) Closes elastic#239962 The issue was caused because `timeRestore$` is used in comparators but was not part of `startComparing$` subscription. The unsaved changes badge would remain because `startComparing$` from unifiedSearchManager would not emit after `timeRestore$` was reset. Issue resolved by adding `timeRestore$` to `startComparing$` subscription. Now `timeRestore$` emit will cause `startComparing$` to emit with freshly calculated values. (cherry picked from commit 6a78829)
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Oct 22, 2025
…ore and setting time range (elastic#239992) Closes elastic#239962 The issue was caused because `timeRestore$` is used in comparators but was not part of `startComparing$` subscription. The unsaved changes badge would remain because `startComparing$` from unifiedSearchManager would not emit after `timeRestore$` was reset. Issue resolved by adding `timeRestore$` to `startComparing$` subscription. Now `timeRestore$` emit will cause `startComparing$` to emit with freshly calculated values. (cherry picked from commit 6a78829)
nreese
added a commit
that referenced
this pull request
Oct 23, 2025
…meRestore and setting time range (#239992) (#240142) # Backport This will backport the following commits from `main` to `9.2`: - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](#239992) <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-10-22T14:15:37Z","message":"[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)\n\nCloses https://github.com/elastic/kibana/issues/239962\n\nThe issue was caused because `timeRestore# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT is used in comparators but\nwas not part of `startComparing# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT subscription. The unsaved changes\nbadge would remain because `startComparing# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT from unifiedSearchManager\nwould not emit after `timeRestore# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT was reset.\n\nIssue resolved by adding `timeRestore# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT to `startComparing# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT \nsubscription. Now `timeRestore# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT emit will cause `startComparing# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT to\nemit with freshly calculated values.","sha":"6a78829c23466aca4451ca2d12558a56a76def2f","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","backport:version","v9.2.0","v9.3.0","v9.1.6","v8.19.6"],"title":"[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range","number":239992,"url":"https://github.com/elastic/kibana/pull/239992","mergeCommit":{"message":"[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)\n\nCloses https://github.com/elastic/kibana/issues/239962\n\nThe issue was caused because `timeRestore# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT is used in comparators but\nwas not part of `startComparing# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT subscription. The unsaved changes\nbadge would remain because `startComparing# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT from unifiedSearchManager\nwould not emit after `timeRestore# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT was reset.\n\nIssue resolved by adding `timeRestore# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT to `startComparing# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT \nsubscription. Now `timeRestore# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT emit will cause `startComparing# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT to\nemit with freshly calculated values.","sha":"6a78829c23466aca4451ca2d12558a56a76def2f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/240112","number":240112,"state":"OPEN"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/239992","number":239992,"mergeCommit":{"message":"[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)\n\nCloses https://github.com/elastic/kibana/issues/239962\n\nThe issue was caused because `timeRestore# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT is used in comparators but\nwas not part of `startComparing# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT subscription. The unsaved changes\nbadge would remain because `startComparing# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT from unifiedSearchManager\nwould not emit after `timeRestore# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT was reset.\n\nIssue resolved by adding `timeRestore# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT to `startComparing# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT \nsubscription. Now `timeRestore# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT emit will cause `startComparing# Backport This will backport the following commits from `main` to `9.2`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT to\nemit with freshly calculated values.","sha":"6a78829c23466aca4451ca2d12558a56a76def2f"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/240111","number":240111,"state":"OPEN"},{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/240110","number":240110,"state":"OPEN"}]}] BACKPORT-->
nreese
added a commit
that referenced
this pull request
Oct 23, 2025
…meRestore and setting time range (#239992) (#240143) # Backport This will backport the following commits from `main` to `9.1`: - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](#239992) <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-10-22T14:15:37Z","message":"[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)\n\nCloses https://github.com/elastic/kibana/issues/239962\n\nThe issue was caused because `timeRestore# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT is used in comparators but\nwas not part of `startComparing# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT subscription. The unsaved changes\nbadge would remain because `startComparing# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT from unifiedSearchManager\nwould not emit after `timeRestore# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT was reset.\n\nIssue resolved by adding `timeRestore# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT to `startComparing# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT \nsubscription. Now `timeRestore# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT emit will cause `startComparing# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT to\nemit with freshly calculated values.","sha":"6a78829c23466aca4451ca2d12558a56a76def2f","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","backport:version","v9.2.0","v9.3.0","v9.1.6","v8.19.6"],"title":"[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range","number":239992,"url":"https://github.com/elastic/kibana/pull/239992","mergeCommit":{"message":"[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)\n\nCloses https://github.com/elastic/kibana/issues/239962\n\nThe issue was caused because `timeRestore# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT is used in comparators but\nwas not part of `startComparing# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT subscription. The unsaved changes\nbadge would remain because `startComparing# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT from unifiedSearchManager\nwould not emit after `timeRestore# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT was reset.\n\nIssue resolved by adding `timeRestore# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT to `startComparing# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT \nsubscription. Now `timeRestore# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT emit will cause `startComparing# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT to\nemit with freshly calculated values.","sha":"6a78829c23466aca4451ca2d12558a56a76def2f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/240112","number":240112,"state":"OPEN"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/239992","number":239992,"mergeCommit":{"message":"[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)\n\nCloses https://github.com/elastic/kibana/issues/239962\n\nThe issue was caused because `timeRestore# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT is used in comparators but\nwas not part of `startComparing# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT subscription. The unsaved changes\nbadge would remain because `startComparing# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT from unifiedSearchManager\nwould not emit after `timeRestore# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT was reset.\n\nIssue resolved by adding `timeRestore# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT to `startComparing# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT \nsubscription. Now `timeRestore# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT emit will cause `startComparing# Backport This will backport the following commits from `main` to `9.1`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT to\nemit with freshly calculated values.","sha":"6a78829c23466aca4451ca2d12558a56a76def2f"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/240111","number":240111,"state":"OPEN"},{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/240110","number":240110,"state":"OPEN"}]}] BACKPORT--> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
nreese
added a commit
that referenced
this pull request
Oct 23, 2025
…imeRestore and setting time range (#239992) (#240144) # Backport This will backport the following commits from `main` to `8.19`: - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](#239992) <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-10-22T14:15:37Z","message":"[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)\n\nCloses https://github.com/elastic/kibana/issues/239962\n\nThe issue was caused because `timeRestore# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT is used in comparators but\nwas not part of `startComparing# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT subscription. The unsaved changes\nbadge would remain because `startComparing# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT from unifiedSearchManager\nwould not emit after `timeRestore# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT was reset.\n\nIssue resolved by adding `timeRestore# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT to `startComparing# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT \nsubscription. Now `timeRestore# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT emit will cause `startComparing# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT to\nemit with freshly calculated values.","sha":"6a78829c23466aca4451ca2d12558a56a76def2f","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","backport:version","v9.2.0","v9.3.0","v9.1.6","v8.19.6"],"title":"[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range","number":239992,"url":"https://github.com/elastic/kibana/pull/239992","mergeCommit":{"message":"[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)\n\nCloses https://github.com/elastic/kibana/issues/239962\n\nThe issue was caused because `timeRestore# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT is used in comparators but\nwas not part of `startComparing# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT subscription. The unsaved changes\nbadge would remain because `startComparing# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT from unifiedSearchManager\nwould not emit after `timeRestore# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT was reset.\n\nIssue resolved by adding `timeRestore# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT to `startComparing# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT \nsubscription. Now `timeRestore# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT emit will cause `startComparing# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT to\nemit with freshly calculated values.","sha":"6a78829c23466aca4451ca2d12558a56a76def2f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/240112","number":240112,"state":"OPEN"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/239992","number":239992,"mergeCommit":{"message":"[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)\n\nCloses https://github.com/elastic/kibana/issues/239962\n\nThe issue was caused because `timeRestore# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT is used in comparators but\nwas not part of `startComparing# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT subscription. The unsaved changes\nbadge would remain because `startComparing# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT from unifiedSearchManager\nwould not emit after `timeRestore# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT was reset.\n\nIssue resolved by adding `timeRestore# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT to `startComparing# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT \nsubscription. Now `timeRestore# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT emit will cause `startComparing# Backport This will backport the following commits from `main` to `8.19`: {{{{raw}}}} - [[dashboard] fix unable to reset unsaved change when enabling timeRestore and setting time range (#239992)](https://github.com/elastic/kibana/pull/239992){{{{/raw}}}} <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT to\nemit with freshly calculated values.","sha":"6a78829c23466aca4451ca2d12558a56a76def2f"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/240111","number":240111,"state":"OPEN"},{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/240110","number":240110,"state":"OPEN"}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #239962
The issue was caused because
timeRestore$is used in comparators but was not part ofstartComparing$subscription. The unsaved changes badge would remain becausestartComparing$from unifiedSearchManager would not emit aftertimeRestore$was reset.Issue resolved by adding
timeRestore$tostartComparing$subscription. NowtimeRestore$emit will causestartComparing$to emit with freshly calculated values.