Skip to content

[Search] fix v2 solution nav search icons#240475

Merged
TattdCodeMonkey merged 2 commits intoelastic:mainfrom
TattdCodeMonkey:fix/nav-v2-icons-dark-mode
Oct 25, 2025
Merged

[Search] fix v2 solution nav search icons#240475
TattdCodeMonkey merged 2 commits intoelastic:mainfrom
TattdCodeMonkey:fix/nav-v2-icons-dark-mode

Conversation

@TattdCodeMonkey
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey commented Oct 24, 2025 •
edited by kibanamachine
Loading

Summary

Moved the agents and playground icons for the v2 solution navigation to lazy loaded components while also resolving an issue where they were not rendered correctly in dark mode.

Before:
image

After:
image

Checklist

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Release note

Fixes Agents & Playground icons in the solution side navigation to render correctly when using dark mode
@TattdCodeMonkey TattdCodeMonkey requested a review from a team as a code owner October 24, 2025 15:29
seialkali
seialkali approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@seialkali seialkali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! 💥
Samiul-TheSoccerFan
Samiul-TheSoccerFan approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@Samiul-TheSoccerFan Samiul-TheSoccerFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work. I will update workplace ai to make sure we can take advantage of the same icons and lazy loading.
@TattdCodeMonkey TattdCodeMonkey requested a review from a team as a code owner October 24, 2025 18:48
@TattdCodeMonkey TattdCodeMonkey enabled auto-merge (squash) October 24, 2025 19:49
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 24, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
searchGettingStarted 235 237 +2
searchHomepage 255 257 +2
searchIndices 335 337 +2
searchPlayground 427 429 +2
total +8

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/search-shared-ui 11 15 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 950.9KB 948.9KB -2.0KB
searchHomepage 147.5KB 147.5KB -8.0B
searchIndices 194.5KB 194.5KB -1.0B
serverlessSearch 169.5KB 177.7KB +8.2KB
total +6.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
enterpriseSearch 33.3KB 37.1KB +3.8KB
searchIndices 8.9KB 8.9KB -1.0B
serverlessSearch 29.9KB 27.9KB -2.0KB
total +1.8KB
Unknown metric groups

API count

id before after diff
@kbn/search-shared-ui 11 15 +4

async chunk count

id before after diff
serverlessSearch 5 7 +2

History
@TattdCodeMonkey TattdCodeMonkey merged commit d31b0db into elastic:main Oct 25, 2025
13 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 25, 2025

Starting backport for target branches: 9.2

https://github.com/elastic/kibana/actions/runs/18796296753
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 25, 2025

💔 All backports failed

Status Branch Result
❌ 9.2 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 240475

Questions ?

Please refer to the Backport tool documentation
@TattdCodeMonkey TattdCodeMonkey mentioned this pull request Oct 27, 2025
Merged
@TattdCodeMonkey
Copy link
Contributor Author

TattdCodeMonkey commented Oct 27, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation
TattdCodeMonkey added a commit to TattdCodeMonkey/kibana that referenced this pull request Oct 27, 2025
@TattdCodeMonkey
[Search] fix v2 solution nav search icons (elastic#240475)
4a9c3d2 
## Summary

Moved the agents and playground icons for the v2 solution navigation to
lazy loaded components while also resolving an issue where they were not
rendered correctly in dark mode.

Before:
<img width="94" height="478" alt="image"
src="https://github.com/user-attachments/assets/3331cea7-5fe7-4bf6-9de5-2674132ba12c"
/>

After:
<img width="115" height="488" alt="image"
src="https://github.com/user-attachments/assets/d3352a9b-3c73-4461-b5cd-fb5383ed8ddf"
/>

### Checklist

- [ ] ~Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~
- [ ]
~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials~
- [ ] ~[Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios~
- [ ] ~If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~
- [ ] ~This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.~
- [ ] ~[Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed~
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

## Release note

Fixes Agents & Playground icons in the solution side navigation to
render correctly when using dark mode

(cherry picked from commit d31b0db)

# Conflicts:
#	packages/kbn-optimizer/limits.yml
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 28, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 28, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @TattdCodeMonkey
TattdCodeMonkey added a commit to TattdCodeMonkey/kibana that referenced this pull request Oct 28, 2025
@TattdCodeMonkey
[Search] fix v2 solution nav search icons (elastic#240475)
5d6c012 
## Summary

Moved the agents and playground icons for the v2 solution navigation to
lazy loaded components while also resolving an issue where they were not
rendered correctly in dark mode.

Before:
<img width="94" height="478" alt="image"
src="https://github.com/user-attachments/assets/3331cea7-5fe7-4bf6-9de5-2674132ba12c"
/>

After:
<img width="115" height="488" alt="image"
src="https://github.com/user-attachments/assets/d3352a9b-3c73-4461-b5cd-fb5383ed8ddf"
/>

### Checklist

- [ ] ~Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~
- [ ]
~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials~
- [ ] ~[Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios~
- [ ] ~If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~
- [ ] ~This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.~
- [ ] ~[Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed~
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

## Release note

Fixes Agents & Playground icons in the solution side navigation to
render correctly when using dark mode

(cherry picked from commit d31b0db)

# Conflicts:
#	packages/kbn-optimizer/limits.yml
TattdCodeMonkey added a commit that referenced this pull request Oct 28, 2025
@TattdCodeMonkey
[9.2] [Search] fix v2 solution nav search icons (#240475) (#240820)
fd6f103 
# Backport

This will backport the following commits from `main` to `9.2`:
- [[Search] fix v2 solution nav search icons
(#240475)](#240475)

<!--- Backport version: 10.1.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Rodney
Norris","email":"rodney.norris@elastic.co"},"sourceCommit":{"committedDate":"2025-10-25T01:37:58Z","message":"[Search]
fix v2 solution nav search icons (#240475)\n\n## Summary\n\nMoved the
agents and playground icons for the v2 solution navigation to\nlazy
loaded components while also resolving an issue where they were
not\nrendered correctly in dark mode.\n\nBefore:\n<img width=\"94\"
height=\"478\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/3331cea7-5fe7-4bf6-9de5-2674132ba12c\"\n/>\n\nAfter:\n<img
width=\"115\" height=\"488\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/d3352a9b-3c73-4461-b5cd-fb5383ed8ddf\"\n/>\n\n###
Checklist\n\n- [ ] ~Any text added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~\n-
[
]\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas
added for features that require explanation or tutorials~\n- [ ] ~[Unit
or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios~\n- [ ] ~If a plugin
configuration key changed, check if it needs to be\nallowlisted in the
cloud and added to the
[docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\n-
[ ] ~This was checked for breaking HTTP API changes, and any
breaking\nchanges have been approved by the breaking-change committee.
The\n`release_note:breaking` label should be applied in these
situations.~\n- [ ] ~[Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed~\n- [x] The PR description includes the
appropriate Release Notes section,\nand the correct `release_note:*`
label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n-
[x] Review the
[backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand
apply applicable `backport:*` labels.\n\n## Release note\n\nFixes Agents
& Playground icons in the solution side navigation to\nrender correctly
when using dark
mode","sha":"d31b0dbabf229bb839c1c0140ac6a65c880dfd6a","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Search","backport:version","v9.3.0","v9.2.1"],"title":"[Search]
fix v2 solution nav search
icons","number":240475,"url":"https://github.com/elastic/kibana/pull/240475","mergeCommit":{"message":"[Search]
fix v2 solution nav search icons (#240475)\n\n## Summary\n\nMoved the
agents and playground icons for the v2 solution navigation to\nlazy
loaded components while also resolving an issue where they were
not\nrendered correctly in dark mode.\n\nBefore:\n<img width=\"94\"
height=\"478\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/3331cea7-5fe7-4bf6-9de5-2674132ba12c\"\n/>\n\nAfter:\n<img
width=\"115\" height=\"488\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/d3352a9b-3c73-4461-b5cd-fb5383ed8ddf\"\n/>\n\n###
Checklist\n\n- [ ] ~Any text added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~\n-
[
]\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas
added for features that require explanation or tutorials~\n- [ ] ~[Unit
or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios~\n- [ ] ~If a plugin
configuration key changed, check if it needs to be\nallowlisted in the
cloud and added to the
[docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\n-
[ ] ~This was checked for breaking HTTP API changes, and any
breaking\nchanges have been approved by the breaking-change committee.
The\n`release_note:breaking` label should be applied in these
situations.~\n- [ ] ~[Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed~\n- [x] The PR description includes the
appropriate Release Notes section,\nand the correct `release_note:*`
label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n-
[x] Review the
[backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand
apply applicable `backport:*` labels.\n\n## Release note\n\nFixes Agents
& Playground icons in the solution side navigation to\nrender correctly
when using dark
mode","sha":"d31b0dbabf229bb839c1c0140ac6a65c880dfd6a"}},"sourceBranch":"main","suggestedTargetBranches":["9.2"],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/240475","number":240475,"mergeCommit":{"message":"[Search]
fix v2 solution nav search icons (#240475)\n\n## Summary\n\nMoved the
agents and playground icons for the v2 solution navigation to\nlazy
loaded components while also resolving an issue where they were
not\nrendered correctly in dark mode.\n\nBefore:\n<img width=\"94\"
height=\"478\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/3331cea7-5fe7-4bf6-9de5-2674132ba12c\"\n/>\n\nAfter:\n<img
width=\"115\" height=\"488\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/d3352a9b-3c73-4461-b5cd-fb5383ed8ddf\"\n/>\n\n###
Checklist\n\n- [ ] ~Any text added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~\n-
[
]\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas
added for features that require explanation or tutorials~\n- [ ] ~[Unit
or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios~\n- [ ] ~If a plugin
configuration key changed, check if it needs to be\nallowlisted in the
cloud and added to the
[docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\n-
[ ] ~This was checked for breaking HTTP API changes, and any
breaking\nchanges have been approved by the breaking-change committee.
The\n`release_note:breaking` label should be applied in these
situations.~\n- [ ] ~[Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed~\n- [x] The PR description includes the
appropriate Release Notes section,\nand the correct `release_note:*`
label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n-
[x] Review the
[backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand
apply applicable `backport:*` labels.\n\n## Release note\n\nFixes Agents
& Playground icons in the solution side navigation to\nrender correctly
when using dark
mode","sha":"d31b0dbabf229bb839c1c0140ac6a65c880dfd6a"}},{"branch":"9.2","label":"v9.2.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment