[ES|QL] Support Expressions in Lookup Join Autocomplete#240735
[ES|QL] Support Expressions in Lookup Join Autocomplete#240735bartoval merged 5 commits intoelastic:mainfrom
Conversation
| }); | ||
|
|
||
| // Filter out AS operator - it's not valid in boolean expressions | ||
| const filteredSuggestions = suggestions.filter(({ label }) => label !== 'AS'); |
There was a problem hiding this comment.
AS uses location.JOIN but should not be suggested within ON.
A manual filter is sufficient for this specific case, instead of creating a new Location.JOIN_ON
bartoval
added
release_note:skip
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
added
release_note:enhancement
and removed
release_note:skip
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
Code review seems great, just a comment on the suggestions
Thanx Val!
There was a problem hiding this comment.
Here we should also suggest | and comma as they are also a valid option
This is how it looks in main
We should have these + the expressions
There was a problem hiding this comment.
mmm 🤔💭... if you press run, does the query fail?
if I haven't misunderstood the grammar, we now support only Boolean expressions according to the grammar and in this case, we only have the left operand. In that case we don't have to close the statement
There was a problem hiding this comment.
Yes it runs. The expressions is an enhancement. We never break existing syntax
There was a problem hiding this comment.
You are right. Thanks.
Added support for common fields
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
Me gusta mucho!! Gracias
Do we need to do anything on validation side?
In theory yes. since we support boolean expressions inside ON (same case as Rerank). |
💚 Build Succeeded
Metrics [docs]Page load bundle
Unknown metric groupsESLint disabled in files
Total ESLint disabled count
cc @bartoval |
3 participants
Summary
This is part of #236939
suggestForExpressioninstead ofgetFieldSuggestions, along with a couple utilities to enrich its context with join indices (including the logic to check common columns) .ONpart, we updated getPosition similar with other AST-based implementations.