[8.19] [Rules] Fixed infinite loop bug in investigation guide editor (#240472)#241068
Merged
kibanamachine merged 2 commits intoelastic:8.19from Oct 29, 2025
Merged
Conversation
…c#240472) When `length > MAX_ARTIFACTS_INVESTIGATION_GUIDE_LENGTH` this code was constantly setting a new `errorMessages` causing a `Maximum update depth exceeded` error. In this PR we also set a new value for `MAX_ARTIFACTS_INVESTIGATION_GUIDE_LENGTH`. ``` const [errorMessages, setErrorMessages] = React.useState<string[]>([]); const onParse = useCallback( (_: EuiMarkdownParseError | null, { ast }: { ast: EuiMarkdownAstNode }) => { const length = ast.position?.end.offset ?? 0; if (length > MAX_ARTIFACTS_INVESTIGATION_GUIDE_LENGTH) { setErrorMessages([ i18n.translate('responseOpsRuleForm.investigationGuide.editor.errorMessage', { defaultMessage: 'The Investigation Guide is too long. Please shorten it.\nCurrent length: {length}.\nMax length: {maxLength}.', values: { length, maxLength: MAX_ARTIFACTS_INVESTIGATION_GUIDE_LENGTH }, }), ]); } else if (errorMessages.length) { setErrorMessages([]); } }, [errorMessages] ); ``` Before: https://github.com/user-attachments/assets/5a07984c-f9bf-4938-b31b-c4375558dca9 After: https://github.com/user-attachments/assets/a7f1f132-6e1f-41df-9320-6a0abe2041a4 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 4e74c80)
![github-actions[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
cc @cesco-f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation