Skip to content

[Discover] Fix truncation for longer text in table #241440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akowalska622 merged 10 commits into from
Nov 11, 2025
Merged

[Discover] Fix truncation for longer text in table #241440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ee2f8f3
add eui-textTruncate classname to in-table-search div
akowalska622 Oct 31, 2025
a0f4b87
Merge branch 'main' into discover-fix-one-line-truncation
akowalska622 Oct 31, 2025
75cdde8
add truncation only for one line
akowalska622 Oct 31, 2025
969ef37
Merge branch 'discover-fix-one-line-truncation' of github.com:elastic…
akowalska622 Oct 31, 2025
060a78b
remove unused import
akowalska622 Oct 31, 2025
bd14d1a
Merge branch 'main' into discover-fix-one-line-truncation
akowalska622 Nov 3, 2025
6ddd39b
Merge branch 'main' into discover-fix-one-line-truncation
akowalska622 Nov 4, 2025
70e7b4a
Merge branch 'main' into discover-fix-one-line-truncation
akowalska622 Nov 5, 2025
de67ea3
replace in table search div with a span
akowalska622 Nov 10, 2025
00a02cf
Merge branch 'main' into discover-fix-one-line-truncation
akowalska622 Nov 10, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions ...ages/shared/kbn-data-grid-in-table-search/src/in_table_search_highlights_wrapper.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ describe('InTableSearchHighlightsWrapper', () => {
});

expect(container.innerHTML).toMatchInlineSnapshot(
`"<div><div>Some text here with <mark style=\\"color: black; background-color: green;\\" class=\\"dataGridInTableSearch__match\\" data-match-index=\\"0\\">test</mark> and <mark style=\\"color: black; background-color: green;\\" class=\\"dataGridInTableSearch__match\\" data-match-index=\\"1\\">test</mark> and even more <mark style=\\"color: black; background-color: green;\\" class=\\"dataGridInTableSearch__match\\" data-match-index=\\"2\\">Test</mark> to be sure<div><mark style=\\"color: black; background-color: green;\\" class=\\"dataGridInTableSearch__match\\" data-match-index=\\"3\\">test</mark></div><div>this</div><img src=\\"https://test.com\\" alt=\\"not for test\\"></div></div>"`
`"<span><div>Some text here with <mark style=\\"color: black; background-color: green;\\" class=\\"dataGridInTableSearch__match\\" data-match-index=\\"0\\">test</mark> and <mark style=\\"color: black; background-color: green;\\" class=\\"dataGridInTableSearch__match\\" data-match-index=\\"1\\">test</mark> and even more <mark style=\\"color: black; background-color: green;\\" class=\\"dataGridInTableSearch__match\\" data-match-index=\\"2\\">Test</mark> to be sure<div><mark style=\\"color: black; background-color: green;\\" class=\\"dataGridInTableSearch__match\\" data-match-index=\\"3\\">test</mark></div><div>this</div><img src=\\"https://test.com\\" alt=\\"not for test\\"></div></span>"`
);
});

Expand All @@ -52,7 +52,7 @@ describe('InTableSearchHighlightsWrapper', () => {
});

expect(container.innerHTML).toMatchInlineSnapshot(
`"<div><div><mark style=\\"color: black; background-color: green;\\" class=\\"dataGridInTableSearch__match\\" data-match-index=\\"0\\">test2</mark></div></div>"`
`"<span><div><mark style=\\"color: black; background-color: green;\\" class=\\"dataGridInTableSearch__match\\" data-match-index=\\"0\\">test2</mark></div></span>"`
);
});

Expand All @@ -63,7 +63,7 @@ describe('InTableSearchHighlightsWrapper', () => {
</InTableSearchHighlightsWrapper>
);

expect(container.innerHTML).toMatchInlineSnapshot(`"<div><div>test2</div></div>"`);
expect(container.innerHTML).toMatchInlineSnapshot(`"<span><div>test2</div></span>"`);
});

it('escape the input with tags', async () => {
Expand All @@ -82,7 +82,7 @@ describe('InTableSearchHighlightsWrapper', () => {
});

expect(container.innerHTML).toMatchInlineSnapshot(
`"<div><div><hr><div>test</div><div>this <mark style=\\"color: black; background-color: green;\\" class=\\"dataGridInTableSearch__match\\" data-match-index=\\"0\\">&lt;hr /&gt;</mark></div></div></div>"`
`"<span><div><hr><div>test</div><div>this <mark style=\\"color: black; background-color: green;\\" class=\\"dataGridInTableSearch__match\\" data-match-index=\\"0\\">&lt;hr /&gt;</mark></div></div></span>"`
);
});

Expand All @@ -98,7 +98,7 @@ describe('InTableSearchHighlightsWrapper', () => {
});

expect(container.innerHTML).toMatchInlineSnapshot(
`"<div><div>test this now<mark style=\\"color: black; background-color: green;\\" class=\\"dataGridInTableSearch__match\\" data-match-index=\\"0\\">.</mark></div></div>"`
`"<span><div>test this now<mark style=\\"color: black; background-color: green;\\" class=\\"dataGridInTableSearch__match\\" data-match-index=\\"0\\">.</mark></div></span>"`
);
});

Expand All @@ -109,7 +109,7 @@ describe('InTableSearchHighlightsWrapper', () => {
</InTableSearchHighlightsWrapper>
);

expect(container.innerHTML).toMatchInlineSnapshot(`"<div><div>test</div></div>"`);
expect(container.innerHTML).toMatchInlineSnapshot(`"<span><div>test</div></span>"`);
});
});

Expand All @@ -136,7 +136,7 @@ describe('InTableSearchHighlightsWrapper', () => {
});

expect(container.innerHTML).toMatchInlineSnapshot(
`"<div><div>Some text here with test and test and even more Test to be sure<div>test</div><div>this</div><img src=\\"https://test.com\\" alt=\\"not for test\\"></div></div>"`
`"<span><div>Some text here with test and test and even more Test to be sure<div>test</div><div>this</div><img src=\\"https://test.com\\" alt=\\"not for test\\"></div></span>"`
);
});

Expand All @@ -157,7 +157,7 @@ describe('InTableSearchHighlightsWrapper', () => {
expect(onHighlightsCountFound).toHaveBeenCalledWith(1);
});

expect(container.innerHTML).toMatchInlineSnapshot(`"<div><div>test2</div></div>"`);
expect(container.innerHTML).toMatchInlineSnapshot(`"<span><div>test2</div></span>"`);
});

it('with no matches', async () => {
Expand All @@ -176,7 +176,7 @@ describe('InTableSearchHighlightsWrapper', () => {
expect(onHighlightsCountFound).toHaveBeenCalledWith(0);
});

expect(container.innerHTML).toMatchInlineSnapshot(`"<div><div>test2</div></div>"`);
expect(container.innerHTML).toMatchInlineSnapshot(`"<span><div>test2</div></span>"`);
});

it('with no search term', async () => {
Expand All @@ -187,7 +187,7 @@ describe('InTableSearchHighlightsWrapper', () => {
</InTableSearchHighlightsWrapper>
);

expect(container.innerHTML).toMatchInlineSnapshot(`"<div><div>test</div></div>"`);
expect(container.innerHTML).toMatchInlineSnapshot(`"<span><div>test</div></span>"`);
expect(onHighlightsCountFound).not.toHaveBeenCalled();
});
});
Expand Down
2 changes: 1 addition & 1 deletion .../packages/shared/kbn-data-grid-in-table-search/src/in_table_search_highlights_wrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export const InTableSearchHighlightsWrapper: React.FC<InTableSearchHighlightsWra
onHighlightsCountFound,
]);

return <div ref={cellValueRef}>{children}</div>;
return <span ref={cellValueRef}>{children}</span>;
};

const searchTermRegExpCache = new Map<string, RegExp>();
Expand Down