[ResponseOps][Maintenance Window] Timezone field disappears when specific timezone is selected #241574
Conversation
georgianaonoleata1904
added
bug
|
Pinging @elastic/response-ops (Team:ResponseOps) |
georgianaonoleata1904
added
the
release_note:skip
...lerting/public/pages/maintenance_windows/components/create_maintenance_windows_form.test.tsx
Outdated
Show resolved
Hide resolved
| const [defaultEndDateValue] = useState<string>(moment().add(30, 'minutes').toISOString()); | ||
| const [isModalVisible, setIsModalVisible] = useState(false); | ||
| const { defaultTimezone, isBrowser } = useDefaultTimezone(); | ||
| const { defaultTimezone } = useDefaultTimezone(); |
There was a problem hiding this comment.
isBrowser comes from a function that is declared in this file and only used here. If that result key is not necessary anymore, we should remove it from the original function, too.
Also, I don't fully understand what isBrowser did in this file. 😅
There was a problem hiding this comment.
removed isBrowser from the hook. I think the original intent was to display the timezone only if it's automatically determined from the user's browser. This is the original PR that introduced the timezone field
| } | ||
|
|
||
| const useDefaultTimezone = () => { | ||
| const kibanaTz: string = useUiSetting('dateFormat:tz'); |
There was a problem hiding this comment.
Could you please add a test for when kibanaTz is undefined?
There was a problem hiding this comment.
done, added the test
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
3 participants
Closes #229132
Summary
timezonefield, ensuring it is always visible on both create and edit Maintenance Window pages, as a timezone is always configured (either Browser or a specific one)