[ML][Inference endpoints creation] Add support for headers in the OpenAI integration#241887
Merged
alvarezmelissa87 merged 1 commit intoelastic:mainfrom Nov 5, 2025
Conversation
alvarezmelissa87
added
release_note:skip
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
💚 Build Succeeded
Metrics [docs]
|
alvarezmelissa87
deleted the
inference-endpoints-creation-schema-update
branch
wildemat
pushed a commit
to wildemat/kibana
that referenced
this pull request
Nov 5, 2025
…nAI integration (elastic#241887) ## Summary This PR is the first part of an effort to add custom header support for OpenAI in the inference endpoints creation UI. Because adding new properties to a schema require a 2 step deployment (see elastic#228371 (comment)), 2 PRs are needed for this. step one - the schema changes in this PR step two - things that can set the config property (so here, the UI) - PR link to be added ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
8 tasks
alvarezmelissa87
added a commit
that referenced
this pull request
Nov 21, 2025
## Summary This PR is the second part of an effort to add custom header support for OpenAI in the inference endpoints creation UI. Because adding new properties to a schema require a 2 step deployment (see #228371 (comment)), 2 PRs are needed for this. step one - the schema changes in #241887 (this PR can't be merged until this is in serverless) step two - things that can set the config property (so here, the UI) - in this PR This PR improves the behavior of the headers input field. - when toggling off the headers switch, headers are no longer removed - the previous behavior was causing confusion - switch label now reads 'Hide headers' when toggled on and 'Add headers' when off (if editing with existing headers, reads 'View headers' when toggled off) - adds duplicate key check and adds error message when duplicate key is detected - headers input field now keeps it's own state (array list for the headers) in order to detect the duplicate keys and the form state is updated onblur and when no duplicates are present. This ensures the form updates only when the user is done typing and cuts down on unnecessary re-renders. https://github.com/user-attachments/assets/53e59c78-4619-4b34-959e-5382a369882c Flaky test runner for updates https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/9818 Flaky test runner after behavior update (last commit) https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/9854 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Dec 2, 2025
…nAI integration (elastic#241887) ## Summary This PR is the first part of an effort to add custom header support for OpenAI in the inference endpoints creation UI. Because adding new properties to a schema require a 2 step deployment (see elastic#228371 (comment)), 2 PRs are needed for this. step one - the schema changes in this PR step two - things that can set the config property (so here, the UI) - PR link to be added ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Dec 2, 2025
…#242187) ## Summary This PR is the second part of an effort to add custom header support for OpenAI in the inference endpoints creation UI. Because adding new properties to a schema require a 2 step deployment (see elastic#228371 (comment)), 2 PRs are needed for this. step one - the schema changes in elastic#241887 (this PR can't be merged until this is in serverless) step two - things that can set the config property (so here, the UI) - in this PR This PR improves the behavior of the headers input field. - when toggling off the headers switch, headers are no longer removed - the previous behavior was causing confusion - switch label now reads 'Hide headers' when toggled on and 'Add headers' when off (if editing with existing headers, reads 'View headers' when toggled off) - adds duplicate key check and adds error message when duplicate key is detected - headers input field now keeps it's own state (array list for the headers) in order to detect the duplicate keys and the form state is updated onblur and when no duplicates are present. This ensures the form updates only when the user is done typing and cuts down on unnecessary re-renders. https://github.com/user-attachments/assets/53e59c78-4619-4b34-959e-5382a369882c Flaky test runner for updates https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/9818 Flaky test runner after behavior update (last commit) https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/9854 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the first part of an effort to add custom header support for OpenAI in the inference endpoints creation UI.
Because adding new properties to a schema require a 2 step deployment (see #228371 (comment)), 2 PRs are needed for this.
step one - the schema changes in this PR
step two - things that can set the config property (so here, the UI) - PR here #242187
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.