[Background search] Enable by default#242105
Conversation
9f2ddae to
3f002ce
Compare
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Cloud deployment initiated, see credentials at: https://buildkite.com/elastic/kibana-deploy-cloud-from-pr/builds/559 |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
/oblt-deploy |
|
Confirmed with the oblt serverless deploy + cloud deploy that it's enabled with this changes |
3f002ce to
c9ec9d5
Compare
| import type { WebElementWrapper } from '@kbn/ftr-common-functional-ui-services'; | ||
| import type { SavedObjectsFindResponse } from '@kbn/core/server'; | ||
| import { FtrService } from '@kbn/test-suites-src/functional/ftr_provider_context'; | ||
| import { FtrService } from '../ftr_provider_context'; |
There was a problem hiding this comment.
i've moved this from the x-pack functional services folder to the base functional services so I can reuse it in the serverless tests - happy to do it in some other way if this is not ideal
| 'svlCommonPage', | ||
| ]); | ||
|
|
||
| describe('Discover background search', function () { |
There was a problem hiding this comment.
i can't do a real test of storing/recovering a background search because delay can't be used in ESQL in this tests and stall_time_seconds can be used in classic either so i'm just adding some basic tests to ensure that the feature is present
There was a problem hiding this comment.
Hmm, makes sense... this is a real bummer, maybe we can bring this up to the team and see if there are any options here.
There was a problem hiding this comment.
To quickly follow up, we might get support from ES side here, so we should be able to treat serverless and stateful the same way
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
|
🥳 @AlexGPlay I think with this PR we should do another round of testing then @ninoslavmiskovic @lukasolson, also checking for serverless |
jeramysoucy
left a comment
There was a problem hiding this comment.
Kibana security changes LGTM
lukasolson
left a comment
There was a problem hiding this comment.
LGTM, did some testing on the provided instance but it was limited for the same reason we are missing a functional test here to verify actual saving/loading. Let's bring this up with the team and see if there are any other options.
.github/CODEOWNERS
Outdated
| /src/platform/test/functional/services/field_editor.ts @elastic/kibana-data-discovery | ||
| /src/platform/test/functional/services/embedding.ts @elastic/appex-qa | ||
| /src/platform/test/functional/services/data_grid.ts @elastic/kibana-data-discovery | ||
| /src/platform/test/functional/services/search_sessions.ts @elastic/search-kibana |
There was a problem hiding this comment.
This is odd, shouldn't this be our team? I don't know why it was search before.
There was a problem hiding this comment.
yeah, that seemed weird - i can reassign that to us if it makes sense
There was a problem hiding this comment.
Yes, I think it makes sense to reassign to us
|
|
||
| for (const privilege of subFeaturesPrivileges.values()) { | ||
| if (privilege.id === 'store_search_session') expect(privilege.disabled).not.toBe(true); | ||
| else expect(privilege.disabled).toBe(true); |
There was a problem hiding this comment.
Is this an explicit decision we made to show this privilege? It probably makes sense, just wanted to make sure.
| 'svlCommonPage', | ||
| ]); | ||
|
|
||
| describe('Discover background search', function () { |
There was a problem hiding this comment.
Hmm, makes sense... this is a real bummer, maybe we can bring this up to the team and see if there are any options here.
jloleysens
left a comment
There was a problem hiding this comment.
config/serverless.yaml LGTM
pheyos
left a comment
There was a problem hiding this comment.
Test service relocation and serverless test config changes LGTM
⏳ Build in-progress
Failed CI StepsTest Failures
History
cc @AlexGPlay |
## Summary Closes elastic#236543 Enables by default background search in all the environments. With this we get access by default to the background search feature, this allows users to run long running queries asynchronously while they continue using Kibana normally. <img width="1875" height="971" alt="image" src="https://github.com/user-attachments/assets/fe34fd9d-cc2c-45c8-84d7-4fc76f62f16f" /> Users can also access their backgrounded searches and see the current status of each of them or open them once they are completed. <img width="1875" height="971" alt="image (1)" src="https://github.com/user-attachments/assets/8113b476-4719-4bc1-88b3-bddbc224091d" /> <img width="1878" height="972" alt="image" src="https://github.com/user-attachments/assets/25af3be3-e88e-4e51-aca6-fc21cf1660f2" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
## Summary Closes elastic#236543 Enables by default background search in all the environments. With this we get access by default to the background search feature, this allows users to run long running queries asynchronously while they continue using Kibana normally. <img width="1875" height="971" alt="image" src="https://github.com/user-attachments/assets/fe34fd9d-cc2c-45c8-84d7-4fc76f62f16f" /> Users can also access their backgrounded searches and see the current status of each of them or open them once they are completed. <img width="1875" height="971" alt="image (1)" src="https://github.com/user-attachments/assets/8113b476-4719-4bc1-88b3-bddbc224091d" /> <img width="1878" height="972" alt="image" src="https://github.com/user-attachments/assets/25af3be3-e88e-4e51-aca6-fc21cf1660f2" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
Summary
Closes #236543
Enables by default background search in all the environments.
With this we get access by default to the background search feature, this allows users to run long running queries asynchronously while they continue using Kibana normally.
Users can also access their backgrounded searches and see the current status of each of them or open them once they are completed.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelinesbackport:*labels.