Show partial results after search has been canceled#242346
Show partial results after search has been canceled#242346lukasolson merged 24 commits intoelastic:mainfrom
Conversation
|
Project deployments require a Github label, please add one or more of |
…ana into show_results_after_cancel
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
ThomThomson
left a comment
There was a problem hiding this comment.
Abort controller reason change LGTM!
src/platform/test/functional/apps/discover/ccs_compatibility/_cancel_results.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Does it make sense to add a test to this suite for the cancelled case?
src/platform/packages/shared/kbn-unified-histogram/components/chart/hooks/use_total_hits.ts
Show resolved
Hide resolved
src/platform/packages/shared/kbn-unified-histogram/components/chart/hooks/use_total_hits.ts
Show resolved
Hide resolved
…ana into show_results_after_cancel
...latform/plugins/shared/data/public/search/search_interceptor/search_abort_controller.test.ts
Outdated
Show resolved
Hide resolved
nickofthyme
left a comment
There was a problem hiding this comment.
Vis code change LGTM
drewdaemon
left a comment
There was a problem hiding this comment.
Retested on ES|QL, things seem to work great. Test coverage has improved and I no longer see the undefined requests.
Running the flaky test runner on this one: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/10073 |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10073[❌] src/platform/test/functional/config.ccs.ts: 0/25 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10090[✅] src/platform/test/functional/config.ccs.ts: 25/25 tests passed. |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
cc @lukasolson |


Summary
Resolves #205783.
Resolves #215950.
When a user clicks "Cancel" while a query is running, show the partial results instead of simply canceling the search request.
Before ("cancel" cancels the query and shows empty results):
Screen.Recording.2025-11-10.at.2.12.09.PM.mov
After ("cancel" retrieves the latest results, cancels the query, and shows the results):
Screen.Recording.2025-11-10.at.2.10.23.PM.mov