Skip to content

[8.19] [ResponseOps][Alerts] Fix alerts table pagination resetting when lastReloadRequestTime is used (#242275)#242564

Merged
umbopepato merged 2 commits intoelastic:8.19from
umbopepato:backport/8.19/pr-242275
Nov 13, 2025
Merged

[8.19] [ResponseOps][Alerts] Fix alerts table pagination resetting when lastReloadRequestTime is used (#242275)#242564
umbopepato merged 2 commits intoelastic:8.19from
umbopepato:backport/8.19/pr-242275

Conversation

@umbopepato
Copy link
Member

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

…ReloadRequestTime is used (elastic#242275)

## 📄 Summary

Removes the `refresh` callback from the `lastReloadRequestTime` effect
dependencies to avoid triggering a refresh when the refresh callback
itself changes (like it happened
[here](elastic#241593)).

<details>
<summary>

## 🧪 Verification steps

</summary>

1. Create a rule that fires many alerts (i.e. Security query rule)
2. Wait for the alerts to be generated
3. Navigate to the rule page from Stack Management > Rules
4. Check that the pagination in the alerts table at the bottom of the
page works correctly

</details>

## ⏪ Backport rationale

Backporting to all open versions since this is a bug fix

## Release Notes

Fixes a bug that caused the alerts tables pagination to be stuck in the
Rule pages

## 🔗 References

Fixes elastic#241593

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] ~~Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~
- [ ]
~~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials~~
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] ~~If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~
- [ ] ~~This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.~~
- [ ] ~~[Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed~~
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 722c33e)

# Conflicts:
#	src/platform/packages/shared/response-ops/alerts-table/components/alerts_table.test.tsx
@umbopepato
Copy link
Member Author

Checking the type errors

@umbopepato umbopepato merged commit 2e069cd into elastic:8.19 Nov 13, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Scout Test Run Builder / serverless-security - EUI testing wrapper: EuiDataGrid - data grid, run

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 1.4MB 1.4MB -3.0B
embeddableAlertsTable 974.4KB 974.4KB -3.0B
ml 5.6MB 5.6MB -3.0B
observability 1.4MB 1.4MB -3.0B
securitySolution 9.5MB 9.5MB -3.0B
triggersActionsUi 1.6MB 1.6MB -3.0B
total -18.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/response-ops-alerts-table 10 11 +1

Total ESLint disabled count

id before after diff
@kbn/response-ops-alerts-table 12 13 +1

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

3 participants