Skip to content

[Context Security] fix csp-agnostic regressions #242592

Merged
seanrathier merged 9 commits intoelastic:mainfrom
Omolola-Akinleye:csp-agnostic-for-cloud-connectors
Dec 2, 2025
Merged

[Context Security] fix csp-agnostic regressions #242592
seanrathier merged 9 commits intoelastic:mainfrom
Omolola-Akinleye:csp-agnostic-for-cloud-connectors

Conversation

@Omolola-Akinleye
Copy link
Contributor

Summary

Checking CSP from cloudHost has cause a few regression. In 9.3.0, AWS cloud connectors will support AWS, GCP, Azure clusters. We need to remove the cloud provider host check and logic to ensure All cloud providers for ECH deployments or Serverless projects are supported. This will also help prevent bug regression slipping in to production since we are unable to verify Azure or GCP clusters until Serverless promotion.

@Omolola-Akinleye Omolola-Akinleye self-assigned this Nov 11, 2025
@Omolola-Akinleye Omolola-Akinleye added the Team:Cloud Security Cloud Security team related label Nov 11, 2025
Copy link
Contributor

@amirbenun amirbenun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mockCore.uiSettings.get.mockReturnValue(true);
});

it('enables AWS cloud connector only on AWS host', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many of the tests that you deleted are still relevant - please keep some of them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amirbenun We can refactor the tests to check enablement but we no longer need hosts check test case because we remove hostProvider check.

@Omolola-Akinleye Omolola-Akinleye added ci:cloud-deploy Create or update a Cloud deployment ci:project-deploy-security Create a Security Serverless Project v9.3.0 backport:version Backport to applied version labels release_note:enhancement release_note:feature Makes this part of the condensed release notes labels Nov 12, 2025
@Omolola-Akinleye
Copy link
Contributor Author

/ci

@Omolola-Akinleye
Copy link
Contributor Author

/ci

6 similar comments
@Omolola-Akinleye
Copy link
Contributor Author

/ci

@Omolola-Akinleye
Copy link
Contributor Author

/ci

@Omolola-Akinleye
Copy link
Contributor Author

/ci

@Omolola-Akinleye
Copy link
Contributor Author

/ci

@Omolola-Akinleye
Copy link
Contributor Author

/ci

@Omolola-Akinleye
Copy link
Contributor Author

/ci

@seanrathier seanrathier force-pushed the csp-agnostic-for-cloud-connectors branch from 8064b5f to 4448ca1 Compare December 1, 2025 20:13
@seanrathier seanrathier marked this pull request as ready for review December 1, 2025 20:13
@seanrathier seanrathier requested a review from a team as a code owner December 1, 2025 20:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/contextual-security-apps (Team:Cloud Security)

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 1, 2025

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 643.0KB 642.7KB -286.0B
securitySolution 11.1MB 11.1MB -286.0B
total -572.0B

History

cc @Omolola-Akinleye

Copy link
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested on Kibana hosted in GCP and AWS cloud providers

@seanrathier seanrathier merged commit 3340c42 into elastic:main Dec 2, 2025
14 checks passed
@kibanamachine kibanamachine added backport:skip This PR does not require backporting and removed backport:version Backport to applied version labels labels Dec 2, 2025
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Dec 2, 2025
JordanSh pushed a commit to JordanSh/kibana that referenced this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting ci:cloud-deploy Create or update a Cloud deployment ci:project-deploy-security Create a Security Serverless Project release_note:enhancement release_note:feature Makes this part of the condensed release notes Team:Cloud Security Cloud Security team related v9.3.0

6 participants