[ES|QL] Suggest adding curly braces after the WITH keyword for Rerank and Completion

[bartoval]

Summary

#234488

[elasticmachine]

Pinging @elastic/kibana-esql (Team:ESQL)

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: b8912b5

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/esql-ast	608	609	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
kbnUiSharedDeps-srcJs	4.0MB	4.0MB	+554.0B

Unknown metric groups

API count

id	before	after	diff
@kbn/esql-ast	799	800	+1

History

• 💔 Build #361399 failed 16e5f02

cc @bartoval

[stratoula]

We don't want to suggest the brackets

We want to add them immediately

Otherwise you have a different behavior if you do

• COMPETION --> select string --> WITH
• Adding space after WITH (your PR)

We want them to behave the same

[bartoval]

We don't want to suggest the brackets

We want to add them immediately

Otherwise you have a different behavior if you do

• COMPETION --> select string --> WITH
• Adding space after WITH (your PR)

We want them to behave the same

mmm..The implemented behavior follows the same workflow as the original. Have you tried it?
Or are you telling me that after typing WITH and then adding the space, I have to insert {inference_Id: ""} directly into the editor?

[bartoval]

... is that if you type WITH (and you dont select it from the autocomplete system) it doesnt show the suggestion after with

From the comment on the issue it seems to me that the idea is to have a suggestion after the space. Maybe the problem is just the choice of label for the suggestion? We can change it to inference_id. We can also insert all { inferende_id: ""} in one go. I had done it but it seemed like a different behavior from the current workflow

[stratoula]

I have to insert {inference_Id: ""} directly into the editor?

That one! Yes I tried it!

From the comment on the issue it seems to me that the idea is to have a suggestion after the space.

I know that the description is confusing but what we need is to insert it directly as we do with the other flow

[stratoula]

This looks great, just a small change on the icon but I am approving as I dont need to check again