[links] fix Can not save Dashboard after switching a Dashboard Link to an External Link#243134
Merged
nreese merged 8 commits intoelastic:mainfrom Nov 17, 2025
Merged
[links] fix Can not save Dashboard after switching a Dashboard Link to an External Link#243134nreese merged 8 commits intoelastic:mainfrom
nreese merged 8 commits intoelastic:mainfrom
Conversation
…o an External Link
Contributor
Author
|
/ci |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
/ci |
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
|
nreese
added
release_note:fix
Team:Presentation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
approved these changes
Nov 17, 2025
Contributor
ThomThomson
left a comment
ThomThomson
left a comment
There was a problem hiding this comment.
Changes LGTM - well tested and written! Code only review.
Contributor
|
Starting backport for target branches: 9.2 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 17, 2025
…o an External Link (elastic#243134) Closes elastic#242969 ### Test instructions * install web logs sample data * create new dashboard * add new links panel * add new dashboard link * Change dashboard link option * before clicking "Add link", switch to external link * set url * click add link * click saved links panel * save dashboard. Dashboard should save without any errors. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 5fece3e)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 17, 2025
…Link to an External Link (#243134) (#243295) # Backport This will backport the following commits from `main` to `9.2`: - [[links] fix Can not save Dashboard after switching a Dashboard Link to an External Link (#243134)](#243134) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-11-17T22:17:03Z","message":"[links] fix Can not save Dashboard after switching a Dashboard Link to an External Link (#243134)\n\nCloses https://github.com/elastic/kibana/issues/242969\n\n### Test instructions\n* install web logs sample data\n* create new dashboard\n* add new links panel\n* add new dashboard link\n* Change dashboard link option\n* before clicking \"Add link\", switch to external link\n* set url\n* click add link\n* click saved links panel\n* save dashboard. Dashboard should save without any errors.\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"5fece3ed46bac79d6482dc575a74a42d9397cc85","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","backport:version","v9.3.0","v9.2.2"],"title":"[links] fix Can not save Dashboard after switching a Dashboard Link to an External Link","number":243134,"url":"https://github.com/elastic/kibana/pull/243134","mergeCommit":{"message":"[links] fix Can not save Dashboard after switching a Dashboard Link to an External Link (#243134)\n\nCloses https://github.com/elastic/kibana/issues/242969\n\n### Test instructions\n* install web logs sample data\n* create new dashboard\n* add new links panel\n* add new dashboard link\n* Change dashboard link option\n* before clicking \"Add link\", switch to external link\n* set url\n* click add link\n* click saved links panel\n* save dashboard. Dashboard should save without any errors.\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"5fece3ed46bac79d6482dc575a74a42d9397cc85"}},"sourceBranch":"main","suggestedTargetBranches":["9.2"],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/243134","number":243134,"mergeCommit":{"message":"[links] fix Can not save Dashboard after switching a Dashboard Link to an External Link (#243134)\n\nCloses https://github.com/elastic/kibana/issues/242969\n\n### Test instructions\n* install web logs sample data\n* create new dashboard\n* add new links panel\n* add new dashboard link\n* Change dashboard link option\n* before clicking \"Add link\", switch to external link\n* set url\n* click add link\n* click saved links panel\n* save dashboard. Dashboard should save without any errors.\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"5fece3ed46bac79d6482dc575a74a42d9397cc85"}},{"branch":"9.2","label":"v9.2.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Dec 2, 2025
…o an External Link (elastic#243134) Closes elastic#242969 ### Test instructions * install web logs sample data * create new dashboard * add new links panel * add new dashboard link * Change dashboard link option * before clicking "Add link", switch to external link * set url * click add link * click saved links panel * save dashboard. Dashboard should save without any errors. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #242969
Test instructions