[Kbn grid layout] Use max_value instead of infinity#243572
Merged
ThomThomson merged 2 commits intoelastic:mainfrom Nov 20, 2025
Merged
[Kbn grid layout] Use max_value instead of infinity#243572ThomThomson merged 2 commits intoelastic:mainfrom
ThomThomson merged 2 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
nickpeihl
approved these changes
Nov 19, 2025
Contributor
nickpeihl
left a comment
There was a problem hiding this comment.
LGTM! I tested this and it seemed to resolve my issues with freezing tabs.
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
Contributor
|
Starting backport for target branches: 9.2 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 20, 2025
Uses `Number.MAX_VALUE` instead of `Infinity` for the default maximum height of a panel. (cherry picked from commit a5a7e5c)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 20, 2025
…243691) # Backport This will backport the following commits from `main` to `9.2`: - [[Kbn grid layout] Use max_value instead of infinity (#243572)](#243572) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Devon Thomson","email":"devon.thomson@elastic.co"},"sourceCommit":{"committedDate":"2025-11-20T15:56:36Z","message":"[Kbn grid layout] Use max_value instead of infinity (#243572)\n\nUses `Number.MAX_VALUE` instead of `Infinity` for the default maximum height of a panel.","sha":"a5a7e5c065633ab79cfabf6964b2c06fc6d8b3cc","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","loe:small","impact:critical","backport:version","v9.3.0","v9.2.2"],"title":"[Kbn grid layout] Use max_value instead of infinity","number":243572,"url":"https://github.com/elastic/kibana/pull/243572","mergeCommit":{"message":"[Kbn grid layout] Use max_value instead of infinity (#243572)\n\nUses `Number.MAX_VALUE` instead of `Infinity` for the default maximum height of a panel.","sha":"a5a7e5c065633ab79cfabf6964b2c06fc6d8b3cc"}},"sourceBranch":"main","suggestedTargetBranches":["9.2"],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/243572","number":243572,"mergeCommit":{"message":"[Kbn grid layout] Use max_value instead of infinity (#243572)\n\nUses `Number.MAX_VALUE` instead of `Infinity` for the default maximum height of a panel.","sha":"a5a7e5c065633ab79cfabf6964b2c06fc6d8b3cc"}},{"branch":"9.2","label":"v9.2.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Devon Thomson <devon.thomson@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Dec 2, 2025
Uses `Number.MAX_VALUE` instead of `Infinity` for the default maximum height of a panel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #243364 by using
Number.MAX_VALUEinstead ofInfinityfor the default maximum height of a panel.Explanation
The tab crash was caused by the dragged panel on the Dashboard attempting to resize their height to NaN. The NaN came from the
getRowCountInPixelsfunction when attempting to calculate max pixel height of the panel to calculate the bottom of the preview rect:Working case (main)
Broken case (main)
Fixed case (This PR)