Merged
Conversation
lgestc
added
release_note:enhancement
backport:skip
Contributor
|
Pinging @elastic/kibana-cases (Team:Cases) |
Contributor
|
@lgestc These margins seem a little big compared to the design: 
|
Contributor
|
@lgestc The tabs here seem out of place. They're not showing on your screenshot but they're showing for me locally 🤔 
|
lgestc
force-pushed
the
attachments_tab
branch
2 times, most recently
from
1600625 to
0a12912
Compare
lgestc
force-pushed
the
attachments_tab
branch
from
0a12912 to
1772cc1
Compare
janmonschke
reviewed
Nov 27, 2025
x-pack/platform/plugins/shared/cases/public/components/case_view/case_view_page.tsx
Outdated
Show resolved
Hide resolved
janmonschke
reviewed
Nov 27, 2025
x-pack/platform/plugins/shared/cases/public/components/case_view/case_view_tabs.tsx
Outdated
Show resolved
Hide resolved
janmonschke
approved these changes
Nov 27, 2025
...atform/plugins/shared/cases/public/components/case_view/components/case_view_attachments.tsx
Show resolved
Hide resolved
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
|
jcger
approved these changes
Dec 1, 2025
tkajtoch
pushed a commit
to tkajtoch/kibana
that referenced
this pull request
Dec 1, 2025
## Summary This PR implements elastic#243968, moving all attachments tabs into one, with subtab navigation implemented. <img width="1395" height="656" alt="Screenshot 2025-11-27 at 13 24 20" src="https://github.com/user-attachments/assets/23c88857-8f5a-409b-a899-9a44135dab54" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Dec 2, 2025
## Summary This PR implements elastic#243968, moving all attachments tabs into one, with subtab navigation implemented. <img width="1395" height="656" alt="Screenshot 2025-11-27 at 13 24 20" src="https://github.com/user-attachments/assets/23c88857-8f5a-409b-a899-9a44135dab54" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
JordanSh
pushed a commit
to JordanSh/kibana
that referenced
this pull request
Dec 9, 2025
## Summary This PR implements elastic#243968, moving all attachments tabs into one, with subtab navigation implemented. <img width="1395" height="656" alt="Screenshot 2025-11-27 at 13 24 20" src="https://github.com/user-attachments/assets/23c88857-8f5a-409b-a899-9a44135dab54" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements #243968, moving all attachments tabs into one, with subtab navigation implemented.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.