Skip to content

[Alerting] Disable flapping per rule - schema only changes#243855

Merged
doakalexi merged 32 commits intoelastic:mainfrom
doakalexi:alerting/235132
Dec 2, 2025
Merged

[Alerting] Disable flapping per rule - schema only changes#243855
doakalexi merged 32 commits intoelastic:mainfrom
doakalexi:alerting/235132

Conversation

@doakalexi
Copy link
Contributor

@doakalexi doakalexi commented Nov 21, 2025

Part of #235132

Summary

This PR updates the rule flapping schema to add an optional enabled field.

doakalexi and others added 10 commits November 21, 2025 08:04
…atus --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/saved_objects/_import --include-path /api/saved_objects/_export --include-path /api/maintenance_window --include-path /api/agent_builder --update
@doakalexi doakalexi changed the title Schema only changes Nov 24, 2025
@doakalexi doakalexi added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v9.3.0 labels Nov 24, 2025
@doakalexi doakalexi marked this pull request as ready for review November 25, 2025 14:16
@doakalexi doakalexi requested review from a team as code owners November 25, 2025 14:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so many schemas 😅 . LGTM, PR updates schema only.

@kc13greiner kc13greiner self-requested a review November 25, 2025 18:55
doakalexi and others added 6 commits November 26, 2025 08:28
…atus --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/saved_objects/_import --include-path /api/saved_objects/_export --include-path /api/maintenance_window --include-path /api/agent_builder --update
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion for the param description. If you like it, it'd need to be applied to the appropriate areas in the kibana.serverless.yaml and kibana.yaml files.

"nullable": true,
"properties": {
"enabled": {
"description": "Indicates whether you want to let the rule's status enter a flapping state.",
Copy link
Contributor

@nastasha-solomon nastasha-solomon Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some minor tweaks and described the default configuration. Let me know if this works.

Suggested change
"description": "Indicates whether you want to let the rule's status enter a flapping state.",
"description": "Determines whether the rule can enter the flapping state. By default, rules can enter the flapping state.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in this commit, 748875a

doakalexi and others added 4 commits November 26, 2025 14:03
…atus --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/saved_objects/_import --include-path /api/saved_objects/_export --include-path /api/maintenance_window --include-path /api/agent_builder --update
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my feedback!

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #139 / Search solution tests Index management Search solution nav Index list page "before each" hook for "renders search index details with no documents"

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/alerting-types 277 278 +1
Unknown metric groups

API count

id before after diff
@kbn/alerting-types 281 282 +1

History

@doakalexi doakalexi merged commit c59442f into elastic:main Dec 2, 2025
12 checks passed
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Dec 2, 2025
…43855)

Part of elastic#235132

## Summary

This PR updates the rule flapping schema to add an optional `enabled`
field.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
JordanSh pushed a commit to JordanSh/kibana that referenced this pull request Dec 9, 2025
…43855)

Part of elastic#235132

## Summary

This PR updates the rule flapping schema to add an optional `enabled`
field.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:enhancement Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v9.3.0

8 participants