[Alerting] Disable flapping per rule - schema only changes#243855
Merged
doakalexi merged 32 commits intoelastic:mainfrom Dec 2, 2025
Merged
[Alerting] Disable flapping per rule - schema only changes#243855doakalexi merged 32 commits intoelastic:mainfrom
doakalexi merged 32 commits intoelastic:mainfrom
Conversation
…atus --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/saved_objects/_import --include-path /api/saved_objects/_export --include-path /api/maintenance_window --include-path /api/agent_builder --update
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
ymao1
approved these changes
Nov 25, 2025
Contributor
ymao1
left a comment
There was a problem hiding this comment.
so many schemas 😅 . LGTM, PR updates schema only.
kc13greiner
approved these changes
Nov 25, 2025
jbudz
approved these changes
Nov 25, 2025
jloleysens
reviewed
Nov 26, 2025
x-pack/platform/plugins/shared/alerting/common/routes/rule/common/flapping/schemas/v2.ts
Outdated
Show resolved
Hide resolved
…atus --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/saved_objects/_import --include-path /api/saved_objects/_export --include-path /api/maintenance_window --include-path /api/agent_builder --update
nastasha-solomon
approved these changes
Nov 26, 2025
Contributor
nastasha-solomon
left a comment
There was a problem hiding this comment.
Left a suggestion for the param description. If you like it, it'd need to be applied to the appropriate areas in the kibana.serverless.yaml and kibana.yaml files.
oas_docs/bundle.json
Outdated
| "nullable": true, | ||
| "properties": { | ||
| "enabled": { | ||
| "description": "Indicates whether you want to let the rule's status enter a flapping state.", |
Contributor
There was a problem hiding this comment.
I made some minor tweaks and described the default configuration. Let me know if this works.
Suggested change
| "description": "Indicates whether you want to let the rule's status enter a flapping state.", | |
| "description": "Determines whether the rule can enter the flapping state. By default, rules can enter the flapping state.", |
…atus --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/saved_objects/_import --include-path /api/saved_objects/_export --include-path /api/maintenance_window --include-path /api/agent_builder --update
jloleysens
approved these changes
Nov 27, 2025
Contributor
jloleysens
left a comment
There was a problem hiding this comment.
Thanks for addressing my feedback!
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
History
|
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Dec 2, 2025
…43855) Part of elastic#235132 ## Summary This PR updates the rule flapping schema to add an optional `enabled` field. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
JordanSh
pushed a commit
to JordanSh/kibana
that referenced
this pull request
Dec 9, 2025
…43855) Part of elastic#235132 ## Summary This PR updates the rule flapping schema to add an optional `enabled` field. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #235132
Summary
This PR updates the rule flapping schema to add an optional
enabledfield.