Skip to content

Fix the flyout size issue#244072

Merged
saikatsarkar056 merged 5 commits intoelastic:mainfrom
saikatsarkar056:fix_flyout_size
Nov 26, 2025
Merged

Fix the flyout size issue#244072
saikatsarkar056 merged 5 commits intoelastic:mainfrom
saikatsarkar056:fix_flyout_size

Conversation

@saikatsarkar056
Copy link
Contributor

@saikatsarkar056 saikatsarkar056 commented Nov 24, 2025

Summary

Fixes the API key flyout width by changing the size from m (medium) to s (small).

Problem

The API key flyout is too wide and extends beyond the recommended usage width, making the form appear stretched.

Solution

Changed the EuiFlyout size prop from "m" to "s" in the ApiKeyFlyout component.

Testing

  • Navigate to Stack Management > Security > API Keys
  • Click "Create API key"
  • Verify the flyout is now narrower and fits within recommended width

Closes elastic/search-team#11838

Screen.Recording.2025-11-24.at.2.58.33.PM.mov

Release note

Fixes the API Creation Flyout sizing issue

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@saikatsarkar056 saikatsarkar056 requested a review from a team as a code owner November 24, 2025 21:28
@saikatsarkar056 saikatsarkar056 self-assigned this Nov 24, 2025
@saikatsarkar056 saikatsarkar056 marked this pull request as draft November 24, 2025 21:28
@saikatsarkar056 saikatsarkar056 marked this pull request as ready for review November 24, 2025 23:21
Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@mdefazio mdefazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Thank you for picking this up! 🙌

@saikatsarkar056 saikatsarkar056 enabled auto-merge (squash) November 26, 2025 19:54
@saikatsarkar056
Copy link
Contributor Author

@elasticmachine merge upstream

@saikatsarkar056 saikatsarkar056 merged commit 488f7b6 into elastic:main Nov 26, 2025
12 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Scout Test Run Builder / fieldText
  • [job] [logs] Scout Test Run Builder / serverless-security - EUI testing wrapper: EuiFieldText - fieldText

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchGettingStarted 155.2KB 155.2KB +53.0B
searchHomepage 180.4KB 180.4KB +53.0B
searchIndices 194.2KB 194.3KB +53.0B
security 487.1KB 487.2KB +53.0B
workplaceAIApp 151.7KB 151.7KB +53.0B
total +265.0B

History

cc @saikatsarkar056

JordanSh pushed a commit to JordanSh/kibana that referenced this pull request Dec 9, 2025
## Summary
Fixes the API key flyout width by changing the size from m (medium) to s
(small).

## Problem
The API key flyout is too wide and extends beyond the recommended usage
width, making the form appear stretched.

## Solution
Changed the EuiFlyout size prop from "m" to "s" in the ApiKeyFlyout
component.

## Testing

- Navigate to Stack Management > Security > API Keys
- Click "Create API key"
- Verify the flyout is now narrower and fits within recommended width


Closes elastic/search-team#11838



https://github.com/user-attachments/assets/9e03edf0-4256-4294-83df-2af6700933e8




## Release note
Fixes the API Creation Flyout sizing issue

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 participants