Skip to content

[ResponseOps][Reporting] Enable scheduled reports#244202

Merged
js-jankisalvi merged 9 commits intoelastic:mainfrom
js-jankisalvi:enable-scheduled-reports
Nov 27, 2025
Merged

[ResponseOps][Reporting] Enable scheduled reports#244202
js-jankisalvi merged 9 commits intoelastic:mainfrom
js-jankisalvi:enable-scheduled-reports

Conversation

@js-jankisalvi
Copy link
Contributor

@js-jankisalvi js-jankisalvi commented Nov 25, 2025

Summary

Fixes https://github.com/elastic/kibana-team/issues/2082

This PR

  • creates bulkEnable API to enable scheduled reports
method: PATCH
url: https://localhost:5601/internal/reporting/scheduled/bulk_enable
body:
{
    "ids": ["8982a0cf-7140-4880-807c-b3d3cb8a1981"]
}
  • adds Enable schedule option in Reporting > Schedules table
image

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Release Notes

Allow users to enable scheduled reports
@js-jankisalvi js-jankisalvi self-assigned this Nov 25, 2025
@js-jankisalvi js-jankisalvi requested a review from a team as a code owner November 25, 2025 16:19
@js-jankisalvi js-jankisalvi added release_note:enhancement Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// Feature:Reporting:Framework Reporting issues pertaining to the overall framework backport:version Backport to applied version labels v9.3.0 labels Nov 25, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 25, 2025

Pinging @elastic/response-ops (Team:ResponseOps)
@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner November 25, 2025 16:44
adcoelho
adcoelho reviewed Nov 26, 2025
View reviewed changes
...k/platform/plugins/private/reporting/public/management/components/report_schedules_table.tsx
type: 'icon',
icon: 'check',
onClick: (item) => {
onEnable(item);
Copy link
Contributor

@adcoelho adcoelho Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that to disable, we have a confirmation modal, setReportAndOpenDisableModal.

Is it on purpose that we don't show a modal for the enable action?
Copy link
Contributor Author

@js-jankisalvi js-jankisalvi Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed it as I didn't see it in the issue. Maybe @joana-cps could help
Copy link
Contributor Author

@js-jankisalvi js-jankisalvi Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a offline chat with @joana-cps - since it's not a destructive action we don't need the modal.
js-jankisalvi
js-jankisalvi commented Nov 26, 2025
View reviewed changes
...k/platform/plugins/private/reporting/public/management/components/report_schedules_table.tsx
}, [capabilities]);

const canEditSchedule = useCallback(
const canManageSchedule = useCallback(
Copy link
Contributor Author

@js-jankisalvi js-jankisalvi Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: User can edit/enable/disable/delete schedules from the table if user has manage reporting privilege or user has created that schedule.

CC: @tiamliu
adcoelho
adcoelho approved these changes Nov 26, 2025
View reviewed changes
Copy link
Contributor

@adcoelho adcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and code LGTM, but could you please add a x-pack/platform/test/reporting_api_integration/reporting_and_security/enable_scheduled_reports.ts?
@js-jankisalvi
Copy link
Contributor Author

js-jankisalvi commented Nov 27, 2025

Tested and code LGTM, but could you please add a x-pack/platform/test/reporting_api_integration/reporting_and_security/enable_scheduled_reports.ts?

Done
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 27, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #29 / EQL execution logic API @ess @serverless Alert Suppression for EQL rules @skipInServerless sequence queries with suppression duration suppresses alerts across two rule executions when the suppression duration exceeds the rule interval

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
reporting 235 237 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/reporting-common 104 105 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 2.1MB 2.1MB +39.0B
reporting 137.0KB 138.2KB +1.1KB
total +1.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
reporting 41.4KB 41.4KB +39.0B
Unknown metric groups

API count

id before after diff
@kbn/reporting-common 114 115 +1

History

cc @js-jankisalvi
@js-jankisalvi js-jankisalvi merged commit 512bd86 into elastic:main Nov 27, 2025
12 checks passed
@js-jankisalvi js-jankisalvi deleted the enable-scheduled-reports branch November 27, 2025 15:33
@kibanamachine kibanamachine added backport:skip This PR does not require backporting and removed backport:version Backport to applied version labels labels Nov 27, 2025
tkajtoch pushed a commit to tkajtoch/kibana that referenced this pull request Dec 1, 2025
@js-jankisalvi @kibanamachine @tkajtoch
[ResponseOps][Reporting] Enable scheduled reports (elastic#244202)
6a965b6 
## Summary

Fixes elastic/kibana-team#2082

This PR 
- creates `bulkEnable` API to enable scheduled reports
```
method: PATCH
url: https://localhost:5601/internal/reporting/scheduled/bulk_enable
body:
{
    "ids": ["8982a0cf-7140-4880-807c-b3d3cb8a1981"]
}
``` 
- adds `Enable schedule` option in Reporting > Schedules table 

<img width="1382" height="685" alt="image"
src="https://github.com/user-attachments/assets/2ae2301e-61a0-4fbd-973b-93af0981f9f2"
/>



### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Release Notes
Allow users to enable scheduled reports

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@js-jankisalvi js-jankisalvi mentioned this pull request Dec 2, 2025
Closed
JordanSh pushed a commit to JordanSh/kibana that referenced this pull request Dec 9, 2025
@js-jankisalvi @kibanamachine @JordanSh
[ResponseOps][Reporting] Enable scheduled reports (elastic#244202)
5f0e61b 
## Summary

Fixes elastic/kibana-team#2082

This PR 
- creates `bulkEnable` API to enable scheduled reports
```
method: PATCH
url: https://localhost:5601/internal/reporting/scheduled/bulk_enable
body:
{
    "ids": ["8982a0cf-7140-4880-807c-b3d3cb8a1981"]
}
``` 
- adds `Enable schedule` option in Reporting > Schedules table 

<img width="1382" height="685" alt="image"
src="https://github.com/user-attachments/assets/2ae2301e-61a0-4fbd-973b-93af0981f9f2"
/>



### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Release Notes
Allow users to enable scheduled reports

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Reporting:Framework Reporting issues pertaining to the overall framework release_note:enhancement Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v9.3.0

5 participants

@js-jankisalvi @elasticmachine @adcoelho @jbudz @kibanamachine