[ES|QL] Lookup index editor - New layout and controls#244480
Merged
sddonne merged 120 commits intoelastic:mainfrom Dec 5, 2025
Merged
[ES|QL] Lookup index editor - New layout and controls#244480sddonne merged 120 commits intoelastic:mainfrom
sddonne merged 120 commits intoelastic:mainfrom
Conversation
stratoula
reviewed
Nov 28, 2025
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
Thanks Seb this looks very nice! Some small comments from me
| customBulkActions={bulkActions} | ||
| rowLineHeightOverride={euiTheme.size.xl} | ||
| renderCustomToolbar={gridToolbar} | ||
| css={css` |
Contributor
There was a problem hiding this comment.
We could declare them in another file and import them here for a cleaner component (nit)
Contributor
Author
There was a problem hiding this comment.
I prefer them in the same file if you are ok with it 😇
Contributor
There was a problem hiding this comment.
Can you please at least move them to a constant?
src/platform/packages/private/kbn-index-editor/src/components/flyout_content.tsx
Outdated
Show resolved
Hide resolved
...ackages/private/kbn-index-editor/src/components/grid_custom_renderers/add_column_popover.tsx
Show resolved
Hide resolved
...ackages/private/kbn-index-editor/src/components/grid_custom_renderers/add_column_popover.tsx
Outdated
Show resolved
Hide resolved
src/platform/packages/private/kbn-index-editor/src/components/query_bar.tsx
Outdated
Show resolved
Hide resolved
...ts/custom_control_columns/additional_row_control/get_additional_row_control_columns.test.tsx
Outdated
Show resolved
Hide resolved
src/platform/packages/private/kbn-index-editor/src/components/data_grid.tsx
Show resolved
Hide resolved
PhilippeOberti
approved these changes
Dec 2, 2025
Contributor
PhilippeOberti
left a comment
PhilippeOberti
left a comment
There was a problem hiding this comment.
LGTM for the @elastic/security-threat-hunting-investigations team
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#9977[✅] src/platform/test/functional/apps/discover/esql/config.ts: 25/25 tests passed. |
stratoula
approved these changes
Dec 5, 2025
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
Thanx Sebastian, it looks really nice now. I am approving as I don't need to review but please can you take care of it? #244480 (comment)
When we are making so many CSS changes it is better to at least define them in a variable. This makes it more readable and also more consistent with what we do in general
Contributor
💔 Build Failed
Failed CI StepsHistory
|
wildemat
pushed a commit
to wildemat/kibana
that referenced
this pull request
Dec 5, 2025
Part of elastic#235730 ## Summary * New way of inserting rows and columns * Simplified layout * Rows height has been adjusted * We are now displaying 50 rows by default.  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Stratou <efstratia.kalafateli@elastic.co>
This was referenced Dec 5, 2025
JordanSh
pushed a commit
to JordanSh/kibana
that referenced
this pull request
Dec 9, 2025
Part of elastic#235730 ## Summary * New way of inserting rows and columns * Simplified layout * Rows height has been adjusted * We are now displaying 50 rows by default.  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Stratou <efstratia.kalafateli@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #235730
Summary
Checklist