Skip to content

[Cases] Fix stale submitting#244543

Merged
lgestc merged 3 commits intoelastic:mainfrom
lgestc:fix_stale_submitting
Dec 1, 2025
Merged

[Cases] Fix stale submitting#244543
lgestc merged 3 commits intoelastic:mainfrom
lgestc:fix_stale_submitting

Conversation

@lgestc
Copy link
Contributor

@lgestc lgestc commented Nov 27, 2025

Summary

Addresses #167756

In short, whenever an error is thrown in the submit method, we should reset submission state, allowing users to retry.
Currently, an error thrown in .submit locks isSubmitting in false state.

Checklist

@lgestc lgestc requested review from a team as code owners November 27, 2025 15:06
@lgestc lgestc added v9.3.0 release_note:fix backport:all-open Backport to all branches that could still receive a release labels Nov 27, 2025
@lgestc lgestc force-pushed the fix_stale_submitting branch 2 times, most recently from f08b68c to 9c69585 Compare November 27, 2025 15:08
@janmonschke
Copy link
Contributor

@lgestc Could you add a unit test for the new behaviour?

@lgestc
Copy link
Contributor Author

lgestc commented Nov 27, 2025

@lgestc Could you add a unit test for the new behaviour?

working on it

@lgestc lgestc force-pushed the fix_stale_submitting branch 2 times, most recently from 40da4f7 to 482d376 Compare November 27, 2025 16:28
]
),
isSubmitting:
isPostingCase || isCreatingAttachments || isPostingObservables || isPushingToExternalService,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is important

@lgestc lgestc force-pushed the fix_stale_submitting branch 3 times, most recently from b2e0725 to 5f383b9 Compare November 27, 2025 16:36
@lgestc lgestc changed the title [Shared][Forms] Fix stale submitting Nov 27, 2025
@lgestc lgestc added the Team:Cases Security Solution Cases team label Nov 27, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cases (Team:Cases)

@darnautov darnautov removed the request for review from a team November 28, 2025 09:47
@lgestc lgestc force-pushed the fix_stale_submitting branch 3 times, most recently from 7759a00 to 1fef8db Compare November 28, 2025 12:35
@lgestc lgestc force-pushed the fix_stale_submitting branch from 1fef8db to 58ed2a0 Compare November 28, 2025 15:02
Copy link
Contributor

@janmonschke janmonschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this long-standing bug 🎉

@elastic elastic deleted a comment from elasticmachine Dec 1, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

29 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 244543 locally
cc: @lgestc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:all-open Backport to all branches that could still receive a release backport missing Added to PRs automatically when the are determined to be missing a backport. release_note:fix Team:Cases Security Solution Cases team v9.3.0

4 participants