Added a Brave Search connector by seanstory · Pull Request #245329 · elastic/kibana

seanstory · 2025-12-04T23:58:05Z

Summary

Adds a connector for Brave Search to the new "v2" framework.

This is an API we've found useful for doing web search in workflows and with Agent Builder.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Release Notes

Introduces a connector for web search via Brave Search

github-actions · 2025-12-05T20:10:56Z

🔍 Preview links for changed docs

docs/reference/connectors-kibana/brave-search-action-type.md

src/platform/packages/shared/kbn-connector-specs/src/specs/brave_search/brave_search.ts

Apmats · 2025-12-10T12:18:32Z

src/platform/packages/shared/kbn-connector-specs/src/specs/brave_search/brave_search.ts

+          .describe('Result offset for pagination'),
+      }),
+      output: z.object({
+        query: z.any().describe('Original query information'),


The remote API does have a strict definition:

https://api-dashboard.search.brave.com/app/documentation/web-search/responses

Do we want to be loose to avoid breaking on any changes from that API and only fixing any downstream users of this response?

That's my instinct, yeah. At least for now. Maybe we'll want to tighten this if/when we build an OOTB workflow that needs to depend on specific fields.

Add docs, tests, and internationalization Add brave search docs to the TOC Add brave search do stack connectors snippet Fix the syntax issue

darnautov · 2025-12-15T15:47:39Z

.github/CODEOWNERS

@@ -2314,6 +2314,7 @@ src/platform/packages/shared/kbn-connector-specs/src/all_specs.ts
 src/platform/packages/shared/kbn-connector-specs/src/connector_icons_map.ts


@seanstory could you please add this line? thanks!

Suggested change

src/platform/packages/shared/kbn-connector-specs/src/connector_icons_map.ts

src/platform/packages/shared/kbn-connector-specs/src/connector_icons_map.ts

src/platform/packages/shared/kbn-connector-specs/src/specs/** @elastic/workflows-eng

no - we don't want every new spec to require the review of the workflows-eng folks. If my team (E&T) adds a new connector (like this Brave Search connector) I shouldn't need the Workflow team's approval. Ideally, I wouldn't need anyone's approval but my own team.

Then we should keep it empty, otherwise it requires a review from the Response Ops team, like in this PR.
FYI, CODEOWNERS rules are applied from the main branch, not from the PR branch.

src/platform/packages/shared/kbn-connector-specs/src/specs/**

src/platform/packages/shared/kbn-connector-specs/src/specs/** src/platform/packages/shared/kbn-connector-specs/src/all_specs.ts src/platform/packages/shared/kbn-connector-specs/src/connector_icons_map.ts src/platform/packages/shared/kbn-connector-specs/src/specs/alienvault_otx/** @elastic/workflows-eng src/platform/packages/shared/kbn-connector-specs/src/specs/brave_search/** @elastic/workchat-eng

vs

src/platform/packages/shared/kbn-connector-specs/src/all_specs.ts src/platform/packages/shared/kbn-connector-specs/src/connector_icons_map.ts src/platform/packages/shared/kbn-connector-specs/src/specs/alienvault_otx/** @elastic/workflows-eng src/platform/packages/shared/kbn-connector-specs/src/specs/brave_search/** @elastic/workchat-eng

vs

src/platform/packages/shared/kbn-connector-specs/src/specs/alienvault_otx/** @elastic/workflows-eng src/platform/packages/shared/kbn-connector-specs/src/specs/brave_search/** @elastic/workchat-eng

Are all functionally equivalent, AFAICT? And yes, right now they all end up requiring a review from response ops when new connectors are added, because all_specs.ts and connector_icons_map.ts always get changed. There's not a good single-team owner for these, I don't think. The only solution IMO is to adjust these files to automatically detect specs/icons based on the folders available, rather than on new code lines that must be added. OR, response-ops has to always approve new connectors, and at least doesn't get bothered when existing connectors are modified.

WDYT?

I'm know sure if they are equivalent, because rules listed below overrides the top rules.

src/platform/packages/shared/kbn-connector-specs @elastic/response-ops <- set a default owner src/platform/packages/shared/kbn-connector-specs/src/all_specs.ts <- removes any team as owner (it works!) src/platform/packages/shared/kbn-connector-specs/src/connector_icons_map.ts <- removes any team as owner (it works!) src/platform/packages/shared/kbn-connector-specs/src/specs/** <- should also remove any team as owner src/platform/packages/shared/kbn-connector-specs/src/specs/alienvault_otx/** @elastic/workflows-eng <- set ownership per folder spec

florent-leborgne

LGTM from a docs perspective. Thanks for updating this with the structure we discussed in the other PR 🚢

elasticmachine · 2025-12-15T20:33:56Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: f30a9a1

Failed CI Steps

FTR Configs #133

Test Failures

[job] [logs] FTR Configs #133 / Serverless Observability - Deployment-agnostic AI Assistant API integration tests observability AI Assistant tool: retrieve_elastic_doc POST /internal/observability_ai_assistant/chat/complete The second request - Sending the user prompt should send 1 document to the llm

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`stackConnectors`	607	610	+3
`workflowsManagement`	1118	1119	+1
total			+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`stackConnectors`	1.1MB	1.1MB	+6.7KB
`workflowsManagement`	1.2MB	1.2MB	+1.6KB
total			+8.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`stackConnectors`	76.0KB	76.1KB	+66.0B

Unknown metric groups

async chunk count

id	before	after	diff
`stackConnectors`	116	117	+1

History

💔 Build #373263 failed 2958030
💚 Build #372795 succeeded 381a223
💛 Build #372741 was flaky 69a7a48
💔 Build #372678 failed fdff411
💔 Build #372127 failed 33fffa5

seanstory requested a review from a team December 4, 2025 23:58

seanstory added backport:skip This PR does not require backporting release_note:feature Makes this part of the condensed release notes labels Dec 4, 2025

seanstory marked this pull request as ready for review December 5, 2025 18:23

seanstory requested review from a team as code owners December 5, 2025 18:23

meghanmurphy1 reviewed Dec 9, 2025

View reviewed changes

src/platform/packages/shared/kbn-connector-specs/src/specs/brave_search/brave_search.ts Show resolved Hide resolved

Apmats reviewed Dec 10, 2025

View reviewed changes

seanstory force-pushed the seanstory/add-brave-search-v2-connector branch from 0b41c8c to 33fffa5 Compare December 11, 2025 21:49

seanstory requested a review from a team as a code owner December 11, 2025 21:49

darnautov approved these changes Dec 12, 2025

View reviewed changes

seanstory force-pushed the seanstory/add-brave-search-v2-connector branch from 33fffa5 to 8213616 Compare December 12, 2025 18:56

seanstory requested review from a team and kibanamachine as code owners December 12, 2025 18:56

seanstory changed the base branch from main to seanstory/add-v2-tests-docs-and-i18n December 12, 2025 18:57

Base automatically changed from seanstory/add-v2-tests-docs-and-i18n to main December 12, 2025 20:53

seanstory added 4 commits December 12, 2025 15:38

Added a Brave Search connector

9c890ac

Add docs, tests, and internationalization Add brave search docs to the TOC Add brave search do stack connectors snippet Fix the syntax issue

Move brave_search connector to its own dir

b14efdf

Rename brave_search/index.ts to brave_search.ts

6b26119

Fix the snippet/toc for brave search

00711ac

seanstory force-pushed the seanstory/add-brave-search-v2-connector branch from fdff411 to 00711ac Compare December 12, 2025 21:38

had Brave Search in the wrong section

69a7a48

seanstory removed the request for review from a team December 12, 2025 21:40

Merge branch 'main' into seanstory/add-brave-search-v2-connector

381a223

seanstory removed the request for review from a team December 13, 2025 16:24

Merge branch 'main' into seanstory/add-brave-search-v2-connector

2958030

seanstory removed the request for review from kibanamachine December 15, 2025 15:33

darnautov reviewed Dec 15, 2025

View reviewed changes

florent-leborgne approved these changes Dec 15, 2025

View reviewed changes

Merge branch 'main' into seanstory/add-brave-search-v2-connector

f30a9a1

seanstory merged commit b46b66b into main Dec 15, 2025
14 checks passed

seanstory deleted the seanstory/add-brave-search-v2-connector branch December 15, 2025 21:56

kibanamachine added the v9.3.0 label Dec 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added a Brave Search connector#245329

Added a Brave Search connector#245329
seanstory merged 8 commits intomainfrom
seanstory/add-brave-search-v2-connector

seanstory commented Dec 4, 2025 •

edited

Loading

github-actions bot commented Dec 5, 2025 •

edited

Loading

Uh oh!

Apmats Dec 10, 2025

seanstory Dec 10, 2025

darnautov Dec 15, 2025

seanstory Dec 15, 2025

darnautov Dec 15, 2025

seanstory Dec 15, 2025

darnautov Dec 16, 2025

florent-leborgne left a comment

elasticmachine commented Dec 15, 2025

async chunk count

Uh oh!

Labels

7 participants

		@@ -2314,6 +2314,7 @@ src/platform/packages/shared/kbn-connector-specs/src/all_specs.ts
		src/platform/packages/shared/kbn-connector-specs/src/connector_icons_map.ts

Conversation

seanstory commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Release Notes

github-actions bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔍 Preview links for changed docs

Uh oh!

Apmats Dec 10, 2025

Choose a reason for hiding this comment

seanstory Dec 10, 2025

Choose a reason for hiding this comment

darnautov Dec 15, 2025

Choose a reason for hiding this comment

seanstory Dec 15, 2025

Choose a reason for hiding this comment

darnautov Dec 15, 2025

Choose a reason for hiding this comment

seanstory Dec 15, 2025

Choose a reason for hiding this comment

darnautov Dec 16, 2025

Choose a reason for hiding this comment

florent-leborgne left a comment

Choose a reason for hiding this comment

elasticmachine commented Dec 15, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

async chunk count

History

Uh oh!

Labels

7 participants

seanstory commented Dec 4, 2025 •

edited

Loading

github-actions bot commented Dec 5, 2025 •

edited

Loading