Skip to content

[Discover] Don't make redundant requests when breakdown or chart interval changes#245523

Merged
jughosta merged 4 commits intoelastic:mainfrom
jughosta:211605-no-extra-requests-for-breakdown-and-interval
Dec 10, 2025
Merged

[Discover] Don't make redundant requests when breakdown or chart interval changes#245523
jughosta merged 4 commits intoelastic:mainfrom
jughosta:211605-no-extra-requests-for-breakdown-and-interval

Conversation

@jughosta
Copy link
Contributor

@jughosta jughosta commented Dec 8, 2025

Summary

Previously Discover was making 2 requests (document and chart) when the breakdown field or chart time interval were changing. This PR removes the redundant fetch for the documents and keeps the refetch for the chart only.

Checklist

@jughosta jughosta self-assigned this Dec 8, 2025
@jughosta jughosta added release_note:enhancement Feature:Discover Discover Application performance backport:skip This PR does not require backporting Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// Feature:UnifiedHistogram Issues related to the Unified Histogram plugin labels Dec 8, 2025
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#10008

[✅] src/platform/test/functional/apps/discover/group3/config.ts: 10/10 tests passed.

see run history

@jughosta jughosta marked this pull request as ready for review December 9, 2025 07:34
@jughosta jughosta requested a review from a team as a code owner December 9, 2025 07:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Contributor

@akowalska622 akowalska622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, LGTM thanks!

@jughosta jughosta enabled auto-merge (squash) December 10, 2025 08:59
@jughosta jughosta merged commit b95ecaf into elastic:main Dec 10, 2025
12 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 1.3MB 1.3MB -111.0B

History

cc @jughosta

@jughosta jughosta deleted the 211605-no-extra-requests-for-breakdown-and-interval branch December 10, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Discover Discover Application Feature:UnifiedHistogram Issues related to the Unified Histogram plugin performance release_note:enhancement Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v9.3.0

4 participants