Skip to content

feat(fleet): supports slo_template kibana asset type#245903

Merged
kdelemme merged 21 commits intoelastic:mainfrom
kdelemme:feat/support-slo-template-from-fleet
Dec 19, 2025
Merged

feat(fleet): supports slo_template kibana asset type#245903
kdelemme merged 21 commits intoelastic:mainfrom
kdelemme:feat/support-slo-template-from-fleet

Conversation

@kdelemme
Copy link
Copy Markdown
Contributor

@kdelemme kdelemme commented Dec 10, 2025 •
edited
Loading

Waiting for #245897
Resolves #245899

Summary

  • Adds support for installing slo_template assets from packages
  • Adds tagging support for slo_template

Requires the feature flag xpack.fleet.experimentalFeatures.enableSloTemplates: true

image

For manual testing

  1. Run this PR locally
  2. Pull package-spec main: https://github.com/elastic/package-spec
  3. From package-spec go to the good_content test package test/packages/good_content in another terminal
  4. From the good_content terminal set ELASTIC_PACKAGE_KIBANA_HOST to point to your locally running kibana instance eg: export ELASTIC_PACKAGE_KIBANA_HOST="http://0.0.0.0:5601/kibana"
  5. From the good_content terminal run elastic-package build --skip-validation then elastic-package install --zip ../../../build/packages/good_content-1.0.0.zip --skip-validation
  6. From the Saved Object management UI you should be able to find the installed object tagged appropriately.
  7. Update the slo_template name in the good_content package, and run the build and install commands again to view the changed name
  8. Go to the installed integrations UI and uninstall good_content. You should see the slo_template removed.
@github-actions github-actions Bot added the author:actionable-obs PRs authored by the actionable obs team label Dec 10, 2025
@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v9.3.0 ci:beta-faster-pr-build author:actionable-obs PRs authored by the actionable obs team and removed author:actionable-obs PRs authored by the actionable obs team labels Dec 10, 2025
@kdelemme kdelemme self-assigned this Dec 10, 2025
kibanamachine and others added 3 commits December 10, 2025 18:59
@kibanamachine
TO FIX: Run node 'scripts/yarn_deduplicate && yarn kbn bootstrap' loc…
556395c 
…ally, or add an exception to src/dev/yarn_deduplicate/index.ts and then commit the changes and push to your branch
@kdelemme
fix telemtry
3564301
@kdelemme
Merge branch 'main' into feat/support-slo-template-from-fleet
73f5b41
@kdelemme kdelemme marked this pull request as ready for review December 16, 2025 20:33
@kdelemme kdelemme requested review from a team as code owners December 16, 2025 20:33
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 16, 2025

Pinging @elastic/actionable-obs-team (Team:actionable-obs)
@kibanamachine
TO FIX: Run node 'scripts/yarn_deduplicate && yarn kbn bootstrap' loc…
aaaec24 
…ally, or add an exception to src/dev/yarn_deduplicate/index.ts and then commit the changes and push to your branch
@botelastic botelastic Bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 16, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 16, 2025

Pinging @elastic/fleet (Team:Fleet)
@nchaulet nchaulet self-requested a review December 17, 2025 02:11
szwarckonrad
szwarckonrad approved these changes Dec 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@szwarckonrad szwarckonrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defend Workflows changes (mock extension) LGTM!
paul-tavares
paul-tavares approved these changes Dec 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to x-pack/solutions/security/plugins/security_solution/public/management/pages/policy/view/ingest_manager_integration/mocks.tsx look good 👍
nchaulet
nchaulet approved these changes Dec 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and worked as expected, LGTM 🚀
Comment thread x-pack/platform/test/fleet_api_integration/apis/epm/update_assets.ts
Copy link
Copy Markdown
Member

@nchaulet nchaulet Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expected some changed needed in those test files too https://github.com/elastic/kibana/blob/main/x-pack/platform/test/fleet_api_integration/apis/epm/install_remove_assets.ts#L604-L938 but looks like they were skipped because of flakyness, added a comment so we do not forget to include test #246272
@kdelemme kdelemme mentioned this pull request Dec 17, 2025
Merged
@elastic elastic deleted a comment from elasticmachine Dec 18, 2025
@elastic elastic deleted a comment from elasticmachine Dec 18, 2025
@kdelemme
Copy link
Copy Markdown
Contributor Author

kdelemme commented Dec 18, 2025

Working on #246928 so we can fix the errors regarding the missing saved object mappings
@kdelemme kdelemme mentioned this pull request Dec 19, 2025
Merged
5 tasks
TinaHeiligers
TinaHeiligers approved these changes Dec 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

telemetry changes LGTM
@kdelemme kdelemme enabled auto-merge (squash) December 19, 2025 17:50
@kdelemme kdelemme merged commit c720800 into elastic:main Dec 19, 2025
14 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 19, 2025

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 179.9KB 180.1KB +187.0B

History

cc @kdelemme
baileycash-elastic pushed a commit to baileycash-elastic/kibana that referenced this pull request Dec 19, 2025
@kdelemme @baileycash-elastic
feat(fleet): supports slo_template kibana asset type (elastic#245903)
94aa095
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 6, 2026
@kdelemme @CAWilson94
feat(fleet): supports slo_template kibana asset type (elastic#245903)
d9982c3
dej611 pushed a commit to dej611/kibana that referenced this pull request Jan 8, 2026
@kdelemme @dej611
feat(fleet): supports slo_template kibana asset type (elastic#245903)
d096494
@kibanamachine kibanamachine mentioned this pull request Jan 30, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author:actionable-obs PRs authored by the actionable obs team backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. Team:Fleet Team label for Observability Data Collection Fleet team v9.3.0 v9.4.0

8 participants

@kdelemme @elasticmachine @nchaulet @TinaHeiligers @szwarckonrad @paul-tavares @kowalczyk-krzysztof @kibanamachine