Add table caption for empty top categories in logs category table#246041
Merged
jorgeoliveira117 merged 8 commits intoelastic:mainfrom Dec 15, 2025
Conversation
…rrectly-announced-table
weltenwort
approved these changes
Dec 11, 2025
|
|
||
| const tableCaption = | ||
| topCategories.length === 0 | ||
| ? i18n.translate('xpack.infra.logs.logEntryCategories.noCategoriesMessage', { |
Member
There was a problem hiding this comment.
Nit: Since the content specifically refers to the concept table, what do you think about helping the translators by calling this something like noCategoriesTableCaption?
Contributor
Author
There was a problem hiding this comment.
Sounds good! I'll make that change
jorgeoliveira117
added
release_note:fix
backport:skip
…ounced-table' of https://github.com/jorgeoliveira117/kibana into 212406-observabilitylogs-categories-pageincorrectly-announced-table
…rrectly-announced-table
…rrectly-announced-table
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
…rrectly-announced-table
…rrectly-announced-table
seanrathier
pushed a commit
to seanrathier/kibana
that referenced
this pull request
Dec 15, 2025
…astic#246041) Closes elastic#212406 ## Summary While EUI doesn't have a default message for `EuiBasicTable`, we're updating the table caption in the Logs Category table to improve accessibility when there's no data. ### Changes - Added a screen reader caption to the Logs Category Table when it's empty ### Steps to Reproduce 1. Open Observability 2. On the left side navigation select "Other Tools" 3. Click "Logs categories" 4. Make the table empty by filtering for a dataset or timerange 5. Focus the table by pressing T or using other keyboard navigation ### Expected Results The Screen Reader should announce that the table has no data when focusing it: <img width="816" height="577" alt="Screenshot 2025-12-11 171110" src="https://github.com/user-attachments/assets/854395d2-fd04-4adf-9165-c227f5a9adaa" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #212406
Summary
While EUI doesn't have a default message for
EuiBasicTable, we're updating the table caption in the Logs Category table to improve accessibility when there's no data.Changes
Steps to Reproduce
Expected Results
The Screen Reader should announce that the table has no data when focusing it: