Change the copy_icon to check_icon when copied#246090
Change the copy_icon to check_icon when copied#246090saikatsarkar056 merged 12 commits intoelastic:mainfrom
Conversation
saikatsarkar056
added
backport:skip
| await testSubjects.existOrFail('endpointValueField'); | ||
| }); | ||
|
|
||
| it('shows checkmark icon feedback when copy button is clicked', async () => { |
There was a problem hiding this comment.
Definitely run the flakey test runner for these.
My gut reaction is these might be flakey, and this is a case where I think a unit test of the component would be better than a functional test IMO.
There was a problem hiding this comment.
FYI, These tests are still skipped, see line 31. so adding these doesn't do anything currently.
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10075[✅] x-pack/solutions/search/test/functional_search/config.ts: 200/200 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10076[✅] x-pack/solutions/search/test/serverless/functional/configs/config.search_features.ts: 200/200 tests passed. |
|
@elasticmachine merge upstream |
| await testSubjects.existOrFail('endpointValueField'); | ||
| }); | ||
|
|
||
| it('shows checkmark icon feedback when copy button is clicked', async () => { |
There was a problem hiding this comment.
FYI, These tests are still skipped, see line 31. so adding these doesn't do anything currently.
| await testSubjects.existOrFail('apiKeyFormNoUserPrivileges'); | ||
| }); | ||
|
|
||
| it('shows checkmark icon feedback when copy button is clicked', async () => { |
There was a problem hiding this comment.
These tests are also currently skipped, see line 33
| expect(endpointValue).to.contain('https://'); | ||
| }); | ||
|
|
||
| it('shows checkmark icon feedback when copy button is clicked', async () => { |
There was a problem hiding this comment.
this is the only test you added that is being run, getting started is run as a part of the feature flags config for now, and you did not run the flakey test runner for those tests.
…kibana into copy_action_icon_change
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10088[✅] x-pack/solutions/search/test/functional_search/config/config.feature_flags.ts: 200/200 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10089[✅] x-pack/solutions/search/test/serverless/functional/configs/config.feature_flags.ts: 200/200 tests passed. |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
4 participants
Summary
This PR updates the copy behavior so that when a field is copied, the UI provides clear confirmation. The copy icon now briefly changes to a checkmark to indicate success, and then automatically switches back to the copy icon after about a second.
Screen.Recording.2025-12-12.at.9.44.03.AM.mov
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.
Release note
Enhances the copy behavior by providing clear visual confirmation: