Skip to content

[ML] Anomaly detection: Fixes creating new jobs from Discover sessions with no data view#246410

Merged
jgowdyelastic merged 15 commits intoelastic:mainfrom
jgowdyelastic:fix-issue-with-new-jobs-from-discover-sessions
Dec 17, 2025
Merged

[ML] Anomaly detection: Fixes creating new jobs from Discover sessions with no data view#246410
jgowdyelastic merged 15 commits intoelastic:mainfrom
jgowdyelastic:fix-issue-with-new-jobs-from-discover-sessions

Conversation

@jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Dec 15, 2025

Fixes issue where the new job page can crash if attempting to create a job from a saved Discover session which uses a temporary data view.

To reproduce:

  • Open discover in classic mode, select a data view to use.
  • Switch to ES|QL mode
  • Switch back to classic mode
  • Save the session
  • Jump to ML and attempt to use the session to create a job

Fixes #244199

@jgowdyelastic jgowdyelastic marked this pull request as ready for review December 16, 2025 14:59
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner December 16, 2025 14:59
@jgowdyelastic jgowdyelastic self-assigned this Dec 16, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic added release_note:fix backport:skip This PR does not require backporting labels Dec 16, 2025
…x_utils.ts

Co-authored-by: Konrad Krasocki <104936644+KodeRad@users.noreply.github.com>
@jgowdyelastic jgowdyelastic enabled auto-merge (squash) December 16, 2025 16:19
…ub.com:jgowdyelastic/kibana into fix-issue-with-new-jobs-from-discover-sessions
Copy link
Contributor

@KodeRad KodeRad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

auto-merge was automatically disabled December 17, 2025 07:54

Pull Request is not mergeable

@jgowdyelastic jgowdyelastic enabled auto-merge (squash) December 17, 2025 08:06
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@jgowdyelastic jgowdyelastic merged commit 402094b into elastic:main Dec 17, 2025
14 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.6MB 5.6MB +1.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ml 86.7KB 86.7KB +10.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
ml 553 554 +1

References to deprecated APIs

id before after diff
ml 62 63 +1

Total ESLint disabled count

id before after diff
ml 556 557 +1

History

cc @jgowdyelastic

@peteharverson peteharverson changed the title [ML] Fix issue with creating new AD jobs from Discover sessions with no data view Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Anomaly Detection ML anomaly detection :ml release_note:fix v9.3.0

5 participants