Add max character validation to the email connector params and config#246453
Merged
ersin-erdal merged 10 commits intoelastic:mainfrom Dec 30, 2025
Merged
Add max character validation to the email connector params and config#246453ersin-erdal merged 10 commits intoelastic:mainfrom
ersin-erdal merged 10 commits intoelastic:mainfrom
Conversation
ersin-erdal
added
release_note:fix
Team:ResponseOps
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
darnautov
reviewed
Dec 16, 2025
src/platform/packages/shared/kbn-connector-schemas/email/schemas/v1.ts
Outdated
Show resolved
Hide resolved
src/platform/packages/shared/kbn-connector-schemas/email/schemas/v1.ts
Outdated
Show resolved
Hide resolved
src/platform/packages/shared/kbn-connector-schemas/email/schemas/v1.ts
Outdated
Show resolved
Hide resolved
darnautov
reviewed
Dec 17, 2025
x-pack/platform/plugins/shared/stack_connectors/server/connector_types/email/index.test.ts
Show resolved
Hide resolved
|
|
||
| function validateParams(paramsObject: unknown, validatorServices: ValidatorServices) { | ||
| const { configurationUtilities } = validatorServices; | ||
| const emailValidator = z.array(z.string().max(512)).max(100); |
Contributor
There was a problem hiding this comment.
can we reuse emailSchema from kbn-connector-schemas?
Contributor
Author
There was a problem hiding this comment.
I didn't use them intentionally since they are versioned schema.
We can use it from the latest version but a new version would affect here too.
Should we?
Contributor
There was a problem hiding this comment.
I think it's ok to use the latest
Contributor
💚 Build Succeeded
Metrics [docs]
History
|
Contributor
|
Starting backport for target branches: 8.19, 9.1, 9.2, 9.3 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 30, 2025
…elastic#246453) This PR adds length validation to the email params to prevent crushing errors. --------- Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co> (cherry picked from commit 0621884)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 30, 2025
…config (#246453) (#247600) # Backport This will backport the following commits from `main` to `9.3`: - [Add max character validation to the email connector params and config (#246453)](#246453) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ersin Erdal","email":"92688503+ersin-erdal@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-12-30T11:18:55Z","message":"Add max character validation to the email connector params and config (#246453)\n\nThis PR adds length validation to the email params to prevent crushing\nerrors.\n\n---------\n\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>","sha":"06218847e4528caf724a541d9443c02339001982","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","backport:all-open","v9.4.0"],"title":"Add max character validation to the email connector params and config","number":246453,"url":"https://github.com/elastic/kibana/pull/246453","mergeCommit":{"message":"Add max character validation to the email connector params and config (#246453)\n\nThis PR adds length validation to the email params to prevent crushing\nerrors.\n\n---------\n\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>","sha":"06218847e4528caf724a541d9443c02339001982"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/246453","number":246453,"mergeCommit":{"message":"Add max character validation to the email connector params and config (#246453)\n\nThis PR adds length validation to the email params to prevent crushing\nerrors.\n\n---------\n\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>","sha":"06218847e4528caf724a541d9443c02339001982"}}]}] BACKPORT--> Co-authored-by: Ersin Erdal <92688503+ersin-erdal@users.noreply.github.com> Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
ersin-erdal
added a commit
to ersin-erdal/kibana
that referenced
this pull request
Dec 30, 2025
…elastic#246453) This PR adds length validation to the email params to prevent crushing errors. --------- Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co> (cherry picked from commit 0621884) # Conflicts: # src/platform/packages/shared/kbn-connector-schemas/email/schemas/v1.ts # x-pack/platform/plugins/shared/actions/server/integration_tests/__snapshots__/connector_types.test.ts.snap
ersin-erdal
added a commit
to ersin-erdal/kibana
that referenced
this pull request
Dec 30, 2025
…elastic#246453) This PR adds length validation to the email params to prevent crushing errors. --------- Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co> (cherry picked from commit 0621884) # Conflicts: # src/platform/packages/shared/kbn-connector-schemas/email/schemas/v1.ts # x-pack/platform/plugins/shared/actions/server/integration_tests/__snapshots__/connector_types.test.ts.snap
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
ersin-erdal
added a commit
to ersin-erdal/kibana
that referenced
this pull request
Dec 30, 2025
…elastic#246453) This PR adds length validation to the email params to prevent crushing errors. --------- Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co> (cherry picked from commit 0621884) # Conflicts: # src/platform/packages/shared/kbn-connector-schemas/email/schemas/v1.ts # x-pack/platform/plugins/shared/actions/server/integration_tests/__snapshots__/connector_types.test.ts.snap
ersin-erdal
added a commit
that referenced
this pull request
Dec 31, 2025
… config (#246453) (#247642) # Backport This will backport the following commits from `main` to `8.19`: - [Add max character validation to the email connector params and config (#246453)](#246453) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ersin Erdal","email":"92688503+ersin-erdal@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-12-30T11:18:55Z","message":"Add max character validation to the email connector params and config (#246453)\n\nThis PR adds length validation to the email params to prevent crushing\nerrors.\n\n---------\n\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>","sha":"06218847e4528caf724a541d9443c02339001982","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","backport:all-open","v9.3.0","v9.4.0"],"title":"Add max character validation to the email connector params and config","number":246453,"url":"https://github.com/elastic/kibana/pull/246453","mergeCommit":{"message":"Add max character validation to the email connector params and config (#246453)\n\nThis PR adds length validation to the email params to prevent crushing\nerrors.\n\n---------\n\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>","sha":"06218847e4528caf724a541d9443c02339001982"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/247600","number":247600,"state":"MERGED","mergeCommit":{"sha":"c5d5d8697c5d6d5ddd214c2deab73d7f7404659e","message":"[9.3] Add max character validation to the email connector params and config (#246453) (#247600)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.3`:\n- [Add max character validation to the email connector params and config\n(#246453)](https://github.com/elastic/kibana/pull/246453)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Ersin Erdal <92688503+ersin-erdal@users.noreply.github.com>\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>"}},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/246453","number":246453,"mergeCommit":{"message":"Add max character validation to the email connector params and config (#246453)\n\nThis PR adds length validation to the email params to prevent crushing\nerrors.\n\n---------\n\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>","sha":"06218847e4528caf724a541d9443c02339001982"}}]}] BACKPORT-->
ersin-erdal
added a commit
that referenced
this pull request
Dec 31, 2025
…config (#246453) (#247640) # Backport This will backport the following commits from `main` to `9.1`: - [Add max character validation to the email connector params and config (#246453)](#246453) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ersin Erdal","email":"92688503+ersin-erdal@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-12-30T11:18:55Z","message":"Add max character validation to the email connector params and config (#246453)\n\nThis PR adds length validation to the email params to prevent crushing\nerrors.\n\n---------\n\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>","sha":"06218847e4528caf724a541d9443c02339001982","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","backport:all-open","v9.3.0","v9.4.0"],"title":"Add max character validation to the email connector params and config","number":246453,"url":"https://github.com/elastic/kibana/pull/246453","mergeCommit":{"message":"Add max character validation to the email connector params and config (#246453)\n\nThis PR adds length validation to the email params to prevent crushing\nerrors.\n\n---------\n\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>","sha":"06218847e4528caf724a541d9443c02339001982"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/247600","number":247600,"state":"MERGED","mergeCommit":{"sha":"c5d5d8697c5d6d5ddd214c2deab73d7f7404659e","message":"[9.3] Add max character validation to the email connector params and config (#246453) (#247600)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.3`:\n- [Add max character validation to the email connector params and config\n(#246453)](https://github.com/elastic/kibana/pull/246453)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Ersin Erdal <92688503+ersin-erdal@users.noreply.github.com>\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>"}},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/246453","number":246453,"mergeCommit":{"message":"Add max character validation to the email connector params and config (#246453)\n\nThis PR adds length validation to the email params to prevent crushing\nerrors.\n\n---------\n\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>","sha":"06218847e4528caf724a541d9443c02339001982"}}]}] BACKPORT-->
ersin-erdal
added a commit
that referenced
this pull request
Dec 31, 2025
…config (#246453) (#247637) # Backport This will backport the following commits from `main` to `9.2`: - [Add max character validation to the email connector params and config (#246453)](#246453) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ersin Erdal","email":"92688503+ersin-erdal@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-12-30T11:18:55Z","message":"Add max character validation to the email connector params and config (#246453)\n\nThis PR adds length validation to the email params to prevent crushing\nerrors.\n\n---------\n\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>","sha":"06218847e4528caf724a541d9443c02339001982","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","backport:all-open","v9.3.0","v9.4.0"],"title":"Add max character validation to the email connector params and config","number":246453,"url":"https://github.com/elastic/kibana/pull/246453","mergeCommit":{"message":"Add max character validation to the email connector params and config (#246453)\n\nThis PR adds length validation to the email params to prevent crushing\nerrors.\n\n---------\n\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>","sha":"06218847e4528caf724a541d9443c02339001982"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/247600","number":247600,"state":"MERGED","mergeCommit":{"sha":"c5d5d8697c5d6d5ddd214c2deab73d7f7404659e","message":"[9.3] Add max character validation to the email connector params and config (#246453) (#247600)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.3`:\n- [Add max character validation to the email connector params and config\n(#246453)](https://github.com/elastic/kibana/pull/246453)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Ersin Erdal <92688503+ersin-erdal@users.noreply.github.com>\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>"}},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/246453","number":246453,"mergeCommit":{"message":"Add max character validation to the email connector params and config (#246453)\n\nThis PR adds length validation to the email params to prevent crushing\nerrors.\n\n---------\n\nCo-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>","sha":"06218847e4528caf724a541d9443c02339001982"}}]}] BACKPORT-->
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 6, 2026
…elastic#246453) This PR adds length validation to the email params to prevent crushing errors. --------- Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
walterra
pushed a commit
to walterra/kibana
that referenced
this pull request
Jan 7, 2026
…elastic#246453) This PR adds length validation to the email params to prevent crushing errors. --------- Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Jan 8, 2026
…elastic#246453) This PR adds length validation to the email params to prevent crushing errors. --------- Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds length validation to the email params to prevent crushing errors.