[ES|QL] Fixes not recognized GROK patterns#246871
Merged
momovdg merged 1 commit intoelastic:mainfrom Dec 19, 2025
Merged
Conversation
53ecc9f to
b42170f
Compare
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
History
cc @momovdg |
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
approved these changes
Dec 19, 2025
Contributor
stratoula
left a comment
There was a problem hiding this comment.
Thank you!
I changed the label to fix (this means that our release notes will mention it as a bug fix)
Contributor
|
Starting backport for target branches: 9.3 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 19, 2025
resolves elastic#246803 ## Summary Some patterns in the GROK command were not properly recognized and were producing unknown columns in the query. before <img width="743" height="815" alt="image" src="https://github.com/user-attachments/assets/417c16c3-cd61-40e4-bf43-aa3695e52e3d" /> after <img width="766" height="795" alt="image" src="https://github.com/user-attachments/assets/8323fcd2-d6a7-41f8-90cf-7eb7176639d1" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 24f3c3d)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 19, 2025
# Backport This will backport the following commits from `main` to `9.3`: - [[ES|QL] Fixes not recognized GROK patterns (#246871)](#246871) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Panagiotis Van de Goor","email":"44780623+momovdg@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-12-19T07:41:35Z","message":"[ES|QL] Fixes not recognized GROK patterns (#246871)\n\nresolves https://github.com/elastic/kibana/issues/246803\n\n## Summary\n\nSome patterns in the GROK command were not properly recognized and were\nproducing unknown columns in the query.\n\nbefore\n<img width=\"743\" height=\"815\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/417c16c3-cd61-40e4-bf43-aa3695e52e3d\"\n/>\n\nafter\n<img width=\"766\" height=\"795\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/8323fcd2-d6a7-41f8-90cf-7eb7176639d1\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"24f3c3d630a84ccb59c1b3a3f22d18b3f7dfebb6","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:ES|QL","Team:ESQL","backport:version","v9.3.0","v9.4.0"],"title":"[ES|QL] Fixes not recognized GROK patterns","number":246871,"url":"https://github.com/elastic/kibana/pull/246871","mergeCommit":{"message":"[ES|QL] Fixes not recognized GROK patterns (#246871)\n\nresolves https://github.com/elastic/kibana/issues/246803\n\n## Summary\n\nSome patterns in the GROK command were not properly recognized and were\nproducing unknown columns in the query.\n\nbefore\n<img width=\"743\" height=\"815\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/417c16c3-cd61-40e4-bf43-aa3695e52e3d\"\n/>\n\nafter\n<img width=\"766\" height=\"795\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/8323fcd2-d6a7-41f8-90cf-7eb7176639d1\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"24f3c3d630a84ccb59c1b3a3f22d18b3f7dfebb6"}},"sourceBranch":"main","suggestedTargetBranches":["9.3"],"targetPullRequestStates":[{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/246871","number":246871,"mergeCommit":{"message":"[ES|QL] Fixes not recognized GROK patterns (#246871)\n\nresolves https://github.com/elastic/kibana/issues/246803\n\n## Summary\n\nSome patterns in the GROK command were not properly recognized and were\nproducing unknown columns in the query.\n\nbefore\n<img width=\"743\" height=\"815\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/417c16c3-cd61-40e4-bf43-aa3695e52e3d\"\n/>\n\nafter\n<img width=\"766\" height=\"795\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/8323fcd2-d6a7-41f8-90cf-7eb7176639d1\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"24f3c3d630a84ccb59c1b3a3f22d18b3f7dfebb6"}}]}] BACKPORT--> Co-authored-by: Panagiotis Van de Goor <44780623+momovdg@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 6, 2026
resolves elastic#246803 ## Summary Some patterns in the GROK command were not properly recognized and were producing unknown columns in the query. before <img width="743" height="815" alt="image" src="https://github.com/user-attachments/assets/417c16c3-cd61-40e4-bf43-aa3695e52e3d" /> after <img width="766" height="795" alt="image" src="https://github.com/user-attachments/assets/8323fcd2-d6a7-41f8-90cf-7eb7176639d1" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #246803
Summary
Some patterns in the GROK command were not properly recognized and were producing unknown columns in the query.
before

after

Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelinesbackport:*labels.