[Discover] Should be able to complete all quickly opened tabs#246941
Merged
jughosta merged 5 commits intoelastic:mainfrom Jan 6, 2026
Merged
[Discover] Should be able to complete all quickly opened tabs#246941jughosta merged 5 commits intoelastic:mainfrom
jughosta merged 5 commits intoelastic:mainfrom
Conversation
jughosta
added
release_note:skip
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10164[✅] src/platform/test/functional/apps/discover/tabs/config.ts: 25/25 tests passed. |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
cc @jughosta |
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
davismcphee
approved these changes
Dec 19, 2025
Contributor
davismcphee
left a comment
davismcphee
left a comment
There was a problem hiding this comment.
Thanks for fixing it!
Comment on lines
+437
to
+442
| if (numberOfFetches > 0) { | ||
| subscription.unsubscribe(); | ||
| } else { | ||
| // to let the initial fetch to execute properly before unsubscribing | ||
| setTimeout(() => subscription.unsubscribe(), 200); | ||
| } |
Contributor
There was a problem hiding this comment.
I think ideally we'd extract the fetch$ subscription callback to a separate function and call it directly on init to avoid the debounce vs relying on a timeout. But that's also a higher impact change for something backported, so this is good for now. Still think it's worth doing at some point though.
Contributor
|
Starting backport for target branches: 9.2, 9.3 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 6, 2026
…c#246941) - Closes elastic#246406 ## Summary Unsubscribe was triggered too fast and it did not allow the initial fetch to even start to execute. This PR delays the unsubscribe and lets to fetch the data for the tab. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 3acd431)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 6, 2026
…c#246941) - Closes elastic#246406 ## Summary Unsubscribe was triggered too fast and it did not allow the initial fetch to even start to execute. This PR delays the unsubscribe and lets to fetch the data for the tab. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 3acd431)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 6, 2026
…246941) (#247910) # Backport This will backport the following commits from `main` to `9.3`: - [[Discover] Should be able to complete all quickly opened tabs (#246941)](#246941) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2026-01-06T08:34:19Z","message":"[Discover] Should be able to complete all quickly opened tabs (#246941)\n\n- Closes https://github.com/elastic/kibana/issues/246406\n\n## Summary\n\nUnsubscribe was triggered too fast and it did not allow the initial\nfetch to even start to execute. This PR delays the unsubscribe and lets\nto fetch the data for the tab.\n\n\n### Checklist\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"3acd4319f0be59d23d0302dadfab218397f5d10e","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","Project:OneDiscover","backport:version","v9.3.0","Feature:DiscoverTabs","v9.4.0","v9.2.4"],"title":"[Discover] Should be able to complete all quickly opened tabs","number":246941,"url":"https://github.com/elastic/kibana/pull/246941","mergeCommit":{"message":"[Discover] Should be able to complete all quickly opened tabs (#246941)\n\n- Closes https://github.com/elastic/kibana/issues/246406\n\n## Summary\n\nUnsubscribe was triggered too fast and it did not allow the initial\nfetch to even start to execute. This PR delays the unsubscribe and lets\nto fetch the data for the tab.\n\n\n### Checklist\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"3acd4319f0be59d23d0302dadfab218397f5d10e"}},"sourceBranch":"main","suggestedTargetBranches":["9.3","9.2"],"targetPullRequestStates":[{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/246941","number":246941,"mergeCommit":{"message":"[Discover] Should be able to complete all quickly opened tabs (#246941)\n\n- Closes https://github.com/elastic/kibana/issues/246406\n\n## Summary\n\nUnsubscribe was triggered too fast and it did not allow the initial\nfetch to even start to execute. This PR delays the unsubscribe and lets\nto fetch the data for the tab.\n\n\n### Checklist\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"3acd4319f0be59d23d0302dadfab218397f5d10e"}},{"branch":"9.2","label":"v9.2.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Jan 6, 2026
…246941) (#247909) # Backport This will backport the following commits from `main` to `9.2`: - [[Discover] Should be able to complete all quickly opened tabs (#246941)](#246941) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2026-01-06T08:34:19Z","message":"[Discover] Should be able to complete all quickly opened tabs (#246941)\n\n- Closes https://github.com/elastic/kibana/issues/246406\n\n## Summary\n\nUnsubscribe was triggered too fast and it did not allow the initial\nfetch to even start to execute. This PR delays the unsubscribe and lets\nto fetch the data for the tab.\n\n\n### Checklist\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"3acd4319f0be59d23d0302dadfab218397f5d10e","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","Project:OneDiscover","backport:version","v9.3.0","Feature:DiscoverTabs","v9.4.0","v9.2.4"],"title":"[Discover] Should be able to complete all quickly opened tabs","number":246941,"url":"https://github.com/elastic/kibana/pull/246941","mergeCommit":{"message":"[Discover] Should be able to complete all quickly opened tabs (#246941)\n\n- Closes https://github.com/elastic/kibana/issues/246406\n\n## Summary\n\nUnsubscribe was triggered too fast and it did not allow the initial\nfetch to even start to execute. This PR delays the unsubscribe and lets\nto fetch the data for the tab.\n\n\n### Checklist\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"3acd4319f0be59d23d0302dadfab218397f5d10e"}},"sourceBranch":"main","suggestedTargetBranches":["9.3","9.2"],"targetPullRequestStates":[{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/246941","number":246941,"mergeCommit":{"message":"[Discover] Should be able to complete all quickly opened tabs (#246941)\n\n- Closes https://github.com/elastic/kibana/issues/246406\n\n## Summary\n\nUnsubscribe was triggered too fast and it did not allow the initial\nfetch to even start to execute. This PR delays the unsubscribe and lets\nto fetch the data for the tab.\n\n\n### Checklist\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"3acd4319f0be59d23d0302dadfab218397f5d10e"}},{"branch":"9.2","label":"v9.2.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 6, 2026
…c#246941) - Closes elastic#246406 ## Summary Unsubscribe was triggered too fast and it did not allow the initial fetch to even start to execute. This PR delays the unsubscribe and lets to fetch the data for the tab. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Jan 8, 2026
…c#246941) - Closes elastic#246406 ## Summary Unsubscribe was triggered too fast and it did not allow the initial fetch to even start to execute. This PR delays the unsubscribe and lets to fetch the data for the tab. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
devamanv
pushed a commit
to devamanv/kibana
that referenced
this pull request
Jan 12, 2026
…c#246941) - Closes elastic#246406 ## Summary Unsubscribe was triggered too fast and it did not allow the initial fetch to even start to execute. This PR delays the unsubscribe and lets to fetch the data for the tab. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
20 tasks
florent-leborgne
added
release_note:fix
and removed
release_note:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unsubscribe was triggered too fast and it did not allow the initial fetch to even start to execute. This PR delays the unsubscribe and lets to fetch the data for the tab.
Checklist
release_note:*label is applied per the guidelinesbackport:*labels.