Skip to content

[Files Plugin] Fix createAuditEvents always returning failure as outcome#247152

Merged
kowalczyk-krzysztof merged 2 commits intoelastic:mainfrom
kowalczyk-krzysztof:fix/fix-file-outcome
Dec 25, 2025
Merged

[Files Plugin] Fix createAuditEvents always returning failure as outcome#247152
kowalczyk-krzysztof merged 2 commits intoelastic:mainfrom
kowalczyk-krzysztof:fix/fix-file-outcome

Conversation

@kowalczyk-krzysztof
Copy link
Member

@kowalczyk-krzysztof kowalczyk-krzysztof commented Dec 19, 2025

Summary

This PR fixes an operator precedence bug which causes the outcome to be failure even when an outcome is passed down.

Closes: #246926

@kowalczyk-krzysztof kowalczyk-krzysztof self-assigned this Dec 19, 2025
@kowalczyk-krzysztof kowalczyk-krzysztof requested a review from a team as a code owner December 19, 2025 16:46
@kowalczyk-krzysztof kowalczyk-krzysztof added bug Fixes for quality problems that affect the customer experience release_note:fix Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// backport:all-open Backport to all branches that could still receive a release labels Dec 19, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@kowalczyk-krzysztof kowalczyk-krzysztof enabled auto-merge (squash) December 19, 2025 18:49
@kowalczyk-krzysztof kowalczyk-krzysztof merged commit 5833938 into elastic:main Dec 25, 2025
14 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19, 9.1, 9.2, 9.3

https://github.com/elastic/kibana/actions/runs/20499013233

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #111 / Endpoint plugin @ess @serverless @skipInServerlessMKI Endpoint artifacts (via lists plugin): Trusted Applications "before all" hook in "@ess @serverless @skipInServerlessMKI Endpoint artifacts (via lists plugin): Trusted Applications"
  • [job] [logs] Scout: [ platform / streams_app ] plugin / serverless-oblt - Discover integration - Classic Stream - Navigate to Stream processing from document flyout - should navigate to Stream processing page from Discover document flyout in ES|QL mode
  • [job] [logs] Scout: [ platform / streams_app ] plugin / should navigate to Stream processing page from Discover document flyout in ES|QL mode
  • [job] [logs] FTR Configs #1 / task_manager scheduling and running tasks should schedule tasks with API keys if request is provided

Metrics [docs]

✅ unchanged

History

cc @kowalczyk-krzysztof

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 25, 2025
…ome (elastic#247152)

## Summary

This PR fixes an operator precedence bug which causes the `outcome` to
be `failure` even when an `outcome` is passed down.

Closes: elastic#246926
(cherry picked from commit 5833938)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 25, 2025
…ome (elastic#247152)

## Summary

This PR fixes an operator precedence bug which causes the `outcome` to
be `failure` even when an `outcome` is passed down.

Closes: elastic#246926
(cherry picked from commit 5833938)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 25, 2025
…ome (elastic#247152)

## Summary

This PR fixes an operator precedence bug which causes the `outcome` to
be `failure` even when an `outcome` is passed down.

Closes: elastic#246926
(cherry picked from commit 5833938)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 25, 2025
…ome (elastic#247152)

## Summary

This PR fixes an operator precedence bug which causes the `outcome` to
be `failure` even when an `outcome` is passed down.

Closes: elastic#246926
(cherry picked from commit 5833938)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.19
9.1
9.2
9.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 25, 2025
…s outcome (#247152) (#247480)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Files Plugin] Fix createAuditEvents always returning failure as
outcome (#247152)](#247152)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2025-12-25T04:32:12Z","message":"[Files
Plugin] Fix createAuditEvents always returning failure as outcome
(#247152)\n\n## Summary\n\nThis PR fixes an operator precedence bug
which causes the `outcome` to\nbe `failure` even when an `outcome` is
passed down.\n\nCloses:
https://github.com/elastic/kibana/issues/246926","sha":"5833938f0ea41db463d581cca694871186714540","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:SharedUX","backport:all-open","v9.4.0"],"title":"[Files
Plugin] Fix createAuditEvents always returning failure as
outcome","number":247152,"url":"https://github.com/elastic/kibana/pull/247152","mergeCommit":{"message":"[Files
Plugin] Fix createAuditEvents always returning failure as outcome
(#247152)\n\n## Summary\n\nThis PR fixes an operator precedence bug
which causes the `outcome` to\nbe `failure` even when an `outcome` is
passed down.\n\nCloses:
https://github.com/elastic/kibana/issues/246926","sha":"5833938f0ea41db463d581cca694871186714540"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/247152","number":247152,"mergeCommit":{"message":"[Files
Plugin] Fix createAuditEvents always returning failure as outcome
(#247152)\n\n## Summary\n\nThis PR fixes an operator precedence bug
which causes the `outcome` to\nbe `failure` even when an `outcome` is
passed down.\n\nCloses:
https://github.com/elastic/kibana/issues/246926","sha":"5833938f0ea41db463d581cca694871186714540"}}]}]
BACKPORT-->

Co-authored-by: Krzysztof Kowalczyk <krzysztof.kowalczyk@elastic.co>
kibanamachine added a commit that referenced this pull request Dec 25, 2025
…s outcome (#247152) (#247482)

# Backport

This will backport the following commits from `main` to `9.3`:
- [[Files Plugin] Fix createAuditEvents always returning failure as
outcome (#247152)](#247152)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2025-12-25T04:32:12Z","message":"[Files
Plugin] Fix createAuditEvents always returning failure as outcome
(#247152)\n\n## Summary\n\nThis PR fixes an operator precedence bug
which causes the `outcome` to\nbe `failure` even when an `outcome` is
passed down.\n\nCloses:
https://github.com/elastic/kibana/issues/246926","sha":"5833938f0ea41db463d581cca694871186714540","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:SharedUX","backport:all-open","v9.4.0"],"title":"[Files
Plugin] Fix createAuditEvents always returning failure as
outcome","number":247152,"url":"https://github.com/elastic/kibana/pull/247152","mergeCommit":{"message":"[Files
Plugin] Fix createAuditEvents always returning failure as outcome
(#247152)\n\n## Summary\n\nThis PR fixes an operator precedence bug
which causes the `outcome` to\nbe `failure` even when an `outcome` is
passed down.\n\nCloses:
https://github.com/elastic/kibana/issues/246926","sha":"5833938f0ea41db463d581cca694871186714540"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/247152","number":247152,"mergeCommit":{"message":"[Files
Plugin] Fix createAuditEvents always returning failure as outcome
(#247152)\n\n## Summary\n\nThis PR fixes an operator precedence bug
which causes the `outcome` to\nbe `failure` even when an `outcome` is
passed down.\n\nCloses:
https://github.com/elastic/kibana/issues/246926","sha":"5833938f0ea41db463d581cca694871186714540"}}]}]
BACKPORT-->

Co-authored-by: Krzysztof Kowalczyk <krzysztof.kowalczyk@elastic.co>
kibanamachine added a commit that referenced this pull request Dec 25, 2025
…s outcome (#247152) (#247481)

# Backport

This will backport the following commits from `main` to `9.2`:
- [[Files Plugin] Fix createAuditEvents always returning failure as
outcome (#247152)](#247152)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2025-12-25T04:32:12Z","message":"[Files
Plugin] Fix createAuditEvents always returning failure as outcome
(#247152)\n\n## Summary\n\nThis PR fixes an operator precedence bug
which causes the `outcome` to\nbe `failure` even when an `outcome` is
passed down.\n\nCloses:
https://github.com/elastic/kibana/issues/246926","sha":"5833938f0ea41db463d581cca694871186714540","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:SharedUX","backport:all-open","v9.4.0"],"title":"[Files
Plugin] Fix createAuditEvents always returning failure as
outcome","number":247152,"url":"https://github.com/elastic/kibana/pull/247152","mergeCommit":{"message":"[Files
Plugin] Fix createAuditEvents always returning failure as outcome
(#247152)\n\n## Summary\n\nThis PR fixes an operator precedence bug
which causes the `outcome` to\nbe `failure` even when an `outcome` is
passed down.\n\nCloses:
https://github.com/elastic/kibana/issues/246926","sha":"5833938f0ea41db463d581cca694871186714540"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/247152","number":247152,"mergeCommit":{"message":"[Files
Plugin] Fix createAuditEvents always returning failure as outcome
(#247152)\n\n## Summary\n\nThis PR fixes an operator precedence bug
which causes the `outcome` to\nbe `failure` even when an `outcome` is
passed down.\n\nCloses:
https://github.com/elastic/kibana/issues/246926","sha":"5833938f0ea41db463d581cca694871186714540"}}]}]
BACKPORT-->

Co-authored-by: Krzysztof Kowalczyk <krzysztof.kowalczyk@elastic.co>
kibanamachine added a commit that referenced this pull request Dec 25, 2025
…as outcome (#247152) (#247479)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Files Plugin] Fix createAuditEvents always returning failure as
outcome (#247152)](#247152)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2025-12-25T04:32:12Z","message":"[Files
Plugin] Fix createAuditEvents always returning failure as outcome
(#247152)\n\n## Summary\n\nThis PR fixes an operator precedence bug
which causes the `outcome` to\nbe `failure` even when an `outcome` is
passed down.\n\nCloses:
https://github.com/elastic/kibana/issues/246926","sha":"5833938f0ea41db463d581cca694871186714540","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:SharedUX","backport:all-open","v9.4.0"],"title":"[Files
Plugin] Fix createAuditEvents always returning failure as
outcome","number":247152,"url":"https://github.com/elastic/kibana/pull/247152","mergeCommit":{"message":"[Files
Plugin] Fix createAuditEvents always returning failure as outcome
(#247152)\n\n## Summary\n\nThis PR fixes an operator precedence bug
which causes the `outcome` to\nbe `failure` even when an `outcome` is
passed down.\n\nCloses:
https://github.com/elastic/kibana/issues/246926","sha":"5833938f0ea41db463d581cca694871186714540"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/247152","number":247152,"mergeCommit":{"message":"[Files
Plugin] Fix createAuditEvents always returning failure as outcome
(#247152)\n\n## Summary\n\nThis PR fixes an operator precedence bug
which causes the `outcome` to\nbe `failure` even when an `outcome` is
passed down.\n\nCloses:
https://github.com/elastic/kibana/issues/246926","sha":"5833938f0ea41db463d581cca694871186714540"}}]}]
BACKPORT-->

Co-authored-by: Krzysztof Kowalczyk <krzysztof.kowalczyk@elastic.co>
@kowalczyk-krzysztof kowalczyk-krzysztof deleted the fix/fix-file-outcome branch December 25, 2025 23:32
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 6, 2026
…ome (elastic#247152)

## Summary

This PR fixes an operator precedence bug which causes the `outcome` to
be `failure` even when an `outcome` is passed down.

Closes: elastic#246926
dej611 pushed a commit to dej611/kibana that referenced this pull request Jan 8, 2026
…ome (elastic#247152)

## Summary

This PR fixes an operator precedence bug which causes the `outcome` to
be `failure` even when an `outcome` is passed down.

Closes: elastic#246926
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:all-open Backport to all branches that could still receive a release bug Fixes for quality problems that affect the customer experience release_note:fix Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v8.19.10 v9.1.10 v9.2.4 v9.3.0 v9.4.0

4 participants