[Synthetics] Use monitor query id for project monitors package policies !!

[shahzad31]

Summary

In the Clean up package policies logic, Use monitor query id for project monitors package policies, since for project monitors package policy Id creation, id is used instead of config id of saved object.

This is causing synthetics clean up task to perform extra work and might cause it to timeout at 10m and cause unnecessary package policy clean up

[dominiqueclarke]

@benakansara @fkanout Context for why this change is needed

monitor.id is the ID of the monitor saved object. monitor.attributes.id is the id that is used when the monitor is ingested into the synthetics documents.

These values are often identical, but unfortunately diverge for project monitors. That is because instead of using the monitor saved object id as the ingested data's id, it uses a human readable id that is a combination of the monitor name, project id, and space id.

This code path actually wants the id used in the synthetics data, not the saved object id. We sometimes call it query id. There's a config key called ConfigKey.MONITOR_QUERY_ID that we sometimes use for it. The value of that enum is just id. So monitor.attributes[ConfigKey.MONITOR_QUERY_IDresolves just tomonitor.attributes.id`.

[jasonrhodes]

Thank you for this explanation, @dominiqueclarke, very helpful. Not necessarily an issue for right now but it concerns me that this requires this much explanation to understand ... it would be good to write down some ideas in an issue for the future, about how to simplify this for the sake of reducing these kinds of bug surfaces that I imagine come from people not really understanding the difference between these? (As always, I may misunderstand the root problem here.)

[dominiqueclarke]

I agree @jasonrhodes it's not an architectural decision I'm proud of, and it's hard to back out of.

[dominiqueclarke]

@jasonrhodes scheduled a meeting to discuss and find ways to back out of this nonsense.

[elasticmachine]

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

[elasticmachine]

💔 Build Failed

• Buildkite Build
• Commit: b9e0fc1

Failed CI Steps

• FTR Configs #86
• FTR Configs #86
• Scout: [ observability / observability ] plugin

Test Failures

• [job] [logs] FTR Configs #86 / dashboard app - group 6 dashboard snapshots compare controls snapshot in dark mode
• [job] [logs] FTR Configs #86 / dashboard app - group 6 dashboard snapshots compare controls snapshot in dark mode
• [job] [logs] Scout: [ observability / observability ] plugin / should display dashboard options in related dashboards dropdown when editing rule
• [job] [logs] Scout: [ observability / observability ] plugin / stateful - Rule Details Page - Admin - should display dashboard options in related dashboards dropdown when editing rule

Metrics [docs]

✅ unchanged

History

• 💔 Build #381544 failed bc91fed
• 💔 Build #381541 failed b33b854
• 💔 Build #380592 failed 5fdd989

[dominiqueclarke]

Tested this with a full migration from 8.19.0 to 8.19.8 (with the change applied). I couldn't test on main/the PR because of saved object migrations on the unreleased development branch.

Before you can see that 12500 policies (all from my test project monitors) are being recreated because they were all deleted.

[2026-01-14T15:16:39.926-05:00][DEBUG][plugins.synthetics] [SyncPrivateLocationMonitorsTask] Syncing private location monitors because cleanup performed a change
[2026-01-14T15:16:42.356-05:00][DEBUG][plugins.synthetics] [SyncPrivateLocationMonitorsTask] Processing spaceId: default, monitors count: 2500
[2026-01-14T15:16:42.357-05:00][DEBUG][plugins.synthetics] [SyncPrivateLocationMonitorsTask] Syncing private configs for spaceId: default, privateConfigs count: 2500
[2026-01-14T15:16:45.108-05:00][DEBUG][plugins.synthetics] [editingMonitors] Creating 12500 policies, updating 0 policies, and deleting 0 policies
[2026-01-14T23:32:51.522-05:00][ERROR][plugins.synthetics] Sync of private location monitors failed: Response aborted while reading the body

After

[2026-01-15T00:09:14.417-05:00][DEBUG][plugins.synthetics] [SyncPrivateLocationMonitorsTask] Syncing private location monitors, current task state is {"lastStartedAt":"2026-01-15T04:59:46.726Z","lastTotalParams":0,"lastTotalMWs":0}
[2026-01-15T00:09:14.418-05:00][DEBUG][plugins.synthetics] [SyncPrivateLocationMonitorsTask] Starting cleanup of duplicated package policies
[2026-01-15T00:09:18.689-05:00][DEBUG][plugins.synthetics] Installed synthetics index templates
[2026-01-15T00:09:18.949-05:00][DEBUG][plugins.synthetics] Found 0 params updated and 0 total params
[2026-01-15T00:09:18.951-05:00][DEBUG][plugins.synthetics] Found 0 maintenance windows updated and 0 total maintenance windows
[2026-01-15T00:09:18.951-05:00][DEBUG][plugins.synthetics] [SyncPrivateLocationMonitorsTask] No data has changed since last run 2026-01-15T04:59:46.726Z, skipping sync of private location monitors

All policies retained

[dominiqueclarke]

LGTM

[kibanamachine]

Starting backport for target branches: 8.19, 9.2, 9.3

https://github.com/elastic/kibana/actions/runs/21026800682

[kibanamachine]

💚 All backports created successfully

Status	Branch	Result
✅	8.19
✅	9.2
✅	9.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation