[Cases][Webhook] - Better handle 204 responses#251090

Merged

michaelolo24 merged 6 commits intoelastic:mainfrom

michaelolo24:improve-webhook-api-handling

Feb 2, 2026

Contributor

michaelolo24 commented Jan 30, 2026 •

edited by kibanamachine

Loading

Summary

Currently when an update is made to an external connector that returns a 204 no content response, the rest of the incident update fails. This should not occur as a 204 is a valid response

Checklist

Check the PR satisfies following conditions.

Unit or functional tests were updated or added to match the most common scenarios


          fix webhook api handling

fd0e8d5

michaelolo24 added the release_note:fix label

michaelolo24 requested a review from a team as a code owner

January 30, 2026 15:28

michaelolo24 added backport:version Team:Cases v9.2.5 v9.1.11 v9.3.1 labels

Contributor

elasticmachine commented Jan 30, 2026

Pinging @elastic/kibana-cases (Team:Cases)

mmahacek commented Jan 30, 2026

mmahacek linked an issue

that may be closed by this pull request

[Cases][Webhook] - 204 responses error on content type #251108

Closed

adcoelho reviewed

View reviewed changes

x-pack/platform/plugins/shared/stack_connectors/server/connector_types/cases_webhook/utils.ts Outdated

                 const data = res.data;
+                // If status is 204 and there is no data, we just return
+                if (res.status === 204 && isEmpty(data)) {

Contributor

adcoelho Feb 2, 2026

We could also make sure requiredAttributesToBeInTheResponse is not undefined here.

Contributor Author

michaelolo24 Feb 2, 2026

Good catch, will update, thanks!

adcoelho approved these changes

View reviewed changes

michaelolo24 added 2 commits

February 2, 2026 10:57


          add check for empty requiredAttributes list

dfa2bd1


          Merge remote-tracking branch 'upstream/main' into improve-webhook-api…

ea93690

…-handling

michaelolo24 added v9.3.0 bug labels

michaelolo24 enabled auto-merge (squash)

February 2, 2026 15:58

michaelolo24 and others added 3 commits

February 2, 2026 16:09


          fix test

3c0d6ee


          Merge remote-tracking branch 'upstream/main' into improve-webhook-api…

b81e3f2

…-handling


          Changes from yarn openapi:bundle

f20248b

Contributor

elasticmachine commented Feb 2, 2026

⏳ Build in-progress, with failures

Buildkite Build
Commit: b81e3f2

Failed CI Steps

Check OAS Snapshot

History

💔 Build #388777 failed ea93690
💔 Build #388085 failed fd0e8d5

michaelolo24 merged commit 926e3a2 into elastic:main

12 of 13 checks passed

kibanamachine mentioned this pull request

[Reporting] set zoom to 1 for long reports #248785

Merged

10 tasks

kibanamachine added the backport missing label

Contributor

kibanamachine commented Feb 4, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251090 locally
cc: @michaelolo24

4 similar comments

Contributor

kibanamachine commented Feb 6, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251090 locally
cc: @michaelolo24

Contributor

kibanamachine commented Feb 9, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251090 locally
cc: @michaelolo24

Contributor

kibanamachine commented Feb 10, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251090 locally
cc: @michaelolo24

Contributor

kibanamachine commented Feb 11, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251090 locally
cc: @michaelolo24

Contributor

kibanamachine commented Feb 12, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251090 locally
cc: @michaelolo24

michaelolo24 removed the v9.1.11 label

Contributor

kibanamachine commented Feb 13, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251090 locally
cc: @michaelolo24

5 similar comments

Contributor

kibanamachine commented Feb 16, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251090 locally
cc: @michaelolo24

Contributor

kibanamachine commented Feb 17, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251090 locally
cc: @michaelolo24

Contributor

kibanamachine commented Feb 18, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251090 locally
cc: @michaelolo24

Contributor

kibanamachine commented Feb 19, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251090 locally
cc: @michaelolo24

Contributor

kibanamachine commented Feb 20, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251090 locally
cc: @michaelolo24

mmahacek added (do not use) backport:9.2 (do not use) backport:9.3 (do not use) backport:8.19 and removed (do not use) backport:8.19 labels

Contributor

kibanamachine commented Feb 23, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251090 locally
cc: @michaelolo24

3 similar comments

Contributor

kibanamachine commented Feb 24, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251090 locally
cc: @michaelolo24

Contributor

kibanamachine commented Feb 25, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251090 locally
cc: @michaelolo24

Contributor

kibanamachine commented Feb 26, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 251090 locally
cc: @michaelolo24

mmahacek added the backport:all-open label

kibanamachine added the v9.4.0 label

Contributor

kibanamachine commented Feb 26, 2026

Starting backport for target branches: 8.19, 9.2, 9.3

https://github.com/elastic/kibana/actions/runs/22456464192

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request


          [Cases][Webhook] - Better handle 204 responses (elastic#251090)

22141f6

## Summary

Currently when an update is made to an external connector that returns a
`204` no content response, the rest of the incident update fails. This
should not occur as a 204 is a valid response

Fixes elastic#251108

### Checklist

Check the PR satisfies following conditions.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 926e3a2)

kibanamachine mentioned this pull request

[8.19] [Cases][Webhook] - Better handle 204 responses (#251090) #255167

Open

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request


          [Cases][Webhook] - Better handle 204 responses (elastic#251090)

db405d2

## Summary

Currently when an update is made to an external connector that returns a
`204` no content response, the rest of the incident update fails. This
should not occur as a 204 is a valid response

Fixes elastic#251108

### Checklist

Check the PR satisfies following conditions.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 926e3a2)

kibanamachine mentioned this pull request

[9.2] [Cases][Webhook] - Better handle 204 responses (#251090) #255168

Open

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request


          [Cases][Webhook] - Better handle 204 responses (elastic#251090)

8f3b1d1

## Summary

Currently when an update is made to an external connector that returns a
`204` no content response, the rest of the incident update fails. This
should not occur as a 204 is a valid response

Fixes elastic#251108

### Checklist

Check the PR satisfies following conditions.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 926e3a2)

kibanamachine mentioned this pull request

[9.3] [Cases][Webhook] - Better handle 204 responses (#251090) #255169

Open

Contributor

kibanamachine commented Feb 26, 2026

💚 All backports created successfully

Status	Branch	Result
✅	8.19
✅	9.2
✅	9.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Contributor

kibanamachine commented Feb 27, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @michaelolo24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:all-open backport missing backport:version bug (do not use) backport:9.2 (do not use) backport:9.3 release_note:fix Team:Cases v9.2.5 v9.3.0 v9.3.1 v9.4.0