[Console] Fix JSON highlighting inconsistencies for nested objects by kapral18 · Pull Request #255426 · elastic/kibana

kapral18 · 2026-03-02T03:11:09Z

Addresses #245820

Summary

Fixes an issue in Dev Tools Console where closing nested braces incorrectly returned the lexer to the root state, breaking syntax highlighting for subsequent elements.

Root Cause

The lexer rules matched any } to return to the root state, which caused it to pop out of the JSON context prematurely when encountering nested objects.

Fix

Updated the rule to only return to the root state when an unindented closing brace ends the line (/^}\s*/), keeping nested braces highlighted properly without state changes.
Added tests to cover nested objects highlighting and avoid stack limit issues.

Screenshots

Before

After

Test Plan

Run tests: yarn test:jest src/platform/packages/shared/kbn-monaco/src/languages/console/lexer_rules/shared.test.ts

Manual verification:

Open the Dev Tools Console in Kibana.

Paste the following request with nested JSON objects (as shown in the screenshots):

PUT console_highlight_bug_test2
{
  "mappings": {
    "properties": {
      "body": {
        "properties": {
          "properties": {
            "properties": {
              "structured": {
                "type": "object",
                "subobjects": false
              },
              "text": {
                "type": "match_only_text"
              }
            }
          },
          "event_name": {
            "type": "keyword"
          },
          "host": {
            "properties": {
              "name": {
                "type": "alias",
                "path": "resource.attributes.host.name"
              }
            }
          }
        }
      }
    }
  }
}

Verify that the syntax highlighting remains consistent and doesn't break (turn un-highlighted text/white) after the first nested closing brace }. Properties like "text", "event_name" and "host" should retain their correct coloring.

Release note

Fixes an issue in Dev Tools Console where closing nested braces broke syntax highlighting for subsequent elements.

Addresses an issue in the Dev Tools Console where closing nested braces incorrectly returned the lexer to the root state, breaking syntax highlighting for subsequent elements. It changes the rule to only return to the root state when an unindented closing brace ends the line, keeping nested braces highlighted properly without state changes. Made-with: Cursor

elasticmachine · 2026-03-02T03:13:03Z

Pinging @elastic/kibana-management (Team:Kibana Management)

elasticmachine · 2026-03-02T04:22:35Z

💚 Build Succeeded

Buildkite Build
Commit: 8918027

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kbnUiSharedDeps-srcJs`	4.7MB	4.7MB	+66.0B

SoniaSanzV

tested locally, lgtm!

kibanamachine · 2026-03-02T09:08:17Z

Starting backport for target branches: 8.19, 9.2, 9.3

https://github.com/elastic/kibana/actions/runs/22568942642

…lastic#255426) Addresses elastic#245820 ## Summary - Fixes an issue in Dev Tools Console where closing nested braces incorrectly returned the lexer to the root state, breaking syntax highlighting for subsequent elements. ## Root Cause - The lexer rules matched any `}` to return to the root state, which caused it to pop out of the JSON context prematurely when encountering nested objects. ## Fix - Updated the rule to only return to the root state when an unindented closing brace ends the line (`/^}\s*/`), keeping nested braces highlighted properly without state changes. - Added tests to cover nested objects highlighting and avoid stack limit issues. ## Screenshots ### Before <img width="1713" height="1083" alt="console_highlight_before" src="https://github.com/user-attachments/assets/46ac5181-ca61-46e8-be02-fd401e4bb6ad" /> ### After <img width="1708" height="1084" alt="console_highlight_after" src="https://github.com/user-attachments/assets/0ade816e-95ce-472e-b27b-31b048db4d12" /> ## Test Plan - Run tests: `yarn test:jest src/platform/packages/shared/kbn-monaco/src/languages/console/lexer_rules/shared.test.ts` - Manual verification: 1. Open the Dev Tools Console in Kibana. 2. Paste the following request with nested JSON objects (as shown in the screenshots): ```json PUT console_highlight_bug_test2 { "mappings": { "properties": { "body": { "properties": { "properties": { "properties": { "structured": { "type": "object", "subobjects": false }, "text": { "type": "match_only_text" } } }, "event_name": { "type": "keyword" }, "host": { "properties": { "name": { "type": "alias", "path": "resource.attributes.host.name" } } } } } } } } ``` 3. Verify that the syntax highlighting remains consistent and doesn't break (turn un-highlighted text/white) after the first nested closing brace `}`. Properties like `"text"`, `"event_name"` and `"host"` should retain their correct coloring. ## Release note Fixes an issue in Dev Tools Console where closing nested braces broke syntax highlighting for subsequent elements. (cherry picked from commit bdb1bfc)

kibanamachine · 2026-03-02T09:17:25Z

💔 Some backports could not be created

Status	Branch	Result
❌	8.19	Backport failed because of merge conflicts
✅	9.2
✅	9.3

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 255426

Questions ?

Please refer to the Backport tool documentation

…cts (#255426) (#255457) # Backport This will backport the following commits from `main` to `9.3`: - [[Console] Fix JSON highlighting inconsistencies for nested objects (#255426)](#255426)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Karen Grigoryan <karen.grigoryan@elastic.co>

…lastic#255426) Addresses elastic#245820 ## Summary - Fixes an issue in Dev Tools Console where closing nested braces incorrectly returned the lexer to the root state, breaking syntax highlighting for subsequent elements. ## Root Cause - The lexer rules matched any `}` to return to the root state, which caused it to pop out of the JSON context prematurely when encountering nested objects. ## Fix - Updated the rule to only return to the root state when an unindented closing brace ends the line (`/^}\s*/`), keeping nested braces highlighted properly without state changes. - Added tests to cover nested objects highlighting and avoid stack limit issues. ## Screenshots ### Before <img width="1713" height="1083" alt="console_highlight_before" src="https://github.com/user-attachments/assets/46ac5181-ca61-46e8-be02-fd401e4bb6ad" /> ### After <img width="1708" height="1084" alt="console_highlight_after" src="https://github.com/user-attachments/assets/0ade816e-95ce-472e-b27b-31b048db4d12" /> ## Test Plan - Run tests: `yarn test:jest src/platform/packages/shared/kbn-monaco/src/languages/console/lexer_rules/shared.test.ts` - Manual verification: 1. Open the Dev Tools Console in Kibana. 2. Paste the following request with nested JSON objects (as shown in the screenshots): ```json PUT console_highlight_bug_test2 { "mappings": { "properties": { "body": { "properties": { "properties": { "properties": { "structured": { "type": "object", "subobjects": false }, "text": { "type": "match_only_text" } } }, "event_name": { "type": "keyword" }, "host": { "properties": { "name": { "type": "alias", "path": "resource.attributes.host.name" } } } } } } } } ``` 3. Verify that the syntax highlighting remains consistent and doesn't break (turn un-highlighted text/white) after the first nested closing brace `}`. Properties like `"text"`, `"event_name"` and `"host"` should retain their correct coloring. ## Release note Fixes an issue in Dev Tools Console where closing nested braces broke syntax highlighting for subsequent elements.

…cts (#255426) (#255456) # Backport This will backport the following commits from `main` to `9.2`: - [[Console] Fix JSON highlighting inconsistencies for nested objects (#255426)](#255426)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Karen Grigoryan <karen.grigoryan@elastic.co>

…lastic#255426) Addresses elastic#245820 ## Summary - Fixes an issue in Dev Tools Console where closing nested braces incorrectly returned the lexer to the root state, breaking syntax highlighting for subsequent elements. ## Root Cause - The lexer rules matched any `}` to return to the root state, which caused it to pop out of the JSON context prematurely when encountering nested objects. ## Fix - Updated the rule to only return to the root state when an unindented closing brace ends the line (`/^}\s*/`), keeping nested braces highlighted properly without state changes. - Added tests to cover nested objects highlighting and avoid stack limit issues. ## Screenshots ### Before <img width="1713" height="1083" alt="console_highlight_before" src="https://github.com/user-attachments/assets/46ac5181-ca61-46e8-be02-fd401e4bb6ad" /> ### After <img width="1708" height="1084" alt="console_highlight_after" src="https://github.com/user-attachments/assets/0ade816e-95ce-472e-b27b-31b048db4d12" /> ## Test Plan - Run tests: `yarn test:jest src/platform/packages/shared/kbn-monaco/src/languages/console/lexer_rules/shared.test.ts` - Manual verification: 1. Open the Dev Tools Console in Kibana. 2. Paste the following request with nested JSON objects (as shown in the screenshots): ```json PUT console_highlight_bug_test2 { "mappings": { "properties": { "body": { "properties": { "properties": { "properties": { "structured": { "type": "object", "subobjects": false }, "text": { "type": "match_only_text" } } }, "event_name": { "type": "keyword" }, "host": { "properties": { "name": { "type": "alias", "path": "resource.attributes.host.name" } } } } } } } } ``` 3. Verify that the syntax highlighting remains consistent and doesn't break (turn un-highlighted text/white) after the first nested closing brace `}`. Properties like `"text"`, `"event_name"` and `"host"` should retain their correct coloring. ## Release note Fixes an issue in Dev Tools Console where closing nested braces broke syntax highlighting for subsequent elements. (cherry picked from commit bdb1bfc) # Conflicts: # src/platform/packages/shared/kbn-monaco/src/console/lexer_rules/shared.test.ts

kapral18 · 2026-03-02T12:31:09Z

💚 All backports created successfully

Status	Branch	Result
✅	8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine · 2026-03-04T11:49:32Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @kapral18

kibanamachine · 2026-03-05T12:49:15Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @kapral18

…ects (#255426) (#255516) # Backport This will backport the following commits from `main` to `8.19`: - [[Console] Fix JSON highlighting inconsistencies for nested objects (#255426)](#255426)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)

…lastic#255426) Addresses elastic#245820 ## Summary - Fixes an issue in Dev Tools Console where closing nested braces incorrectly returned the lexer to the root state, breaking syntax highlighting for subsequent elements. ## Root Cause - The lexer rules matched any `}` to return to the root state, which caused it to pop out of the JSON context prematurely when encountering nested objects. ## Fix - Updated the rule to only return to the root state when an unindented closing brace ends the line (`/^}\s*/`), keeping nested braces highlighted properly without state changes. - Added tests to cover nested objects highlighting and avoid stack limit issues. ## Screenshots ### Before <img width="1713" height="1083" alt="console_highlight_before" src="https://github.com/user-attachments/assets/46ac5181-ca61-46e8-be02-fd401e4bb6ad" /> ### After <img width="1708" height="1084" alt="console_highlight_after" src="https://github.com/user-attachments/assets/0ade816e-95ce-472e-b27b-31b048db4d12" /> ## Test Plan - Run tests: `yarn test:jest src/platform/packages/shared/kbn-monaco/src/languages/console/lexer_rules/shared.test.ts` - Manual verification: 1. Open the Dev Tools Console in Kibana. 2. Paste the following request with nested JSON objects (as shown in the screenshots): ```json PUT console_highlight_bug_test2 { "mappings": { "properties": { "body": { "properties": { "properties": { "properties": { "structured": { "type": "object", "subobjects": false }, "text": { "type": "match_only_text" } } }, "event_name": { "type": "keyword" }, "host": { "properties": { "name": { "type": "alias", "path": "resource.attributes.host.name" } } } } } } } } ``` 3. Verify that the syntax highlighting remains consistent and doesn't break (turn un-highlighted text/white) after the first nested closing brace `}`. Properties like `"text"`, `"event_name"` and `"host"` should retain their correct coloring. ## Release note Fixes an issue in Dev Tools Console where closing nested braces broke syntax highlighting for subsequent elements.

Closes elastic#256864 ## Summary Fixes a regression introduced in elastic#255426 where subsequent HTTP requests lose their highlighting if the preceding request body contains deeply nested objects with closing braces on their own lines. ### The Problem Because of a previous stack overflow bug (elastic#238531), Console's JSON lexer cannot use Monarch's `@push` and `@pop` states to track brace nesting depth. The state machine is flat. In elastic#255426, we tried to heuristic-guess the end of a JSON body by returning to the `root` state when encountering a `}` at the end of a line. However, this heuristic fails on deeply nested JSON where intermediate closing braces (like `}`) appear on their own lines. This caused the lexer to prematurely exit `json_root` and fall back to plain `text` tokenization for the rest of the body and subsequent requests. ### The Fix Instead of trying to guess when the JSON body ends using fragile regex heuristics, we use a more robust "resynchronization" pattern: 1. **`shared.ts` (JSON parser):** Removed the `}` -> `root` transition entirely. The lexer now stays safely inside `json_root` regardless of indentation or nesting. 2. **`console_editor.ts` (HTTP wrapper):** Injected the HTTP method recognition rules (`GET`, `POST`, `PUT`, etc.) directly into the `json_root` state. Now, the lexer stays in `json_root` (preserving all rich JSON highlighting) until it sees undeniable proof of a new request (an HTTP method or a `#!` warning comment) at the start of a line, at which point it breaks out and starts parsing the new request. ### Testing - Added unit tests to `shared.test.ts` to verify that intermediate closing braces do not break highlighting. - Added unit tests to verify that indented top-level closing braces correctly transition to the next request. - Verified manually using Playwright that deeply nested JSON (like `aggregations` and `_meta`) retains its highlighting. - Verified that all previous fixes (elastic#255426, elastic#255649, elastic#256286) remain intact. Made-with: Cursor

kapral18 requested a review from a team as a code owner March 2, 2026 03:11

kapral18 added release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// labels Mar 2, 2026

kapral18 changed the title ~~fix(console): fix JSON highlighting inconsistencies for nested objects~~ Mar 2, 2026

kapral18 added bug Fixes for quality problems that affect the customer experience and removed Feature:Dev Tools labels Mar 2, 2026

SoniaSanzV approved these changes Mar 2, 2026

View reviewed changes

kapral18 merged commit bdb1bfc into elastic:main Mar 2, 2026
55 checks passed

kapral18 deleted the fix/console/fix-highlighting-inconsistencies-245820 branch March 2, 2026 09:07

kibanamachine added the v9.4.0 label Mar 2, 2026

kapral18 mentioned this pull request Mar 2, 2026

[Console] Inconsistencies in text highlighting #245820

Closed

kibanamachine mentioned this pull request Mar 2, 2026

[9.2] [Console] Fix JSON highlighting inconsistencies for nested objects (#255426) #255456

Merged

kibanamachine mentioned this pull request Mar 2, 2026

[9.3] [Console] Fix JSON highlighting inconsistencies for nested objects (#255426) #255457

Merged

kibanamachine added the v9.3.2 label Mar 2, 2026

kibanamachine added the v9.2.7 label Mar 2, 2026

kapral18 mentioned this pull request Mar 2, 2026

[8.19] [Console] Fix JSON highlighting inconsistencies for nested objects (#255426) #255516

Merged

kapral18 mentioned this pull request Mar 2, 2026

[Kibana Dev Tools] Syntax Coloring & keyboard typing impact Issues #232836

Closed

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 4, 2026

kibanamachine added v8.19.13 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Mar 6, 2026

ElenaStoeva mentioned this pull request Mar 12, 2026

[Console] Missing syntax highlighting on verb + path when body is indented #256864

Closed

kapral18 mentioned this pull request Mar 13, 2026

[Console] Fix indented body highlighting regression #257539

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Console] Fix JSON highlighting inconsistencies for nested objects#255426

[Console] Fix JSON highlighting inconsistencies for nested objects#255426
kapral18 merged 1 commit intoelastic:mainfrom
kapral18:fix/console/fix-highlighting-inconsistencies-245820

kapral18 commented Mar 2, 2026 •

edited by kibanamachine

Loading

elasticmachine commented Mar 2, 2026

elasticmachine commented Mar 2, 2026

SoniaSanzV left a comment

Uh oh!

kibanamachine commented Mar 2, 2026

kibanamachine commented Mar 2, 2026

kapral18 commented Mar 2, 2026

kibanamachine commented Mar 4, 2026

kibanamachine commented Mar 5, 2026

Labels

4 participants

Conversation

kapral18 commented Mar 2, 2026 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Root Cause

Fix

Screenshots

Before

After

Test Plan

Release note

elasticmachine commented Mar 2, 2026

elasticmachine commented Mar 2, 2026

💚 Build Succeeded

Metrics [docs]

Page load bundle

SoniaSanzV left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Mar 2, 2026

kibanamachine commented Mar 2, 2026

💔 Some backports could not be created

Manual backport

Questions ?

kapral18 commented Mar 2, 2026

💚 All backports created successfully

Questions ?

kibanamachine commented Mar 4, 2026

kibanamachine commented Mar 5, 2026

Labels

4 participants

kapral18 commented Mar 2, 2026 •

edited by kibanamachine

Loading