[Ingest pipelines] Fix processors accessibility announcements#259096
Merged
SoniaSanzV merged 5 commits intoelastic:mainfrom Mar 25, 2026
Merged
Conversation
SoniaSanzV
added
Team:Kibana Management
Contributor
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
SoniaSanzV
changed the title
Contributor
📝 WalkthroughWalkthroughThe changes introduce processor-specific accessibility enhancements to the ingest pipeline editor's move functionality. They add human-readable processor labels to move buttons and drop-zone controls, localized accessibility announcements for move operations using context-aware labels, focus restoration to the moved processor after relocation, and screen reader announcements via 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Comment |
![coderabbitai[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@x-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/context/move_a11y.ts`:
- Around line 14-20: getScopeLabel incorrectly treats any selector that includes
'onFailure' but has the first element 'onFailure' as "failure processors",
causing nested selectors like ['onFailure','0','onFailure','0'] to be labeled
wrong; update the logic in getScopeLabel (and mirror the change in
processorsTreeI18nTexts.getSectionLabelForSelector()) to compute the index of
the first 'onFailure' (e.g., const firstOnFailure =
selector.indexOf('onFailure')) and use firstOnFailure === 0 to choose
destinationScope.failureProcessors, otherwise choose
destinationScope.failureHandlers, keeping the initial hasOnFailure check to
return processors when absent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 6896bc54-dd5e-4477-b02b-c692de83fc75
📒 Files selected for processing (13)
x-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/components/pipeline_processors_editor.tsxx-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/components/pipeline_processors_editor_item/i18n_texts.tsx-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/components/pipeline_processors_editor_item/pipeline_processors_editor_item.tsxx-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/components/pipeline_processors_editor_item_status.tsxx-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/components/processors_tree/components/drop_zone_button.tsxx-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/components/processors_tree/components/private_tree.tsxx-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/components/processors_tree/components/tree_node.tsxx-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/components/processors_tree/i18n_texts.tsx-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/components/processors_tree/processors_tree.tsxx-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/context/i18n_texts.tsx-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/context/move_a11y.test.tsx-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/context/move_a11y.tsx-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/context/processors_context.tsx
kapral18
reviewed
Mar 24, 2026
Contributor
There was a problem hiding this comment.
Nice a11y improvement overall (move completion announcement + focus restore).
One correctness gap (already flagged by CodeRabbit): #259096 (comment)
I reproduced locally that nested onFailure selectors rooted in the top-level onFailure tree (e.g. ["onFailure","0","onFailure","0"]) are labeled as “Failure processors” but should be “Failure handlers”.
Suggestion: base the label on onFailure depth and apply consistently in both the move announcement scope labeling + processors_tree/i18n_texts.ts#getSectionLabelForSelector.
kapral18
reviewed
Mar 24, 2026
kapral18
reviewed
Mar 24, 2026
SoniaSanzV
added
release_note:fix
and removed
release_note:skip
kapral18
approved these changes
Mar 24, 2026
Contributor
💔 Build Failed
Failed CI StepsMetrics [docs]Module Count
Async chunks
Historycc @SoniaSanzV |
Contributor
|
Starting backport for target branches: 8.19, 9.2, 9.3 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 25, 2026
…c#259096) Closes elastic#218245 Closes elastic#218210 ## Summary - Improve ingest pipeline processor move accessibility by reliably announcing move completion and restoring focus to the moved processor. - Added a new test file `yarn test:jest x-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/context/move_a11y.test.ts` **Before** - **Move targets were ambiguous**: while moving, NVDA announced only “Move here” / “Cannot move here” without indicating *where* the processor would be inserted (from/to context). - **Confirmation + focus after drop were broken/inconsistent**: - After placing with **Space**: focus was missing and a different processor could be announced. - After placing with **Enter**: sometimes **no announcement** at all (unclear whether the move succeeded). - **Move button lacked processor context**: navigating rows announced “Move this processor” without the processor name. **After**: - **Move button name includes processor context** (processor name is included with the Move/Cancel control label). - **Drop zones announce specific targets** (before/after + section context), not just generic “move here”. - **After dropping, the move completion is announced and focus is restored to the moved processor** (works in NVDA/Chrome and VO per our manual verification). ### Test plan - Manual: - VoiceOver (macOS): enter move mode, move within/across sections; verify confirmation announcement + focus. - If the reviewer has NVDA (Windows) set up, same flow. ### Demo **Windows+NVDA** https://github.com/user-attachments/assets/d513e371-b578-4f8c-91f6-9c459dacb0bb **Safari + Voice Over** https://github.com/user-attachments/assets/bf61f013-f7f4-461a-aaab-a6709d50b84d (cherry picked from commit 7dcb394)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 25, 2026
…c#259096) Closes elastic#218245 Closes elastic#218210 ## Summary - Improve ingest pipeline processor move accessibility by reliably announcing move completion and restoring focus to the moved processor. - Added a new test file `yarn test:jest x-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/context/move_a11y.test.ts` **Before** - **Move targets were ambiguous**: while moving, NVDA announced only “Move here” / “Cannot move here” without indicating *where* the processor would be inserted (from/to context). - **Confirmation + focus after drop were broken/inconsistent**: - After placing with **Space**: focus was missing and a different processor could be announced. - After placing with **Enter**: sometimes **no announcement** at all (unclear whether the move succeeded). - **Move button lacked processor context**: navigating rows announced “Move this processor” without the processor name. **After**: - **Move button name includes processor context** (processor name is included with the Move/Cancel control label). - **Drop zones announce specific targets** (before/after + section context), not just generic “move here”. - **After dropping, the move completion is announced and focus is restored to the moved processor** (works in NVDA/Chrome and VO per our manual verification). ### Test plan - Manual: - VoiceOver (macOS): enter move mode, move within/across sections; verify confirmation announcement + focus. - If the reviewer has NVDA (Windows) set up, same flow. ### Demo **Windows+NVDA** https://github.com/user-attachments/assets/d513e371-b578-4f8c-91f6-9c459dacb0bb **Safari + Voice Over** https://github.com/user-attachments/assets/bf61f013-f7f4-461a-aaab-a6709d50b84d (cherry picked from commit 7dcb394)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 25, 2026
…259096) (#259531) # Backport This will backport the following commits from `main` to `9.2`: - [[Ingest pipelines] Fix processors accessibility announcements (#259096)](#259096) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sonia Sanz Vivas","email":"sonia.sanzvivas@elastic.co"},"sourceCommit":{"committedDate":"2026-03-25T10:35:37Z","message":"[Ingest pipelines] Fix processors accessibility announcements (#259096)\n\nCloses https://github.com/elastic/kibana/issues/218245\nCloses https://github.com/elastic/kibana/issues/218210\n## Summary\n- Improve ingest pipeline processor move accessibility by reliably\nannouncing move completion and restoring focus to the moved processor.\n- Added a new test file `yarn test:jest\nx-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/context/move_a11y.test.ts`\n**Before**\n- **Move targets were ambiguous**: while moving, NVDA announced only\n“Move here” / “Cannot move here” without indicating *where* the\nprocessor would be inserted (from/to context).\n- **Confirmation + focus after drop were broken/inconsistent**:\n- After placing with **Space**: focus was missing and a different\nprocessor could be announced.\n- After placing with **Enter**: sometimes **no announcement** at all\n(unclear whether the move succeeded).\n- **Move button lacked processor context**: navigating rows announced\n“Move this processor” without the processor name.\n\n**After**:\n- **Move button name includes processor context** (processor name is\nincluded with the Move/Cancel control label).\n- **Drop zones announce specific targets** (before/after + section\ncontext), not just generic “move here”.\n- **After dropping, the move completion is announced and focus is\nrestored to the moved processor** (works in NVDA/Chrome and VO per our\nmanual verification).\n### Test plan\n- Manual:\n- VoiceOver (macOS): enter move mode, move within/across sections;\nverify confirmation announcement + focus.\n - If the reviewer has NVDA (Windows) set up, same flow.\n\n### Demo\n\n**Windows+NVDA**\n\n\n\nhttps://github.com/user-attachments/assets/d513e371-b578-4f8c-91f6-9c459dacb0bb\n\n\n\n**Safari + Voice Over**\n\n\n\nhttps://github.com/user-attachments/assets/bf61f013-f7f4-461a-aaab-a6709d50b84d","sha":"7dcb39475e94a3481d4b3266219868402928f181","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Kibana Management","Feature:Ingest Node Pipelines","backport:all-open","v9.4.0"],"title":"[Ingest pipelines] Fix processors accessibility announcements","number":259096,"url":"https://github.com/elastic/kibana/pull/259096","mergeCommit":{"message":"[Ingest pipelines] Fix processors accessibility announcements (#259096)\n\nCloses https://github.com/elastic/kibana/issues/218245\nCloses https://github.com/elastic/kibana/issues/218210\n## Summary\n- Improve ingest pipeline processor move accessibility by reliably\nannouncing move completion and restoring focus to the moved processor.\n- Added a new test file `yarn test:jest\nx-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/context/move_a11y.test.ts`\n**Before**\n- **Move targets were ambiguous**: while moving, NVDA announced only\n“Move here” / “Cannot move here” without indicating *where* the\nprocessor would be inserted (from/to context).\n- **Confirmation + focus after drop were broken/inconsistent**:\n- After placing with **Space**: focus was missing and a different\nprocessor could be announced.\n- After placing with **Enter**: sometimes **no announcement** at all\n(unclear whether the move succeeded).\n- **Move button lacked processor context**: navigating rows announced\n“Move this processor” without the processor name.\n\n**After**:\n- **Move button name includes processor context** (processor name is\nincluded with the Move/Cancel control label).\n- **Drop zones announce specific targets** (before/after + section\ncontext), not just generic “move here”.\n- **After dropping, the move completion is announced and focus is\nrestored to the moved processor** (works in NVDA/Chrome and VO per our\nmanual verification).\n### Test plan\n- Manual:\n- VoiceOver (macOS): enter move mode, move within/across sections;\nverify confirmation announcement + focus.\n - If the reviewer has NVDA (Windows) set up, same flow.\n\n### Demo\n\n**Windows+NVDA**\n\n\n\nhttps://github.com/user-attachments/assets/d513e371-b578-4f8c-91f6-9c459dacb0bb\n\n\n\n**Safari + Voice Over**\n\n\n\nhttps://github.com/user-attachments/assets/bf61f013-f7f4-461a-aaab-a6709d50b84d","sha":"7dcb39475e94a3481d4b3266219868402928f181"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/259096","number":259096,"mergeCommit":{"message":"[Ingest pipelines] Fix processors accessibility announcements (#259096)\n\nCloses https://github.com/elastic/kibana/issues/218245\nCloses https://github.com/elastic/kibana/issues/218210\n## Summary\n- Improve ingest pipeline processor move accessibility by reliably\nannouncing move completion and restoring focus to the moved processor.\n- Added a new test file `yarn test:jest\nx-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/context/move_a11y.test.ts`\n**Before**\n- **Move targets were ambiguous**: while moving, NVDA announced only\n“Move here” / “Cannot move here” without indicating *where* the\nprocessor would be inserted (from/to context).\n- **Confirmation + focus after drop were broken/inconsistent**:\n- After placing with **Space**: focus was missing and a different\nprocessor could be announced.\n- After placing with **Enter**: sometimes **no announcement** at all\n(unclear whether the move succeeded).\n- **Move button lacked processor context**: navigating rows announced\n“Move this processor” without the processor name.\n\n**After**:\n- **Move button name includes processor context** (processor name is\nincluded with the Move/Cancel control label).\n- **Drop zones announce specific targets** (before/after + section\ncontext), not just generic “move here”.\n- **After dropping, the move completion is announced and focus is\nrestored to the moved processor** (works in NVDA/Chrome and VO per our\nmanual verification).\n### Test plan\n- Manual:\n- VoiceOver (macOS): enter move mode, move within/across sections;\nverify confirmation announcement + focus.\n - If the reviewer has NVDA (Windows) set up, same flow.\n\n### Demo\n\n**Windows+NVDA**\n\n\n\nhttps://github.com/user-attachments/assets/d513e371-b578-4f8c-91f6-9c459dacb0bb\n\n\n\n**Safari + Voice Over**\n\n\n\nhttps://github.com/user-attachments/assets/bf61f013-f7f4-461a-aaab-a6709d50b84d","sha":"7dcb39475e94a3481d4b3266219868402928f181"}}]}] BACKPORT--> Co-authored-by: Sonia Sanz Vivas <sonia.sanzvivas@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 25, 2026
…259096) (#259532) # Backport This will backport the following commits from `main` to `9.3`: - [[Ingest pipelines] Fix processors accessibility announcements (#259096)](#259096) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sonia Sanz Vivas","email":"sonia.sanzvivas@elastic.co"},"sourceCommit":{"committedDate":"2026-03-25T10:35:37Z","message":"[Ingest pipelines] Fix processors accessibility announcements (#259096)\n\nCloses https://github.com/elastic/kibana/issues/218245\nCloses https://github.com/elastic/kibana/issues/218210\n## Summary\n- Improve ingest pipeline processor move accessibility by reliably\nannouncing move completion and restoring focus to the moved processor.\n- Added a new test file `yarn test:jest\nx-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/context/move_a11y.test.ts`\n**Before**\n- **Move targets were ambiguous**: while moving, NVDA announced only\n“Move here” / “Cannot move here” without indicating *where* the\nprocessor would be inserted (from/to context).\n- **Confirmation + focus after drop were broken/inconsistent**:\n- After placing with **Space**: focus was missing and a different\nprocessor could be announced.\n- After placing with **Enter**: sometimes **no announcement** at all\n(unclear whether the move succeeded).\n- **Move button lacked processor context**: navigating rows announced\n“Move this processor” without the processor name.\n\n**After**:\n- **Move button name includes processor context** (processor name is\nincluded with the Move/Cancel control label).\n- **Drop zones announce specific targets** (before/after + section\ncontext), not just generic “move here”.\n- **After dropping, the move completion is announced and focus is\nrestored to the moved processor** (works in NVDA/Chrome and VO per our\nmanual verification).\n### Test plan\n- Manual:\n- VoiceOver (macOS): enter move mode, move within/across sections;\nverify confirmation announcement + focus.\n - If the reviewer has NVDA (Windows) set up, same flow.\n\n### Demo\n\n**Windows+NVDA**\n\n\n\nhttps://github.com/user-attachments/assets/d513e371-b578-4f8c-91f6-9c459dacb0bb\n\n\n\n**Safari + Voice Over**\n\n\n\nhttps://github.com/user-attachments/assets/bf61f013-f7f4-461a-aaab-a6709d50b84d","sha":"7dcb39475e94a3481d4b3266219868402928f181","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Kibana Management","Feature:Ingest Node Pipelines","backport:all-open","v9.4.0"],"title":"[Ingest pipelines] Fix processors accessibility announcements","number":259096,"url":"https://github.com/elastic/kibana/pull/259096","mergeCommit":{"message":"[Ingest pipelines] Fix processors accessibility announcements (#259096)\n\nCloses https://github.com/elastic/kibana/issues/218245\nCloses https://github.com/elastic/kibana/issues/218210\n## Summary\n- Improve ingest pipeline processor move accessibility by reliably\nannouncing move completion and restoring focus to the moved processor.\n- Added a new test file `yarn test:jest\nx-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/context/move_a11y.test.ts`\n**Before**\n- **Move targets were ambiguous**: while moving, NVDA announced only\n“Move here” / “Cannot move here” without indicating *where* the\nprocessor would be inserted (from/to context).\n- **Confirmation + focus after drop were broken/inconsistent**:\n- After placing with **Space**: focus was missing and a different\nprocessor could be announced.\n- After placing with **Enter**: sometimes **no announcement** at all\n(unclear whether the move succeeded).\n- **Move button lacked processor context**: navigating rows announced\n“Move this processor” without the processor name.\n\n**After**:\n- **Move button name includes processor context** (processor name is\nincluded with the Move/Cancel control label).\n- **Drop zones announce specific targets** (before/after + section\ncontext), not just generic “move here”.\n- **After dropping, the move completion is announced and focus is\nrestored to the moved processor** (works in NVDA/Chrome and VO per our\nmanual verification).\n### Test plan\n- Manual:\n- VoiceOver (macOS): enter move mode, move within/across sections;\nverify confirmation announcement + focus.\n - If the reviewer has NVDA (Windows) set up, same flow.\n\n### Demo\n\n**Windows+NVDA**\n\n\n\nhttps://github.com/user-attachments/assets/d513e371-b578-4f8c-91f6-9c459dacb0bb\n\n\n\n**Safari + Voice Over**\n\n\n\nhttps://github.com/user-attachments/assets/bf61f013-f7f4-461a-aaab-a6709d50b84d","sha":"7dcb39475e94a3481d4b3266219868402928f181"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/259096","number":259096,"mergeCommit":{"message":"[Ingest pipelines] Fix processors accessibility announcements (#259096)\n\nCloses https://github.com/elastic/kibana/issues/218245\nCloses https://github.com/elastic/kibana/issues/218210\n## Summary\n- Improve ingest pipeline processor move accessibility by reliably\nannouncing move completion and restoring focus to the moved processor.\n- Added a new test file `yarn test:jest\nx-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/context/move_a11y.test.ts`\n**Before**\n- **Move targets were ambiguous**: while moving, NVDA announced only\n“Move here” / “Cannot move here” without indicating *where* the\nprocessor would be inserted (from/to context).\n- **Confirmation + focus after drop were broken/inconsistent**:\n- After placing with **Space**: focus was missing and a different\nprocessor could be announced.\n- After placing with **Enter**: sometimes **no announcement** at all\n(unclear whether the move succeeded).\n- **Move button lacked processor context**: navigating rows announced\n“Move this processor” without the processor name.\n\n**After**:\n- **Move button name includes processor context** (processor name is\nincluded with the Move/Cancel control label).\n- **Drop zones announce specific targets** (before/after + section\ncontext), not just generic “move here”.\n- **After dropping, the move completion is announced and focus is\nrestored to the moved processor** (works in NVDA/Chrome and VO per our\nmanual verification).\n### Test plan\n- Manual:\n- VoiceOver (macOS): enter move mode, move within/across sections;\nverify confirmation announcement + focus.\n - If the reviewer has NVDA (Windows) set up, same flow.\n\n### Demo\n\n**Windows+NVDA**\n\n\n\nhttps://github.com/user-attachments/assets/d513e371-b578-4f8c-91f6-9c459dacb0bb\n\n\n\n**Safari + Voice Over**\n\n\n\nhttps://github.com/user-attachments/assets/bf61f013-f7f4-461a-aaab-a6709d50b84d","sha":"7dcb39475e94a3481d4b3266219868402928f181"}}]}] BACKPORT--> Co-authored-by: Sonia Sanz Vivas <sonia.sanzvivas@elastic.co>
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Mar 26, 2026
…c#259096) Closes elastic#218245 Closes elastic#218210 ## Summary - Improve ingest pipeline processor move accessibility by reliably announcing move completion and restoring focus to the moved processor. - Added a new test file `yarn test:jest x-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/context/move_a11y.test.ts` **Before** - **Move targets were ambiguous**: while moving, NVDA announced only “Move here” / “Cannot move here” without indicating *where* the processor would be inserted (from/to context). - **Confirmation + focus after drop were broken/inconsistent**: - After placing with **Space**: focus was missing and a different processor could be announced. - After placing with **Enter**: sometimes **no announcement** at all (unclear whether the move succeeded). - **Move button lacked processor context**: navigating rows announced “Move this processor” without the processor name. **After**: - **Move button name includes processor context** (processor name is included with the Move/Cancel control label). - **Drop zones announce specific targets** (before/after + section context), not just generic “move here”. - **After dropping, the move completion is announced and focus is restored to the moved processor** (works in NVDA/Chrome and VO per our manual verification). ### Test plan - Manual: - VoiceOver (macOS): enter move mode, move within/across sections; verify confirmation announcement + focus. - If the reviewer has NVDA (Windows) set up, same flow. ### Demo **Windows+NVDA** https://github.com/user-attachments/assets/d513e371-b578-4f8c-91f6-9c459dacb0bb **Safari + Voice Over** https://github.com/user-attachments/assets/bf61f013-f7f4-461a-aaab-a6709d50b84d
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Apr 1, 2026
…c#259096) Closes elastic#218245 Closes elastic#218210 ## Summary - Improve ingest pipeline processor move accessibility by reliably announcing move completion and restoring focus to the moved processor. - Added a new test file `yarn test:jest x-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/context/move_a11y.test.ts` **Before** - **Move targets were ambiguous**: while moving, NVDA announced only “Move here” / “Cannot move here” without indicating *where* the processor would be inserted (from/to context). - **Confirmation + focus after drop were broken/inconsistent**: - After placing with **Space**: focus was missing and a different processor could be announced. - After placing with **Enter**: sometimes **no announcement** at all (unclear whether the move succeeded). - **Move button lacked processor context**: navigating rows announced “Move this processor” without the processor name. **After**: - **Move button name includes processor context** (processor name is included with the Move/Cancel control label). - **Drop zones announce specific targets** (before/after + section context), not just generic “move here”. - **After dropping, the move completion is announced and focus is restored to the moved processor** (works in NVDA/Chrome and VO per our manual verification). ### Test plan - Manual: - VoiceOver (macOS): enter move mode, move within/across sections; verify confirmation announcement + focus. - If the reviewer has NVDA (Windows) set up, same flow. ### Demo **Windows+NVDA** https://github.com/user-attachments/assets/d513e371-b578-4f8c-91f6-9c459dacb0bb **Safari + Voice Over** https://github.com/user-attachments/assets/bf61f013-f7f4-461a-aaab-a6709d50b84d
SoniaSanzV
deleted the
a11y/ingest_pipelines-processors-announcements#218245
branch
SoniaSanzV
added
backport:version
Contributor
|
Starting backport for target branches: 9.2, 9.3 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #218245
Closes #218210
Summary
yarn test:jest x-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/context/move_a11y.test.tsBefore
After:
Test plan
Demo
Windows+NVDA
edge.mov
Safari + Voice Over
safari.mov