[Ingest pipelines] A11y: Avoid icon announcement duplication#259185
Merged
SoniaSanzV merged 7 commits intoelastic:mainfrom Apr 10, 2026
Merged
Conversation
SoniaSanzV
added
release_note:fix
Team:Kibana Management
Contributor
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
kapral18
reviewed
Mar 23, 2026
| }; | ||
|
|
||
| return <EuiInMemoryTable {...tableProps} />; | ||
| return <EuiInMemoryTable tableCaption={tableCaption} {...tableProps} />; |
Contributor
There was a problem hiding this comment.
for my understanding, can you clarify what is the point of extracting tableCaption from tableProps?
Contributor
Author
There was a problem hiding this comment.
It's just an A11y request from the component
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughMemoized i18n-derived constants for action texts (edit, duplicate, delete) were added and reused in the table actions, replacing prior inline translate calls and separate label variables. A standalone ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Comment |
sabarasaba
approved these changes
Apr 10, 2026
Member
sabarasaba
left a comment
sabarasaba
left a comment
There was a problem hiding this comment.
latest lgtm, we tested together locally 🚀
Contributor
|
Starting backport for target branches: 8.19, 9.2, 9.3 |
SoniaSanzV
deleted the
a11y/ingest_pipelines-icon_duplicated_announcement#217818
branch
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @SoniaSanzV |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
SoniaSanzV
added a commit
to SoniaSanzV/kibana
that referenced
this pull request
Apr 15, 2026
…#259185) Part of elastic#217818 ## Summary - Prevent NVDA from announcing row action tooltips twice by aligning action label and tooltip text for ingest pipelines table actions. Only addresses the part we can take care, the rest must be addressed by EUI elastic/eui#9524 - Not directly related with this issue, fix some A11y warnings in the file, one aria-label and the tableCaption. ### Test plan - Manual (Windows 11 + Edge + NVDA): - Focus Edit/Delete icons in Actions column and confirm each is announced once. - Manual (MacOS + Chrome + Voice Over): - Verify no regressions. ### Accessibility notes - **Before**: NVDA could announce the action and then the tooltip text (duplicate output). - **After**: NVDA announces each action once; tooltip remains visible but is not announced on focus when label === tooltip content. ### Screenshot <img width="881" height="384" alt="Screenshot 2026-03-23 at 18 32 52" src="https://github.com/user-attachments/assets/c56df615-d0e2-4120-bcea-a965c7998e04" /> (cherry picked from commit b5b97e8) # Conflicts: # x-pack/platform/plugins/private/translations/translations/de-DE.json # x-pack/platform/plugins/private/translations/translations/fr-FR.json # x-pack/platform/plugins/private/translations/translations/ja-JP.json # x-pack/platform/plugins/private/translations/translations/zh-CN.json # x-pack/platform/plugins/shared/ingest_pipelines/__jest__/client_integration/ingest_pipelines_list.test.ts
SoniaSanzV
added a commit
to SoniaSanzV/kibana
that referenced
this pull request
Apr 15, 2026
…#259185) Part of elastic#217818 ## Summary - Prevent NVDA from announcing row action tooltips twice by aligning action label and tooltip text for ingest pipelines table actions. Only addresses the part we can take care, the rest must be addressed by EUI elastic/eui#9524 - Not directly related with this issue, fix some A11y warnings in the file, one aria-label and the tableCaption. ### Test plan - Manual (Windows 11 + Edge + NVDA): - Focus Edit/Delete icons in Actions column and confirm each is announced once. - Manual (MacOS + Chrome + Voice Over): - Verify no regressions. ### Accessibility notes - **Before**: NVDA could announce the action and then the tooltip text (duplicate output). - **After**: NVDA announces each action once; tooltip remains visible but is not announced on focus when label === tooltip content. ### Screenshot <img width="881" height="384" alt="Screenshot 2026-03-23 at 18 32 52" src="https://github.com/user-attachments/assets/c56df615-d0e2-4120-bcea-a965c7998e04" /> (cherry picked from commit b5b97e8) # Conflicts: # x-pack/platform/plugins/private/translations/translations/de-DE.json # x-pack/platform/plugins/private/translations/translations/fr-FR.json # x-pack/platform/plugins/private/translations/translations/ja-JP.json # x-pack/platform/plugins/private/translations/translations/zh-CN.json # x-pack/platform/plugins/shared/ingest_pipelines/__jest__/client_integration/ingest_pipelines_list.test.ts
SoniaSanzV
added a commit
to SoniaSanzV/kibana
that referenced
this pull request
Apr 15, 2026
…#259185) Part of elastic#217818 ## Summary - Prevent NVDA from announcing row action tooltips twice by aligning action label and tooltip text for ingest pipelines table actions. Only addresses the part we can take care, the rest must be addressed by EUI elastic/eui#9524 - Not directly related with this issue, fix some A11y warnings in the file, one aria-label and the tableCaption. ### Test plan - Manual (Windows 11 + Edge + NVDA): - Focus Edit/Delete icons in Actions column and confirm each is announced once. - Manual (MacOS + Chrome + Voice Over): - Verify no regressions. ### Accessibility notes - **Before**: NVDA could announce the action and then the tooltip text (duplicate output). - **After**: NVDA announces each action once; tooltip remains visible but is not announced on focus when label === tooltip content. ### Screenshot <img width="881" height="384" alt="Screenshot 2026-03-23 at 18 32 52" src="https://github.com/user-attachments/assets/c56df615-d0e2-4120-bcea-a965c7998e04" />
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
SoniaSanzV
added a commit
to SoniaSanzV/kibana
that referenced
this pull request
Apr 15, 2026
…#259185) Part of elastic#217818 - Prevent NVDA from announcing row action tooltips twice by aligning action label and tooltip text for ingest pipelines table actions. Only addresses the part we can take care, the rest must be addressed by EUI elastic/eui#9524 - Not directly related with this issue, fix some A11y warnings in the file, one aria-label and the tableCaption. - Manual (Windows 11 + Edge + NVDA): - Focus Edit/Delete icons in Actions column and confirm each is announced once. - Manual (MacOS + Chrome + Voice Over): - Verify no regressions. - **Before**: NVDA could announce the action and then the tooltip text (duplicate output). - **After**: NVDA announces each action once; tooltip remains visible but is not announced on focus when label === tooltip content. <img width="881" height="384" alt="Screenshot 2026-03-23 at 18 32 52" src="https://github.com/user-attachments/assets/c56df615-d0e2-4120-bcea-a965c7998e04" />
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
SoniaSanzV
added a commit
that referenced
this pull request
Apr 16, 2026
…259185) (#263333) # Backport This will backport the following commits from `main` to `9.3`: - [[Ingest pipelines] A11y: Avoid icon announcement duplication (#259185)](#259185) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sonia Sanz Vivas","email":"sonia.sanzvivas@elastic.co"},"sourceCommit":{"committedDate":"2026-04-10T13:56:50Z","message":"[Ingest pipelines] A11y: Avoid icon announcement duplication (#259185)\n\nPart of https://github.com/elastic/kibana/issues/217818\n\n## Summary\n- Prevent NVDA from announcing row action tooltips twice by aligning\naction label and tooltip text for ingest pipelines table actions. Only\naddresses the part we can take care, the rest must be addressed by EUI\nhttps://github.com/elastic/eui/issues/9524\n- Not directly related with this issue, fix some A11y warnings in the\nfile, one aria-label and the tableCaption.\n\n### Test plan\n- Manual (Windows 11 + Edge + NVDA):\n- Focus Edit/Delete icons in Actions column and confirm each is\nannounced once.\n- Manual (MacOS + Chrome + Voice Over):\n - Verify no regressions.\n \n### Accessibility notes\n- **Before**: NVDA could announce the action and then the tooltip text\n(duplicate output).\n- **After**: NVDA announces each action once; tooltip remains visible\nbut is not announced on focus when label === tooltip content.\n\n### Screenshot\n<img width=\"881\" height=\"384\" alt=\"Screenshot 2026-03-23 at 18 32 52\"\nsrc=\"https://github.com/user-attachments/assets/c56df615-d0e2-4120-bcea-a965c7998e04\"\n/>","sha":"b5b97e8ce21b4b3285f4df8d8b91c242fc7959d7","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Kibana Management","backport missing","Feature:Ingest Node Pipelines","backport:all-open","v9.4.0"],"title":"[Ingest pipelines] A11y: Avoid icon announcement duplication","number":259185,"url":"https://github.com/elastic/kibana/pull/259185","mergeCommit":{"message":"[Ingest pipelines] A11y: Avoid icon announcement duplication (#259185)\n\nPart of https://github.com/elastic/kibana/issues/217818\n\n## Summary\n- Prevent NVDA from announcing row action tooltips twice by aligning\naction label and tooltip text for ingest pipelines table actions. Only\naddresses the part we can take care, the rest must be addressed by EUI\nhttps://github.com/elastic/eui/issues/9524\n- Not directly related with this issue, fix some A11y warnings in the\nfile, one aria-label and the tableCaption.\n\n### Test plan\n- Manual (Windows 11 + Edge + NVDA):\n- Focus Edit/Delete icons in Actions column and confirm each is\nannounced once.\n- Manual (MacOS + Chrome + Voice Over):\n - Verify no regressions.\n \n### Accessibility notes\n- **Before**: NVDA could announce the action and then the tooltip text\n(duplicate output).\n- **After**: NVDA announces each action once; tooltip remains visible\nbut is not announced on focus when label === tooltip content.\n\n### Screenshot\n<img width=\"881\" height=\"384\" alt=\"Screenshot 2026-03-23 at 18 32 52\"\nsrc=\"https://github.com/user-attachments/assets/c56df615-d0e2-4120-bcea-a965c7998e04\"\n/>","sha":"b5b97e8ce21b4b3285f4df8d8b91c242fc7959d7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/259185","number":259185,"mergeCommit":{"message":"[Ingest pipelines] A11y: Avoid icon announcement duplication (#259185)\n\nPart of https://github.com/elastic/kibana/issues/217818\n\n## Summary\n- Prevent NVDA from announcing row action tooltips twice by aligning\naction label and tooltip text for ingest pipelines table actions. Only\naddresses the part we can take care, the rest must be addressed by EUI\nhttps://github.com/elastic/eui/issues/9524\n- Not directly related with this issue, fix some A11y warnings in the\nfile, one aria-label and the tableCaption.\n\n### Test plan\n- Manual (Windows 11 + Edge + NVDA):\n- Focus Edit/Delete icons in Actions column and confirm each is\nannounced once.\n- Manual (MacOS + Chrome + Voice Over):\n - Verify no regressions.\n \n### Accessibility notes\n- **Before**: NVDA could announce the action and then the tooltip text\n(duplicate output).\n- **After**: NVDA announces each action once; tooltip remains visible\nbut is not announced on focus when label === tooltip content.\n\n### Screenshot\n<img width=\"881\" height=\"384\" alt=\"Screenshot 2026-03-23 at 18 32 52\"\nsrc=\"https://github.com/user-attachments/assets/c56df615-d0e2-4120-bcea-a965c7998e04\"\n/>","sha":"b5b97e8ce21b4b3285f4df8d8b91c242fc7959d7"}}]}] BACKPORT-->
SoniaSanzV
added a commit
that referenced
this pull request
Apr 16, 2026
…259185) (#263340) # Backport This will backport the following commits from `main` to `8.19`: - [[Ingest pipelines] A11y: Avoid icon announcement duplication (#259185)](#259185) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sonia Sanz Vivas","email":"sonia.sanzvivas@elastic.co"},"sourceCommit":{"committedDate":"2026-04-10T13:56:50Z","message":"[Ingest pipelines] A11y: Avoid icon announcement duplication (#259185)\n\nPart of https://github.com/elastic/kibana/issues/217818\n\n## Summary\n- Prevent NVDA from announcing row action tooltips twice by aligning\naction label and tooltip text for ingest pipelines table actions. Only\naddresses the part we can take care, the rest must be addressed by EUI\nhttps://github.com/elastic/eui/issues/9524\n- Not directly related with this issue, fix some A11y warnings in the\nfile, one aria-label and the tableCaption.\n\n### Test plan\n- Manual (Windows 11 + Edge + NVDA):\n- Focus Edit/Delete icons in Actions column and confirm each is\nannounced once.\n- Manual (MacOS + Chrome + Voice Over):\n - Verify no regressions.\n \n### Accessibility notes\n- **Before**: NVDA could announce the action and then the tooltip text\n(duplicate output).\n- **After**: NVDA announces each action once; tooltip remains visible\nbut is not announced on focus when label === tooltip content.\n\n### Screenshot\n<img width=\"881\" height=\"384\" alt=\"Screenshot 2026-03-23 at 18 32 52\"\nsrc=\"https://github.com/user-attachments/assets/c56df615-d0e2-4120-bcea-a965c7998e04\"\n/>","sha":"b5b97e8ce21b4b3285f4df8d8b91c242fc7959d7","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Kibana Management","backport missing","Feature:Ingest Node Pipelines","backport:all-open","v9.4.0"],"title":"[Ingest pipelines] A11y: Avoid icon announcement duplication","number":259185,"url":"https://github.com/elastic/kibana/pull/259185","mergeCommit":{"message":"[Ingest pipelines] A11y: Avoid icon announcement duplication (#259185)\n\nPart of https://github.com/elastic/kibana/issues/217818\n\n## Summary\n- Prevent NVDA from announcing row action tooltips twice by aligning\naction label and tooltip text for ingest pipelines table actions. Only\naddresses the part we can take care, the rest must be addressed by EUI\nhttps://github.com/elastic/eui/issues/9524\n- Not directly related with this issue, fix some A11y warnings in the\nfile, one aria-label and the tableCaption.\n\n### Test plan\n- Manual (Windows 11 + Edge + NVDA):\n- Focus Edit/Delete icons in Actions column and confirm each is\nannounced once.\n- Manual (MacOS + Chrome + Voice Over):\n - Verify no regressions.\n \n### Accessibility notes\n- **Before**: NVDA could announce the action and then the tooltip text\n(duplicate output).\n- **After**: NVDA announces each action once; tooltip remains visible\nbut is not announced on focus when label === tooltip content.\n\n### Screenshot\n<img width=\"881\" height=\"384\" alt=\"Screenshot 2026-03-23 at 18 32 52\"\nsrc=\"https://github.com/user-attachments/assets/c56df615-d0e2-4120-bcea-a965c7998e04\"\n/>","sha":"b5b97e8ce21b4b3285f4df8d8b91c242fc7959d7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/259185","number":259185,"mergeCommit":{"message":"[Ingest pipelines] A11y: Avoid icon announcement duplication (#259185)\n\nPart of https://github.com/elastic/kibana/issues/217818\n\n## Summary\n- Prevent NVDA from announcing row action tooltips twice by aligning\naction label and tooltip text for ingest pipelines table actions. Only\naddresses the part we can take care, the rest must be addressed by EUI\nhttps://github.com/elastic/eui/issues/9524\n- Not directly related with this issue, fix some A11y warnings in the\nfile, one aria-label and the tableCaption.\n\n### Test plan\n- Manual (Windows 11 + Edge + NVDA):\n- Focus Edit/Delete icons in Actions column and confirm each is\nannounced once.\n- Manual (MacOS + Chrome + Voice Over):\n - Verify no regressions.\n \n### Accessibility notes\n- **Before**: NVDA could announce the action and then the tooltip text\n(duplicate output).\n- **After**: NVDA announces each action once; tooltip remains visible\nbut is not announced on focus when label === tooltip content.\n\n### Screenshot\n<img width=\"881\" height=\"384\" alt=\"Screenshot 2026-03-23 at 18 32 52\"\nsrc=\"https://github.com/user-attachments/assets/c56df615-d0e2-4120-bcea-a965c7998e04\"\n/>","sha":"b5b97e8ce21b4b3285f4df8d8b91c242fc7959d7"}}]}] BACKPORT-->
SoniaSanzV
added a commit
that referenced
this pull request
Apr 16, 2026
…259185) (#263336) # Backport This will backport the following commits from `main` to `9.2`: - [[Ingest pipelines] A11y: Avoid icon announcement duplication (#259185)](#259185) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sonia Sanz Vivas","email":"sonia.sanzvivas@elastic.co"},"sourceCommit":{"committedDate":"2026-04-10T13:56:50Z","message":"[Ingest pipelines] A11y: Avoid icon announcement duplication (#259185)\n\nPart of https://github.com/elastic/kibana/issues/217818\n\n## Summary\n- Prevent NVDA from announcing row action tooltips twice by aligning\naction label and tooltip text for ingest pipelines table actions. Only\naddresses the part we can take care, the rest must be addressed by EUI\nhttps://github.com/elastic/eui/issues/9524\n- Not directly related with this issue, fix some A11y warnings in the\nfile, one aria-label and the tableCaption.\n\n### Test plan\n- Manual (Windows 11 + Edge + NVDA):\n- Focus Edit/Delete icons in Actions column and confirm each is\nannounced once.\n- Manual (MacOS + Chrome + Voice Over):\n - Verify no regressions.\n \n### Accessibility notes\n- **Before**: NVDA could announce the action and then the tooltip text\n(duplicate output).\n- **After**: NVDA announces each action once; tooltip remains visible\nbut is not announced on focus when label === tooltip content.\n\n### Screenshot\n<img width=\"881\" height=\"384\" alt=\"Screenshot 2026-03-23 at 18 32 52\"\nsrc=\"https://github.com/user-attachments/assets/c56df615-d0e2-4120-bcea-a965c7998e04\"\n/>","sha":"b5b97e8ce21b4b3285f4df8d8b91c242fc7959d7","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Kibana Management","backport missing","Feature:Ingest Node Pipelines","backport:all-open","v9.4.0"],"title":"[Ingest pipelines] A11y: Avoid icon announcement duplication","number":259185,"url":"https://github.com/elastic/kibana/pull/259185","mergeCommit":{"message":"[Ingest pipelines] A11y: Avoid icon announcement duplication (#259185)\n\nPart of https://github.com/elastic/kibana/issues/217818\n\n## Summary\n- Prevent NVDA from announcing row action tooltips twice by aligning\naction label and tooltip text for ingest pipelines table actions. Only\naddresses the part we can take care, the rest must be addressed by EUI\nhttps://github.com/elastic/eui/issues/9524\n- Not directly related with this issue, fix some A11y warnings in the\nfile, one aria-label and the tableCaption.\n\n### Test plan\n- Manual (Windows 11 + Edge + NVDA):\n- Focus Edit/Delete icons in Actions column and confirm each is\nannounced once.\n- Manual (MacOS + Chrome + Voice Over):\n - Verify no regressions.\n \n### Accessibility notes\n- **Before**: NVDA could announce the action and then the tooltip text\n(duplicate output).\n- **After**: NVDA announces each action once; tooltip remains visible\nbut is not announced on focus when label === tooltip content.\n\n### Screenshot\n<img width=\"881\" height=\"384\" alt=\"Screenshot 2026-03-23 at 18 32 52\"\nsrc=\"https://github.com/user-attachments/assets/c56df615-d0e2-4120-bcea-a965c7998e04\"\n/>","sha":"b5b97e8ce21b4b3285f4df8d8b91c242fc7959d7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/259185","number":259185,"mergeCommit":{"message":"[Ingest pipelines] A11y: Avoid icon announcement duplication (#259185)\n\nPart of https://github.com/elastic/kibana/issues/217818\n\n## Summary\n- Prevent NVDA from announcing row action tooltips twice by aligning\naction label and tooltip text for ingest pipelines table actions. Only\naddresses the part we can take care, the rest must be addressed by EUI\nhttps://github.com/elastic/eui/issues/9524\n- Not directly related with this issue, fix some A11y warnings in the\nfile, one aria-label and the tableCaption.\n\n### Test plan\n- Manual (Windows 11 + Edge + NVDA):\n- Focus Edit/Delete icons in Actions column and confirm each is\nannounced once.\n- Manual (MacOS + Chrome + Voice Over):\n - Verify no regressions.\n \n### Accessibility notes\n- **Before**: NVDA could announce the action and then the tooltip text\n(duplicate output).\n- **After**: NVDA announces each action once; tooltip remains visible\nbut is not announced on focus when label === tooltip content.\n\n### Screenshot\n<img width=\"881\" height=\"384\" alt=\"Screenshot 2026-03-23 at 18 32 52\"\nsrc=\"https://github.com/user-attachments/assets/c56df615-d0e2-4120-bcea-a965c7998e04\"\n/>","sha":"b5b97e8ce21b4b3285f4df8d8b91c242fc7959d7"}}]}] BACKPORT-->
kibanamachine
added
v9.2.9
and removed
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #217818
Summary
Test plan
Accessibility notes
Screenshot