Backport PR #171226 to 8.x: Fix acceptance test assertions for updated plugin remove#17131
Merged
donoghuc merged 1 commit intoelastic:8.xfrom Feb 20, 2025
Merged
Backport PR #171226 to 8.x: Fix acceptance test assertions for updated plugin remove#17131donoghuc merged 1 commit intoelastic:8.xfrom
donoghuc merged 1 commit intoelastic:8.xfrom
Conversation
This commit updates the acceptance tests to expect messages in the updated format for removing plugins. See elastic#17030 for change.
|
Member
|
I think the details on this PR description are wrong, This appears to be the backport of #17126 (not #17122). I should have named the PR titles uniquely, sorry 😬. I will go ahead and edit the description and get this merged. We will need a backport of #17122 also. Looks like exhaustive tests are only on a timer trigger for 8.x so we have not seen failures yet. |
Member
donoghuc
approved these changes
Feb 20, 2025
Member
donoghuc
left a comment
There was a problem hiding this comment.
The conflict was on line 35 where in main a different method for running sudo command is used. This is the correct merge conflict resolution as we do not change line 35.
💛 Build succeeded, but was flaky
Failed CI Steps |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Backport PR #17126 to 8.x branch, original message:
Release notes
[rn:skip]
What does this PR do?
This commit updates the acceptance tests to expect messages in the updated format for removing plugins. See #17030 for change.
Why is it important/What is the impact to the user?
No user impact, this is fixing acceptance test assertions
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files (and/or docker env variables)- [ ] I have added tests that prove my fix is effective or that my feature worksRelated issues
removecommand to support multiple plugins #17030remove#17122Logs
Example failures:
https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/1361#01952103-6591-43cf-a364-cc876ac8bc21