Skip to content

compat: add test for deserializing stringref enabled and disabled#17989

Merged
yaauie merged 1 commit intoelastic:9.0from
yaauie:pq-cbor-stringref-tests-9-0
Sep 4, 2025
Merged

compat: add test for deserializing stringref enabled and disabled#17989
yaauie merged 1 commit intoelastic:9.0from
yaauie:pq-cbor-stringref-tests-9-0

Conversation

@yaauie
Copy link
Member

@yaauie yaauie commented Aug 14, 2025

Release notes

[rn: skip]

What does this PR do?

Adds tests to prove that enabling the CBOR stringref extension in #17849 does not create a rollback barrier.

Why is it important/What is the impact to the user?

We want to ensure that a user who has begun using LS 9.x (in which we plan to activate the CBOR stringref extension) can safely roll back to LS 9.0, even if stringref-enabled events are left behind in the PQ.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Related issues

@elasticmachine
Copy link

💛 Build succeeded, but was flaky

Failed CI Steps

@yaauie yaauie marked this pull request as ready for review August 19, 2025 15:29
Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yaauie yaauie merged commit 9120e4c into elastic:9.0 Sep 4, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip Skip automated backport with mergify persistent queues tests

3 participants