Ensure any file object in a tar archive has an mtime

[donoghuc]

Release notes

Summary

Following up on #18091, when minitar writes a directory or symlink it also needs explicit mtime. After inspecting artifacts built from #18019 we see some other missing mtimes. This commit ensures that information is explicitly passed to the minitar writer.

[github-actions]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

[mergify]

This pull request does not have a backport label. Could you fix it @donoghuc? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
• If no backport is necessary, please add the backport-skip label

[donoghuc]

Reminder this is the minitar impl https://github.com/halostatue/minitar/blob/main/lib/minitar/writer.rb

I noticed this looking at artifacts produced from https://buildkite.com/elastic/logstash-dra-snapshot-pipeline/builds/3680 based on #18091

➜  u curl -LO https://artifacts-snapshot.elastic.co/logstash/9.2.0-834691a1/downloads/logstash/logstash-9.2.0-SNAPSHOT-linux-x86_64.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  407M  100  407M    0     0  42.7M      0  0:00:09  0:00:09 --:--:-- 43.2M
➜  u tar -xf logstash-9.2.0-SNAPSHOT-linux-x86_64.tar.gz
➜  u cd logstash-9.2.0-SNAPSHOT
➜  logstash-9.2.0-SNAPSHOT ls -lt
total 1544
drwxr-xr-x@ 11 cas  wheel     352 Sep  3 14:12 jdk
drwxr-xr-x@ 14 cas  wheel     448 Sep  3 14:12 x-pack
drwxr-xr-x@  4 cas  wheel     128 Sep  3 14:12 vendor
drwxr-xr-x@  5 cas  wheel     160 Sep  3 14:12 logstash-core-plugin-api
drwxr-xr-x@  6 cas  wheel     192 Sep  3 14:12 logstash-core
drwxr-xr-x@  6 cas  wheel     192 Sep  3 14:12 lib
drwxr-xr-x@  8 cas  wheel     256 Sep  3 14:12 config
drwxr-xr-x@ 20 cas  wheel     640 Sep  3 14:12 bin
-rw-r--r--@  1 cas  wheel   30907 Sep  3 13:06 Gemfile.lock
-rw-r--r--@  1 cas  wheel      16 Sep  3 13:00 JDK_VERSION
-rw-r--r--@  1 cas  wheel    4449 Sep  3 12:58 Gemfile
-rw-r--r--@  1 cas  wheel    2276 Sep  3 12:56 CONTRIBUTORS
-rw-r--r--@  1 cas  wheel   13675 Sep  3 12:56 LICENSE.txt
-rw-r--r--@  1 cas  wheel  724574 Sep  3 12:56 NOTICE.TXT
drwxr-xr-x@  2 cas  wheel      64 Dec 31  1969 data

You can see that the empty data dir we lay down in packaging also has a missing mtime. This led me to look at the other Writer methods we use (mkdir and symlink) and see we need to include those as well.

[jsvd]

LGTM, minor edit suggestion to document why we did it.

[elastic-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

[elasticmachine]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: b95eded

Failed CI Steps

• 🥼 IT Persistent Queues / part 4-of-6

History

• 💚 Build #3429 succeeded a493fa1

[donoghuc]

handling backports manually with the existing PRs that inspired this follow on.